FileCacheTrait::dumpVariableToCache() - Code Metrics - Inspection of "many improvements" - brainexe/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fa5de...689521 )

by Matze

created 2015-12-02 19:43 UTC

FileCacheTrait::dumpVariableToCache() A

↳ Parent: FileCacheTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	2
crap	1

<?php

namespace BrainExe\Core\Traits;

use BrainExe\Annotations\Annotations\Inject;
use Doctrine\Common\Cache\CacheProvider;

/**
 * @api
 */
trait FileCacheTrait
{

    /**
     * @param string $name
     * @return mixed
     */
    protected function includeFile($name)
    {
        $filename = $this->getCacheFileName($name);
        if (!is_file($filename)) {
            return null;
        }
        return include $filename;
    }

    /**
     * @param string $name
     * @param string $content
     */
    protected function dumpCacheFile($name, $content)
    {
        $fileName = $this->getCacheFileName($name);

        file_put_contents($fileName, '<?php' . PHP_EOL . $content);
        @chmod($fileName, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * @param string $name
     * @param mixed $variable
     */
    protected function dumpVariableToCache($name, $variable)
    {
        $this->dumpCacheFile($name, 'return ' . var_export($variable, true) . ';');
    }

    /**
     * @param string $name
     * @return string
     */
    private function getCacheFileName($name)
    {
        return ROOT . 'cache/' . basename($name, '.php')  . '.php';
    }
}


1		<?php
2
3		namespace BrainExe\Core\Traits;
4
5		use BrainExe\Annotations\Annotations\Inject;
6		use Doctrine\Common\Cache\CacheProvider;
7
8		/**
9		* @api
10		*/
11		trait FileCacheTrait
12		{
13
14		/**
15		* @param string $name
16		* @return mixed
17		*/
18		protected function includeFile($name)
19		{
20		$filename = $this->getCacheFileName($name);
21		if (!is_file($filename)) {
22		return null;
23		}
24		return include $filename;
25		}
26
27		/**
28		* @param string $name
29		* @param string $content
30		*/
31	2	protected function dumpCacheFile($name, $content)
32		{
33	2	$fileName = $this->getCacheFileName($name);
34
35	2	file_put_contents($fileName, '<?php' . PHP_EOL . $content);
36	2	@chmod($fileName, 0777);
		0 ignored issues – show Security Best Practice introduced 2015-12-02 19:46 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
37	2	}
38
39		/**
40		* @param string $name
41		* @param mixed $variable
42		*/
43	2	protected function dumpVariableToCache($name, $variable)
44		{
45	2	$this->dumpCacheFile($name, 'return ' . var_export($variable, true) . ';');
46	2	}
47
48		/**
49		* @param string $name
50		* @return string
51		*/
52	2	private function getCacheFileName($name)
53		{
54	2	return ROOT . 'cache/' . basename($name, '.php') . '.php';
55		}
56		}
57

brainexe / core

Push — master ( 5fa5de...689521 )

FileCacheTrait::dumpVariableToCache() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like