RedisCompilerPass::process() - Code Metrics - Inspection of "cleaned up Loggers" - brainexe/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e221c0...5a5b2e )

by Matze

created 2016-04-20 17:00 UTC

RedisCompilerPass::process() A

↳ Parent: RedisCompilerPass

Complexity

Conditions	2
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2.108

Importance

Changes	11
Bugs	0	Features	6

Metric	Value
c	11
b	0
f	6
dl	0
loc	17
ccs	7
cts	10
cp	0.7
rs	9.4285
cc	2
eloc	10
nc	3
nop	1
crap	2.108

<?php

namespace BrainExe\Core\DependencyInjection\CompilerPass;

use BrainExe\Core\Annotations\CompilerPass;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;

/**
 * @CompilerPass(priority=9)
 */
class RedisCompilerPass implements CompilerPassInterface
{

    /**
     * {@inheritdoc}
     */
    public function process(ContainerBuilder $container)
    {
        $redis = $container->getDefinition('redis');

        $masterArguments = $this->getArguments($container, '');

        try {
            $slaveArguments = $this->getArguments($container, '.slave');
            $parameters = [$masterArguments, $slaveArguments];
            $options    = ['replication' => true];

            $redis->setArguments([$parameters, $options]);
        } catch (ParameterNotFoundException $e) {
            // master only
            $redis->setArguments([$masterArguments]);
        }
    }

    /**
     * @param ContainerBuilder $container
     * @param string $prefix
     * @return string
     */
    protected function getArguments(ContainerBuilder $container, string $prefix) : string
    {
        return $container->getParameter("redis$prefix.connection");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }
}


1		<?php
2
3		namespace BrainExe\Core\DependencyInjection\CompilerPass;
4
5		use BrainExe\Core\Annotations\CompilerPass;
6		use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
7		use Symfony\Component\DependencyInjection\ContainerBuilder;
8		use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;
9
10		/**
11		* @CompilerPass(priority=9)
12		*/
13		class RedisCompilerPass implements CompilerPassInterface
14		{
15
16		/**
17		* {@inheritdoc}
18		*/
19	3	public function process(ContainerBuilder $container)
20		{
21	3	$redis = $container->getDefinition('redis');
22
23	3	$masterArguments = $this->getArguments($container, '');
24
25		try {
26	3	$slaveArguments = $this->getArguments($container, '.slave');
27		$parameters = [$masterArguments, $slaveArguments];
28		$options = ['replication' => true];
29
30		$redis->setArguments([$parameters, $options]);
31	3	} catch (ParameterNotFoundException $e) {
32		// master only
33	3	$redis->setArguments([$masterArguments]);
34		}
35	3	}
36
37		/**
38		* @param ContainerBuilder $container
39		* @param string $prefix
40		* @return string
41		*/
42	3	protected function getArguments(ContainerBuilder $container, string $prefix) : string
43		{
44	3	return $container->getParameter("redis$prefix.connection");
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-22 21:06 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$prefix` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
45		}
46		}
47

brainexe / core

Push — master ( e221c0...5a5b2e )

RedisCompilerPass::process() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like