Setting::set() - Code Metrics - Inspection of "Fixing an issue where an update query would return..." - bradcornford/Setter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v1.5.7 ( 10f56a )

by Bradley

created 2016-06-16 14:06 UTC

Setting::set() A

↳ Parent: Setting

Complexity

Conditions	4
Paths	6

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	0	Features	4

Metric	Value
c	10
b	0
f	4
dl	0
loc	18
rs	9.2
cc	4
eloc	12
nc	6
nop	2

<?php namespace Cornford\Setter;

use Cornford\Setter\Contracts\SettableInterface;
use Cornford\Setter\Exceptions\SettingVariableException;

class Setting extends SettingBase implements SettableInterface {

	/**
	 * Set a setting by key and value
	 *
	 * @param string  $key
	 * @param string  $value
	 *
	 * @return boolean
	 */
	public function set($key, $value)
	{
		$query = $this->database
			->table('settings');
		$value = json_encode($value);

		if ($this->has($key)) {
			$result = $query->where('key', $key)
				->update(array('value' => $value));
			$result = ($result == 0 ? true : $result);
		} else {
			$result = $query->insert(array('key' => $key, 'value' => $value));
		}

		$this->recacheItem($value, $key);

		return $result ? true : false;
	}

	/**
	 * Get a setting by key, optionally set a default or fallback to config lookup
	 *
	 * @param string  $key
	 * @param string  $default
	 *
	 * @return string|array|boolean
	 */
	public function get($key, $default = null)
	{
		if ($this->cacheHas($key)) {
			return $this->returnCache($key);
		}

		$results = $this->database
			->table('settings')
			->where('settings.key', '=', $key)
			->whereRaw('settings.key LIKE "' . $key . '.%"', array(), 'or')
			->lists('value', 'key');

		if ($results) {
			return $this->returnResults($results, $key);
		}

		if ($default) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			return $default;
		}

		if ($this->configHas($key)) {
			return $this->returnConfig($key);
		}

		return false;
	}

	/**
	 * Forget a setting by key
	 *
	 * @param string $key
	 *
	 * @return boolean
	 */
	public function forget($key)
	{
		$result = $this->database
			->table('settings')
			->where('key', '=', $key)
			->delete();

		$this->cache
			->forget($this->attachTag($key));

		return $result ? true : false;
	}

	/**
	 * Check a setting exists by key
	 *
	 * @param string $key
	 *
	 * @return boolean
	 */
	public function has($key)
	{
		if ($this->cacheHas($this->attachTag($key))) {
			$result = true;
		} else {
			$result = $this->database
				->table('settings')
				->select('settings.value')
				->where('settings.key', '=', $key)
				->count();
		}

		return $result ? true : false;
	}

	/**
	 * Get all stored settings
	 *
	 * @return array
	 */
	public function all()
	{
		$results = $this->database
			->table('settings')
			->lists('value', 'key');

		return $this->arrangeResults($results);
	}

	/**
	 * Clear all stored settings
	 *
	 * @return boolean
	 */
	public function clear()
	{
		$result = $this->database
			->table('settings')
			->truncate();

		$this->cacheClear();

		return $result ? true : false;
	}

	/**
	 * Set the cache expiry
	 *
	 * @param boolean|integer|datetime $expiry
	 *
	 * @throws SettingVariableException
	 *
	 * @return self
	 */
	public function expires($expiry)
	{
		if (!is_bool($expiry) && !is_integer($expiry) && !$expiry instanceof \DateTime) {
			throw new SettingVariableException('Invalid expiry value.');
		}

		$this->expiry = $expiry;

		return $this;
	}

}


1			<?php namespace Cornford\Setter;
2
3			use Cornford\Setter\Contracts\SettableInterface;
4			use Cornford\Setter\Exceptions\SettingVariableException;
5
6			class Setting extends SettingBase implements SettableInterface {
7
8			/**
9			* Set a setting by key and value
10			*
11			* @param string $key
12			* @param string $value
13			*
14			* @return boolean
15			*/
16			public function set($key, $value)
17			{
18			$query = $this->database
19			->table('settings');
20			$value = json_encode($value);
21
22			if ($this->has($key)) {
23			$result = $query->where('key', $key)
24			->update(array('value' => $value));
25			$result = ($result == 0 ? true : $result);
26			} else {
27			$result = $query->insert(array('key' => $key, 'value' => $value));
28			}
29
30			$this->recacheItem($value, $key);
31
32			return $result ? true : false;
33			}
34
35			/**
36			* Get a setting by key, optionally set a default or fallback to config lookup
37			*
38			* @param string $key
39			* @param string $default
40			*
41			* @return string\|array\|boolean
42			*/
43			public function get($key, $default = null)
44			{
45			if ($this->cacheHas($key)) {
46			return $this->returnCache($key);
47			}
48
49			$results = $this->database
50			->table('settings')
51			->where('settings.key', '=', $key)
52			->whereRaw('settings.key LIKE "' . $key . '.%"', array(), 'or')
53			->lists('value', 'key');
54
55			if ($results) {
56			return $this->returnResults($results, $key);
57			}
58
59			if ($default) {
			0 ignored issues – show Bug Best Practice introduced 2016-05-03 11:44 UTC by Report Bug Copy Issue Report The expression `$default` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
60			return $default;
61			}
62
63			if ($this->configHas($key)) {
64			return $this->returnConfig($key);
65			}
66
67			return false;
68			}
69
70			/**
71			* Forget a setting by key
72			*
73			* @param string $key
74			*
75			* @return boolean
76			*/
77			public function forget($key)
78			{
79			$result = $this->database
80			->table('settings')
81			->where('key', '=', $key)
82			->delete();
83
84			$this->cache
85			->forget($this->attachTag($key));
86
87			return $result ? true : false;
88			}
89
90			/**
91			* Check a setting exists by key
92			*
93			* @param string $key
94			*
95			* @return boolean
96			*/
97			public function has($key)
98			{
99			if ($this->cacheHas($this->attachTag($key))) {
100			$result = true;
101			} else {
102			$result = $this->database
103			->table('settings')
104			->select('settings.value')
105			->where('settings.key', '=', $key)
106			->count();
107			}
108
109			return $result ? true : false;
110			}
111
112			/**
113			* Get all stored settings
114			*
115			* @return array
116			*/
117			public function all()
118			{
119			$results = $this->database
120			->table('settings')
121			->lists('value', 'key');
122
123			return $this->arrangeResults($results);
124			}
125
126			/**
127			* Clear all stored settings
128			*
129			* @return boolean
130			*/
131			public function clear()
132			{
133			$result = $this->database
134			->table('settings')
135			->truncate();
136
137			$this->cacheClear();
138
139			return $result ? true : false;
140			}
141
142			/**
143			* Set the cache expiry
144			*
145			* @param boolean\|integer\|datetime $expiry
146			*
147			* @throws SettingVariableException
148			*
149			* @return self
150			*/
151			public function expires($expiry)
152			{
153			if (!is_bool($expiry) && !is_integer($expiry) && !$expiry instanceof \DateTime) {
154			throw new SettingVariableException('Invalid expiry value.');
155			}
156
157			$this->expiry = $expiry;
158
159			return $this;
160			}
161
162			}
163

bradcornford / Setter

Push — v1.5.7 ( 10f56a )

Setting::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like