AnalyticsServiceProvider::boot() - Code Metrics - Inspection of "Updating composer.json to require illuminate packa..." - bradcornford/Googlitics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 42db1a...85f3f0 )

by Bradley

created 2016-06-14 12:43 UTC

AnalyticsServiceProvider::boot() A

↳ Parent: AnalyticsServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	3
b	0
f	0
nc	1
nop	0
dl	0
loc	12
rs	9.4285

<?php namespace Cornford\Googlitics;

use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Facades\Config;

class AnalyticsServiceProvider extends ServiceProvider {

	/**
	 * Indicates if loading of the provider is deferred.
	 *
	 * @var bool
	 */
	protected $defer = false;

	/**
	 * Bootstrap the application events.
	 *
	 * @return void
	 */
	public function boot()
	{
		$this->loadViewsFrom(base_path('resources/views/cornford/googlitics'), 'googlitics');

		$this->publishes(
			[
				__DIR__ . '/../../config/config.php' => config_path('googlitics.php'),
				__DIR__ . '/../../views' => base_path('resources/views/cornford/googlitics')
			],
			'googlitics'
		);
	}

	/**
	 * Register the service provider.
	 *
	 * @return void
	 */
	public function register()
	{
		$configPath = __DIR__ . '/../../config/config.php';
		$this->mergeConfigFrom($configPath, 'googlitics');

		$this->app['analytics'] = $this->app->share(function($app)
		{
			return new Analytics(
				$this->app->make('Illuminate\Foundation\Application'),
				$this->app->view,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$app['config']->get('googlitics')
			);
		});
	}

	/**
	 * Get the services provided by the provider.
	 *
	 * @return array
	 */
	public function provides()
	{
		return array('analytics');
	}

}


1			<?php namespace Cornford\Googlitics;
2
3			use Illuminate\Support\ServiceProvider;
4			use Illuminate\Support\Facades\Config;
5
6			class AnalyticsServiceProvider extends ServiceProvider {
7
8			/**
9			* Indicates if loading of the provider is deferred.
10			*
11			* @var bool
12			*/
13			protected $defer = false;
14
15			/**
16			* Bootstrap the application events.
17			*
18			* @return void
19			*/
20			public function boot()
21			{
22			$this->loadViewsFrom(base_path('resources/views/cornford/googlitics'), 'googlitics');
23
24			$this->publishes(
25			[
26			__DIR__ . '/../../config/config.php' => config_path('googlitics.php'),
27			__DIR__ . '/../../views' => base_path('resources/views/cornford/googlitics')
28			],
29			'googlitics'
30			);
31			}
32
33			/**
34			* Register the service provider.
35			*
36			* @return void
37			*/
38			public function register()
39			{
40			$configPath = __DIR__ . '/../../config/config.php';
41			$this->mergeConfigFrom($configPath, 'googlitics');
42
43			$this->app['analytics'] = $this->app->share(function($app)
44			{
45			return new Analytics(
46			$this->app->make('Illuminate\Foundation\Application'),
47			$this->app->view,
			0 ignored issues – show Bug introduced 2016-06-14 12:51 UTC by Report Bug Copy Issue Report Accessing `view` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48			$app['config']->get('googlitics')
49			);
50			});
51			}
52
53			/**
54			* Get the services provided by the provider.
55			*
56			* @return array
57			*/
58			public function provides()
59			{
60			return array('analytics');
61			}
62
63			}
64

bradcornford / Googlitics

Push — master ( 42db1a...85f3f0 )

AnalyticsServiceProvider::boot() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like