Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Cornford\Backup\Engines; |
||
3 | class BackupEngineSqlsrv extends BackupEngineAbstract { |
||
4 | |||
5 | const ENGINE_NAME = 'sqlsrv'; |
||
6 | const ENGINE_EXTENSION = 'bak'; |
||
7 | const ENGINE_EXPORT_PROCESS = 'SqlCmd'; |
||
8 | const ENGINE_RESTORE_PROCESS = 'SqlCmd'; |
||
9 | |||
10 | /** |
||
11 | * Get export process. |
||
12 | * |
||
13 | * @return string |
||
14 | */ |
||
15 | public function getExportProcess() |
||
19 | |||
20 | /** |
||
21 | * Get restore process. |
||
22 | * |
||
23 | * @return string |
||
24 | */ |
||
25 | public function getRestoreProcess() |
||
29 | |||
30 | /** |
||
31 | * Get database file extension. |
||
32 | * |
||
33 | * @return string |
||
34 | */ |
||
35 | public function getFileExtension() |
||
39 | |||
40 | /** |
||
41 | * Export the database to a file path. |
||
42 | * |
||
43 | * @param string $filepath |
||
44 | * |
||
45 | * @return boolean |
||
46 | */ |
||
47 | View Code Duplication | public function export($filepath) |
|
60 | |||
61 | /** |
||
62 | * Restore the database from a file path. |
||
63 | * |
||
64 | * @param string $filepath |
||
65 | * |
||
66 | * @return boolean |
||
67 | */ |
||
68 | View Code Duplication | public function restore($filepath) |
|
80 | |||
81 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.