bpolaszek / string-combinations

src/NoDuplicateLettersStringCombinations.php

<?php

namespace BenTools\StringCombinations;

use Countable;
use Generator;
use IteratorAggregate;
use Traversable;

final class NoDuplicateLettersStringCombinations implements IteratorAggregate, Countable
{
    private StringCombinations $stringCombinations;

    public function __construct(StringCombinations $stringCombinations)
    {
        $this->stringCombinations = $stringCombinations;
    }

    public function getIterator(): Traversable
    {
        for ($i = $this->stringCombinations->min; $i <= $this->stringCombinations->max; $i++) {

The property $max is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

The property $min is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

            foreach ($this->permute($this->stringCombinations->charset, $i) as $combination) {

The property $charset is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

                yield implode($this->stringCombinations->glue, $combination);

The property $glue is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

            }
        }
    }

    public function count(): int
    {
        $arr = [];

        for ($pos = $this->stringCombinations->max, $i = 0; $pos >= $this->stringCombinations->min; $pos--, $i++) {

The property $max is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

The property $min is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

            if (0 === $i) {
                $arr[$i] = [$pos];
            } else {
                $arr[$i] = array_merge($arr[$i - 1], [$pos]);
            }
        }

        return array_sum(array_map('array_product', $arr));

The expression return array_sum(array_map('array_product', $arr)) could return the type double which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }

    private function permute(array $charset, $length = null): Generator
    {
        $n = count($charset);

        if (null === $length) {
            $length = $n;
        }

        if ($length > $n) {
            return;
        }

        $indices = range(0, $n - 1);
        $cycles = range($n, $n - $length + 1, -1);

        yield array_slice($charset, 0, $length);

        if ($n <= 0) {
            return;
        }

        while (true) {
            $exitEarly = false;
            for ($i = $length; $i--;) {
                $cycles[$i]-= 1;
                if ($cycles[$i] == 0) {
                    if ($i < count($indices)) {
                        $removed = array_splice($indices, $i, 1);
                        $indices[] = $removed[0];
                    }
                    $cycles[$i] = $n - $i;
                } else {
                    $j = $cycles[$i];
                    $value = $indices[$i];
                    $negative = $indices[count($indices) - $j];
                    $indices[$i] = $negative;
                    $indices[count($indices) - $j] = $value;
                    $result = [];
                    $counter = 0;
                    foreach ($indices as $index) {
                        $result[] = $charset[$index];
                        $counter++;
                        if ($counter == $length) {
                            break;
                        }
                    }
                    yield $result;
                    $exitEarly = true;
                    break;
                }
            }
            if (!$exitEarly) {
                break;
            }
        }
    }

    public function getRandomString(): string
    {
        $charset = $this->stringCombinations->charset;

The property $charset is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

        $string = [];

        $length = random_int($this->stringCombinations->min, $this->stringCombinations->max);

The property $max is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

The property $min is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

        for ($pos = 1; $pos <= $length; $pos++) {
            shuffle($charset);

            $string[] = array_shift($charset);
        }

        return implode($this->stringCombinations->glue, $string);

The property $glue is declared private in BenTools\StringCombinations\StringCombinations. Since you implement __get, consider adding a @property or @property-read.

    }

    public function asArray(): array
    {
        return iterator_to_array($this);
    }
}