FlatRenderer::__construct() - Code Metrics - Inspection of "feat: flat renderer (#3)" - bpolaszek/querystring - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d37ec...c4dba6 )

by BENOIT

created 2020-10-16 12:43 UTC

FlatRenderer::__construct() A

↳ Parent: FlatRenderer

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace BenTools\QueryString\Renderer;

use BenTools\QueryString\QueryString;

final class FlatRenderer implements QueryStringRendererInterface
{
    /**
     * @var NativeRenderer
     */
    private $renderer;

    protected function __construct(QueryStringRendererInterface $renderer = null)
    {
        $this->renderer = $renderer;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    public static function factory(QueryStringRendererInterface $renderer = null)
    {
        return new self($renderer ?? NativeRenderer::factory());
    }

    /**
     * @inheritDoc
     */
    public function render(QueryString $queryString): string
    {
        $separator = $this->getSeparator() ?? ini_get('arg_separator.output');
        $parts = [[]];

        foreach ($queryString->getParams() as $key => $value) {
            $parts[] = $this->getParts($key, $value);
        }

        return \implode($separator, \array_merge([], ...$parts));
    }

    /**
     * @inheritDoc
     */
    public function getEncoding(): int
    {
        return $this->renderer->getEncoding();
    }

    /**
     * @inheritDoc
     */
    public function withEncoding(int $encoding): QueryStringRendererInterface
    {
        return new self($this->renderer->withEncoding($encoding));
    }

    /**
     * @inheritDoc
     */
    public function getSeparator(): ?string
    {
        return $this->renderer->getSeparator();
    }

    /**
     * @inheritDoc
     */
    public function withSeparator(?string $separator): QueryStringRendererInterface
    {
        return new self($this->renderer->withSeparator($separator));
    }

    private function getParts($key, $value): array
    {
        if (\is_iterable($value)) {
            $parts = [[]];
            foreach ($value as $sub) {
                $parts[] = $this->getParts($key, $sub);
            }

            return \array_merge([], ...$parts);
        }

        $encode = \PHP_QUERY_RFC1738 === $this->getEncoding() ? '\\urlencode' : '\\rawurlencode';

        return [$key . '=' . \call_user_func($encode, $value)];
    }
}


1			<?php
2
3			namespace BenTools\QueryString\Renderer;
4
5			use BenTools\QueryString\QueryString;
6
7			final class FlatRenderer implements QueryStringRendererInterface
8			{
9			/**
10			* @var NativeRenderer
11			*/
12			private $renderer;
13
14			protected function __construct(QueryStringRendererInterface $renderer = null)
15			{
16			$this->renderer = $renderer;
			0 ignored issues – show Documentation Bug introduced 2020-10-16 12:20 UTC by Report Bug Copy Issue Report It seems like `$renderer` can also be of type `object<BenTools\QueryStr...tringRendererInterface>`. However, the property `$renderer` is declared as type `object<BenTools\QueryStr...enderer\NativeRenderer>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
17			}
18
19			public static function factory(QueryStringRendererInterface $renderer = null)
20			{
21			return new self($renderer ?? NativeRenderer::factory());
22			}
23
24			/**
25			* @inheritDoc
26			*/
27			public function render(QueryString $queryString): string
28			{
29			$separator = $this->getSeparator() ?? ini_get('arg_separator.output');
30			$parts = [[]];
31
32			foreach ($queryString->getParams() as $key => $value) {
33			$parts[] = $this->getParts($key, $value);
34			}
35
36			return \implode($separator, \array_merge([], ...$parts));
37			}
38
39			/**
40			* @inheritDoc
41			*/
42			public function getEncoding(): int
43			{
44			return $this->renderer->getEncoding();
45			}
46
47			/**
48			* @inheritDoc
49			*/
50			public function withEncoding(int $encoding): QueryStringRendererInterface
51			{
52			return new self($this->renderer->withEncoding($encoding));
53			}
54
55			/**
56			* @inheritDoc
57			*/
58			public function getSeparator(): ?string
59			{
60			return $this->renderer->getSeparator();
61			}
62
63			/**
64			* @inheritDoc
65			*/
66			public function withSeparator(?string $separator): QueryStringRendererInterface
67			{
68			return new self($this->renderer->withSeparator($separator));
69			}
70
71			private function getParts($key, $value): array
72			{
73			if (\is_iterable($value)) {
74			$parts = [[]];
75			foreach ($value as $sub) {
76			$parts[] = $this->getParts($key, $sub);
77			}
78
79			return \array_merge([], ...$parts);
80			}
81
82			$encode = \PHP_QUERY_RFC1738 === $this->getEncoding() ? '\\urlencode' : '\\rawurlencode';
83
84			return [$key . '=' . \call_user_func($encode, $value)];
85			}
86			}
87

bpolaszek / querystring

Push — master ( 6d37ec...c4dba6 )

FlatRenderer::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like