BenTools\MercurePHP\Storage\StorageFactory

Complexity

Total Complexity

11

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	supports()	0	9	3
A	create()	0	11	3
A	getFactories()	0	14	4

<?php

namespace BenTools\MercurePHP\Storage;

use React\Promise\PromiseInterface;

final class StorageFactory implements StorageFactoryInterface
{
    /**
     * @var StorageFactoryInterface[]
     */
    private iterable $factories;

    public function __construct(iterable $factories)
    {
        $this->factories = $factories;

It seems like $factories of type iterable is incompatible with the declared type BenTools\MercurePHP\Storage\StorageFactoryInterface[] of property $factories.

    }

    public function supports(string $dsn): bool
    {
        foreach ($this->getFactories() as $factory) {
            if ($factory->supports($dsn)) {
                return true;
            }
        }

        return false;
    }

    public function create(string $dsn): PromiseInterface
    {
        foreach ($this->getFactories() as $factory) {
            if (!$factory->supports($dsn)) {
                continue;
            }

            return $factory->create($dsn);
        }

        throw new \RuntimeException(\sprintf('Invalid storage DSN %s', $dsn));
    }

    private function getFactories(): array
    {
        if (\is_array($this->factories)) {
            return $this->factories;

The expression return $this->factories returns the type iterable which is incompatible with the type-hinted return array.

        }

        $factories = [];
        foreach ($this->factories as $factory) {
            if ($factory === $this) {
                continue;
            }
            $factories[] = $factory;
        }
        return $this->factories = (fn(StorageFactoryInterface ...$factories) => $factories)(...$factories);
    }
}