SubscriptionsController::__invoke() - Code Metrics - Inspection of "Feat: Subscriptions api" - bpolaszek/mercure-php-hub - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#17)

by BENOIT

created 2020-10-11 06:55 UTC

SubscriptionsController::__invoke() B

↳ Parent: SubscriptionsController

Complexity

Conditions	6
Paths	6

Size

Total Lines	66
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	44
nc	6
nop	1
dl	0
loc	66
rs	8.5937
c	1
b	0
f	0

How to fix Long Method

<?php

namespace BenTools\MercurePHP\Controller;

use BenTools\MercurePHP\Exception\Http\AccessDeniedHttpException;
use BenTools\MercurePHP\Hub\Hub;
use BenTools\MercurePHP\Model\Subscription;
use BenTools\MercurePHP\Security\Authenticator;
use BenTools\MercurePHP\Security\TopicMatcher;
use BenTools\MercurePHP\Storage\StorageInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use React\Http\Message\Response;
use React\Stream\ThroughStream;
use React\Stream\WritableStreamInterface;

use function BenTools\MercurePHP\nullify;

final class SubscriptionsController extends AbstractController
{
    private const PATH = '/.well-known/mercure/subscriptions';
    private const TOPIC_SELECTOR = '/.well-known/mercure/subscriptions/{topic}/{subscriber}';
    private Hub $hub;
    private Authenticator $authenticator;

    public function __construct(Hub $hub, Authenticator $authenticator)
    {
        $this->hub = $hub;
        $this->authenticator = $authenticator;
    }

    public function __invoke(ServerRequestInterface $request): ResponseInterface
    {
        if (!\in_array($request->getMethod(), ['GET', 'HEAD', 'OPTIONS'])) {
            return new Response(405);
        }

        $path = $request->getUri()->getPath();
        $filters = \explode('/', \trim(\strtr($path, [self::PATH => '']), '/'), 2);
        $topic = nullify($filters[0]);
        $subscriber = nullify($filters[1] ?? null);

        $token = $this->authenticator->authenticate($request);

        if (null === $token) {
            throw new AccessDeniedHttpException('You must be authenticated to access the Subscription API.');
        }

        $claim = (array) $token->getClaim('mercure');
        $allowedTopics = $claim['subscribe'] ?? [];
        $deniedTopics = $claim['subscribe_exclude'] ?? [];
        $topicSelector = $path === self::PATH ? self::TOPIC_SELECTOR : $path;
        $matchAllowedTopics = TopicMatcher::matchesTopicSelectors($topicSelector, $allowedTopics);
        $matchDeniedTopics = TopicMatcher::matchesTopicSelectors($topicSelector, $deniedTopics);
        if (!$matchAllowedTopics || $matchDeniedTopics) {
            throw new AccessDeniedHttpException('You are not authorized to display these subscriptions.');
        }

        $stream = new ThroughStream();
        $this->hub->hook(
            function () use ($stream, $path, $subscriber, $topic, $allowedTopics, $deniedTopics) {
                $this->hub->getLastEventID()->then(
                    function (?string $lastEventId) use (
                        $topic,
                        $subscriber,
                        $stream,
                        $path,
                        $allowedTopics,
                        $deniedTopics
                    ) {
                        $this->hub->getActiveSubscriptions($topic, $subscriber)
                            ->then(
                                function (iterable $subscriptions) use (
                                    $stream,
                                    $path,
                                    $allowedTopics,
                                    $deniedTopics,
                                    $lastEventId
                                ) {
                                    $subscriptions = $this->filterSubscriptions(
                                        $subscriptions,
                                        $allowedTopics,
                                        $deniedTopics
                                    );
                                    $this->sendResult($path, $lastEventId, $subscriptions, $stream);
                                }
                            );
                    }
                );
            }
        );

        $headers = [
            'Content-Type' => 'application/ld+json',
        ];

        return new Response(200, $headers, $stream);
    }

    public function matchRequest(RequestInterface $request): bool
    {
        return 0 === \strpos($request->getUri()->getPath(), self::PATH);
    }

    private function filterSubscriptions(iterable $subscriptions, array $allowedTopics, array $deniedTopics): array
    {
        $subscriptions = \iterable_to_array($subscriptions);
        $subscriptions = \array_filter(
            $subscriptions,
            function (Subscription $subscription) use ($allowedTopics, $deniedTopics) {
                $matchAllowedTopics = TopicMatcher::matchesTopicSelectors(
                    $subscription->getId(),
                    $allowedTopics
                );
                $matchDeniedTopics = TopicMatcher::matchesTopicSelectors(
                    $subscription->getId(),
                    $deniedTopics
                );

                return $matchAllowedTopics && !$matchDeniedTopics;
            }
        );

        return \array_values($subscriptions);
    }

    private function sendResult(
        string $path,
        ?string $lastEventId,
        array $subscriptions,
        WritableStreamInterface $stream
    ): void {
        $result = [
            '@context' => 'https://mercure.rocks/',
            'id' => $path,
            'type' => 'Subscriptions',
            'lastEventID' => $lastEventId ?? StorageInterface::EARLIEST,
            'subscriptions' => $subscriptions,
        ];
        $stream->write(\json_encode($result, \JSON_THROW_ON_ERROR));
        $stream->end();
        $stream->close();
    }
}


1			<?php
2
3			namespace BenTools\MercurePHP\Controller;
4
5			use BenTools\MercurePHP\Exception\Http\AccessDeniedHttpException;
6			use BenTools\MercurePHP\Hub\Hub;
7			use BenTools\MercurePHP\Model\Subscription;
8			use BenTools\MercurePHP\Security\Authenticator;
9			use BenTools\MercurePHP\Security\TopicMatcher;
10			use BenTools\MercurePHP\Storage\StorageInterface;
11			use Psr\Http\Message\RequestInterface;
12			use Psr\Http\Message\ResponseInterface;
13			use Psr\Http\Message\ServerRequestInterface;
14			use React\Http\Message\Response;
15			use React\Stream\ThroughStream;
16			use React\Stream\WritableStreamInterface;
17
18			use function BenTools\MercurePHP\nullify;
19
20			final class SubscriptionsController extends AbstractController
21			{
22			private const PATH = '/.well-known/mercure/subscriptions';
23			private const TOPIC_SELECTOR = '/.well-known/mercure/subscriptions/{topic}/{subscriber}';
24			private Hub $hub;
25			private Authenticator $authenticator;
26
27			public function __construct(Hub $hub, Authenticator $authenticator)
28			{
29			$this->hub = $hub;
30			$this->authenticator = $authenticator;
31			}
32
33			public function __invoke(ServerRequestInterface $request): ResponseInterface
34			{
35			if (!\in_array($request->getMethod(), ['GET', 'HEAD', 'OPTIONS'])) {
36			return new Response(405);
37			}
38
39			$path = $request->getUri()->getPath();
40			$filters = \explode('/', \trim(\strtr($path, [self::PATH => '']), '/'), 2);
41			$topic = nullify($filters[0]);
42			$subscriber = nullify($filters[1] ?? null);
43
44			$token = $this->authenticator->authenticate($request);
45
46			if (null === $token) {
47			throw new AccessDeniedHttpException('You must be authenticated to access the Subscription API.');
48			}
49
50			$claim = (array) $token->getClaim('mercure');
51			$allowedTopics = $claim['subscribe'] ?? [];
52			$deniedTopics = $claim['subscribe_exclude'] ?? [];
53			$topicSelector = $path === self::PATH ? self::TOPIC_SELECTOR : $path;
54			$matchAllowedTopics = TopicMatcher::matchesTopicSelectors($topicSelector, $allowedTopics);
55			$matchDeniedTopics = TopicMatcher::matchesTopicSelectors($topicSelector, $deniedTopics);
56			if (!$matchAllowedTopics \|\| $matchDeniedTopics) {
57			throw new AccessDeniedHttpException('You are not authorized to display these subscriptions.');
58			}
59
60			$stream = new ThroughStream();
61			$this->hub->hook(
62			function () use ($stream, $path, $subscriber, $topic, $allowedTopics, $deniedTopics) {
63			$this->hub->getLastEventID()->then(
64			function (?string $lastEventId) use (
65			$topic,
66			$subscriber,
67			$stream,
68			$path,
69			$allowedTopics,
70			$deniedTopics
71			) {
72			$this->hub->getActiveSubscriptions($topic, $subscriber)
73			->then(
74			function (iterable $subscriptions) use (
75			$stream,
76			$path,
77			$allowedTopics,
78			$deniedTopics,
79			$lastEventId
80			) {
81			$subscriptions = $this->filterSubscriptions(
82			$subscriptions,
83			$allowedTopics,
84			$deniedTopics
85			);
86			$this->sendResult($path, $lastEventId, $subscriptions, $stream);
87			}
88			);
89			}
90			);
91			}
92			);
93
94			$headers = [
95			'Content-Type' => 'application/ld+json',
96			];
97
98			return new Response(200, $headers, $stream);
99			}
100
101			public function matchRequest(RequestInterface $request): bool
102			{
103			return 0 === \strpos($request->getUri()->getPath(), self::PATH);
104			}
105
106			private function filterSubscriptions(iterable $subscriptions, array $allowedTopics, array $deniedTopics): array
107			{
108			$subscriptions = \iterable_to_array($subscriptions);
109			$subscriptions = \array_filter(
110			$subscriptions,
111			function (Subscription $subscription) use ($allowedTopics, $deniedTopics) {
112			$matchAllowedTopics = TopicMatcher::matchesTopicSelectors(
113			$subscription->getId(),
114			$allowedTopics
115			);
116			$matchDeniedTopics = TopicMatcher::matchesTopicSelectors(
117			$subscription->getId(),
118			$deniedTopics
119			);
120
121			return $matchAllowedTopics && !$matchDeniedTopics;
122			}
123			);
124
125			return \array_values($subscriptions);
126			}
127
128			private function sendResult(
129			string $path,
130			?string $lastEventId,
131			array $subscriptions,
132			WritableStreamInterface $stream
133			): void {
134			$result = [
135			'@context' => 'https://mercure.rocks/',
136			'id' => $path,
137			'type' => 'Subscriptions',
138			'lastEventID' => $lastEventId ?? StorageInterface::EARLIEST,
139			'subscriptions' => $subscriptions,
140			];
141			$stream->write(\json_encode($result, \JSON_THROW_ON_ERROR));
142			$stream->end();
143			$stream->close();
144			}
145			}
146

bpolaszek / mercure-php-hub

Pull Request — master (#17)

SubscriptionsController::__invoke() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like