StorageFactory::create() - Code Metrics - Inspection of "refactor: leverage Symfony DI when possible" - bpolaszek/mercure-php-hub - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#21)

by BENOIT

created 2021-01-03 15:28 UTC

StorageFactory::create() A

↳ Parent: StorageFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.072

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	11
ccs	4
cts	5
cp	0.8
crap	3.072
rs	10
c	0
b	0
f	0

<?php

namespace BenTools\MercurePHP\Storage;

use React\Promise\PromiseInterface;

final class StorageFactory implements StorageFactoryInterface
{
    /**
     * @var StorageFactoryInterface[]
     */
    private iterable $factories;

    public function __construct(iterable $factories)
    {
        $this->factories = $factories;

    }

    public function supports(string $dsn): bool
    {
        foreach ($this->getFactories() as $factory) {
            if ($factory->supports($dsn)) {
                return true;
            }
        }

        return false;
    }

    public function create(string $dsn): PromiseInterface
    {
        foreach ($this->getFactories() as $factory) {
            if (!$factory->supports($dsn)) {
                continue;
            }

            return $factory->create($dsn);
        }

        throw new \RuntimeException(\sprintf('Invalid storage DSN %s', $dsn));
    }

    private function getFactories(): array
    {
        if (\is_array($this->factories)) {
            return $this->factories;

        }

        $factories = [];
        foreach ($this->factories as $factory) {
            if ($factory === $this) {
                continue;
            }
            $factories[] = $factory;
        }
        return $this->factories = (fn(StorageFactoryInterface ...$factories) => $factories)(...$factories);
    }
}


1		<?php
2
3		namespace BenTools\MercurePHP\Storage;
4
5		use React\Promise\PromiseInterface;
6
7		final class StorageFactory implements StorageFactoryInterface
8		{
9		/**
10		* @var StorageFactoryInterface[]
11		*/
12		private iterable $factories;
13
14		public function __construct(iterable $factories)
15		{
16		$this->factories = $factories;
		0 ignored issues – show Documentation Bug introduced 2021-01-03 15:30 UTC by Report Bug Copy Issue Report It seems like `$factories` of type `iterable` is incompatible with the declared type `BenTools\MercurePHP\Stor...orageFactoryInterface[]` of property `$factories`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
17		}
18
19	2	public function supports(string $dsn): bool
20		{
21	2	foreach ($this->getFactories() as $factory) {
22	2	if ($factory->supports($dsn)) {
23		return true;
24	1	}
25		}
26	1
27	1	return false;
28	1	}
29
30		public function create(string $dsn): PromiseInterface
31		{
32		foreach ($this->getFactories() as $factory) {
33		if (!$factory->supports($dsn)) {
34		continue;
35	1	}
36
37	1	return $factory->create($dsn);
38	1	}
39	1
40		throw new \RuntimeException(\sprintf('Invalid storage DSN %s', $dsn));
41		}
42	1
43		private function getFactories(): array
44		{
45		if (\is_array($this->factories)) {
46		return $this->factories;
		0 ignored issues – show Bug Best Practice introduced 2021-01-03 15:30 UTC by Report Bug Copy Issue Report The expression `return $this->factories` returns the type `iterable` which is incompatible with the type-hinted return `array`. Loading history...
47		}
48	2
49		$factories = [];
50	2	foreach ($this->factories as $factory) {
51		if ($factory === $this) {
52	2	continue;
53	2	}
54	2	$factories[] = $factory;
55		}
56		return $this->factories = (fn(StorageFactoryInterface ...$factories) => $factories)(...$factories);
57		}
58		}
59

bpolaszek / mercure-php-hub

Pull Request — master (#21)

StorageFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like