Issues in QueueHandler.php (master) - Issues in master - bpolaszek/guzzle-queue-handler - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/QueueHandler.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BenTools\GuzzleQueueHandler;

use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Promise\Promise;
use function GuzzleHttp\Psr7\parse_response;
use function GuzzleHttp\Psr7\str;
use Interop\Queue\PsrConnectionFactory;
use Interop\Queue\PsrContext;
use Interop\Queue\PsrQueue;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\UriInterface;

class QueueHandler
{
    /**
     * @var PsrContext
     */
    private $context;

    /**
     * @var PsrQueue
     */
    private $queue;
    /**
     * @var int
     */
    private $timeout;


    /**
     * EnqueuePromisor constructor.
     * @param PsrContext $context
     * @param string     $queueName
     * @param float      $timeout
     * @throws \InvalidArgumentException
     */
    public function __construct(PsrContext $context, $queueName = '', $timeout = 0.0)
    {
        $this->context = $context;
        if ('' === $queueName) {
            throw new \InvalidArgumentException("Queue name must not be blank.");
        }
        $this->queue = $context->createQueue($queueName);
        $this->timeout = (float) $timeout;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * @param PsrConnectionFactory $factory
     * @param string               $queueName
     * @param float                $timeout
     * @return QueueHandler
     */
    public static function factory(PsrConnectionFactory $factory, $queueName = '', $timeout = 0.0)
    {
        $context = $factory->createContext();
        return new static($context, $queueName, $timeout);
    }

    /**
     * @param RequestInterface $request
     * @return Promise
     * @throws \Interop\Queue\Exception
     * @throws \Interop\Queue\InvalidDestinationException
     * @throws \Interop\Queue\InvalidMessageException
     * @throws \InvalidArgumentException
     */
    public function __invoke(RequestInterface $request, array $options)
    {
        $message = $this->wrap($request, $options);
        $replyTo = $this->queue->getQueueName() . strtr(uniqid(null, true), '.', 0);
        $message->setReplyTo($replyTo);
        $this->context->createProducer()->send($this->queue, $message);
        $promise = new Promise(function () use (&$promise, $replyTo, $request) {
            try {
                $queue = $this->context->createQueue($replyTo);
                $consumer = $this->context->createConsumer($queue);


                if (0.0 === $this->timeout) {
                    while (null === ($message = $consumer->receive())) {
                        usleep(100);
                    }
                } else {
                    $max = microtime(true) + $this->timeout;
                    while (null === ($message = $consumer->receive($this->timeout)) && microtime(true) <= $max) {
                        usleep(100);
                    }
                }

                if (null === $message) {
                    throw new RequestException('Timeout reached.', $request);
                }

                if (null !== $message->getProperty('error')) {
                    throw RequestException::create($request, null, new \RuntimeException($message->getProperty('error')));
                }
                $consumer->acknowledge($message);
                $response = parse_response($message->getBody());
                $promise->resolve($response);
            } catch (\Exception $e) {
                $promise->reject($e);
            }
        });
        return $promise;
    }

    /**
     * @param RequestInterface $request
     * @param array            $options
     * @return \Interop\Queue\PsrMessage
     * @throws \InvalidArgumentException
     */
    private function wrap(RequestInterface $request, array $options)
    {
        if (isset($options['base_uri']) && $options['base_uri'] instanceof UriInterface) {
            $options['base_uri'] = (string) $options['base_uri'];
        }
        $message = $this->context->createMessage(json_encode([
            str($request->withRequestTarget((string) $request->getUri())),
            $options,
        ]));
        return $message;
    }
}


1			<?php
2
3			namespace BenTools\GuzzleQueueHandler;
4
5			use GuzzleHttp\Exception\RequestException;
6			use GuzzleHttp\Promise\Promise;
7			use function GuzzleHttp\Psr7\parse_response;
8			use function GuzzleHttp\Psr7\str;
9			use Interop\Queue\PsrConnectionFactory;
10			use Interop\Queue\PsrContext;
11			use Interop\Queue\PsrQueue;
12			use Psr\Http\Message\RequestInterface;
13			use Psr\Http\Message\UriInterface;
14
15			class QueueHandler
16			{
17			/**
18			* @var PsrContext
19			*/
20			private $context;
21
22			/**
23			* @var PsrQueue
24			*/
25			private $queue;
26			/**
27			* @var int
28			*/
29			private $timeout;
30
31
32			/**
33			* EnqueuePromisor constructor.
34			* @param PsrContext $context
35			* @param string $queueName
36			* @param float $timeout
37			* @throws \InvalidArgumentException
38			*/
39			public function __construct(PsrContext $context, $queueName = '', $timeout = 0.0)
40			{
41			$this->context = $context;
42			if ('' === $queueName) {
43			throw new \InvalidArgumentException("Queue name must not be blank.");
44			}
45			$this->queue = $context->createQueue($queueName);
46			$this->timeout = (float) $timeout;
			0 ignored issues – show Documentation Bug introduced 2017-07-10 16:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$timeout` was declared of type `integer`, but `(double) $timeout` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
47			}
48
49			/**
50			* @param PsrConnectionFactory $factory
51			* @param string $queueName
52			* @param float $timeout
53			* @return QueueHandler
54			*/
55			public static function factory(PsrConnectionFactory $factory, $queueName = '', $timeout = 0.0)
56			{
57			$context = $factory->createContext();
58			return new static($context, $queueName, $timeout);
59			}
60
61			/**
62			* @param RequestInterface $request
63			* @return Promise
64			* @throws \Interop\Queue\Exception
65			* @throws \Interop\Queue\InvalidDestinationException
66			* @throws \Interop\Queue\InvalidMessageException
67			* @throws \InvalidArgumentException
68			*/
69			public function __invoke(RequestInterface $request, array $options)
70			{
71			$message = $this->wrap($request, $options);
72			$replyTo = $this->queue->getQueueName() . strtr(uniqid(null, true), '.', 0);
73			$message->setReplyTo($replyTo);
74			$this->context->createProducer()->send($this->queue, $message);
75			$promise = new Promise(function () use (&$promise, $replyTo, $request) {
76			try {
77			$queue = $this->context->createQueue($replyTo);
78			$consumer = $this->context->createConsumer($queue);
79
80
81			if (0.0 === $this->timeout) {
82			while (null === ($message = $consumer->receive())) {
83			usleep(100);
84			}
85			} else {
86			$max = microtime(true) + $this->timeout;
87			while (null === ($message = $consumer->receive($this->timeout)) && microtime(true) <= $max) {
88			usleep(100);
89			}
90			}
91
92			if (null === $message) {
93			throw new RequestException('Timeout reached.', $request);
94			}
95
96			if (null !== $message->getProperty('error')) {
97			throw RequestException::create($request, null, new \RuntimeException($message->getProperty('error')));
98			}
99			$consumer->acknowledge($message);
100			$response = parse_response($message->getBody());
101			$promise->resolve($response);
102			} catch (\Exception $e) {
103			$promise->reject($e);
104			}
105			});
106			return $promise;
107			}
108
109			/**
110			* @param RequestInterface $request
111			* @param array $options
112			* @return \Interop\Queue\PsrMessage
113			* @throws \InvalidArgumentException
114			*/
115			private function wrap(RequestInterface $request, array $options)
116			{
117			if (isset($options['base_uri']) && $options['base_uri'] instanceof UriInterface) {
118			$options['base_uri'] = (string) $options['base_uri'];
119			}
120			$message = $this->context->createMessage(json_encode([
121			str($request->withRequestTarget((string) $request->getUri())),
122			$options,
123			]));
124			return $message;
125			}
126			}
127

bpolaszek / guzzle-queue-handler

Issues (3)

Security Analysis no request data

src/QueueHandler.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like