Row::__construct() - Code Metrics - Inspection of "Row objects and Cell styling" - box/spout - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — develop_3.0 (#434)

by Hura

created 2017-10-04 11:32 UTC

Row::__construct() A

↳ Parent: Row

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	3
crap	1

<?php

namespace Box\Spout\Writer\Common\Entity;

use Box\Spout\Writer\Common\Entity\Style\Style;
use Box\Spout\Writer\Common\Manager\RowManager;
use Box\Spout\Writer\Common\Manager\Style\StyleMerger;

class Row
{
    /**
     * The cells in this row
     * @var array
     */
    protected $cells = [];

    /**
     * The row style
     * @var null|Style
     */
    protected $style = null;

    /**
     * Thw row manager
     * @var RowManager
     */
    protected $rowManager;

    /**
     * Row constructor.
     * @param Cell[] $cells
     * @param Style|null $style
     * @param RowManager $rowManager
     */
    public function __construct(array $cells = [], Style $style = null, RowManager $rowManager)
    {
        $this
            ->setCells($cells)
            ->setStyle($style);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}

        $this->rowManager = $rowManager;
    }

    /**
     * @return Cell[] $cells
     */
    public function getCells()
    {
        return $this->cells;
    }

    /**
     * @param array $cells
     * @return $this
     */
    public function setCells(array $cells)
    {
        $this->cells = [];
        foreach ($cells as $cell) {
            $this->addCell($cell);
        }
        return $this;
    }

    /**
     * @return Style
     */
    public function getStyle()
    {
        if (!isset($this->style)) {
            $this->setStyle(new Style());
        }
        return $this->style;
    }

    /**
     * @param Style $style
     * @return Row
     */
    public function setStyle($style)
    {
        $this->style = $style;
        return $this;
    }

    /**
     * @param Style $style|null
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Row
     */
    public function applyStyle(Style $style = null)
    {
        $this->rowManager->applyStyle($this, $style);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
        return $this;
    }

    /**
     * @param Cell $cell
     * @return Row
     */
    public function addCell(Cell $cell)
    {
        $this->cells[] = $cell;
        return $this;
    }

    /**
     * Detect whether this row is considered empty.
     * An empty row has either no cells at all - or only empty cells
     *
     * @return bool
     */
    public function isEmpty()
    {
        return $this->rowManager->isEmpty($this);
    }
}


1		<?php
2
3		namespace Box\Spout\Writer\Common\Entity;
4
5		use Box\Spout\Writer\Common\Entity\Style\Style;
6		use Box\Spout\Writer\Common\Manager\RowManager;
7		use Box\Spout\Writer\Common\Manager\Style\StyleMerger;
8
9		class Row
10		{
11		/**
12		* The cells in this row
13		* @var array
14		*/
15		protected $cells = [];
16
17		/**
18		* The row style
19		* @var null\|Style
20		*/
21		protected $style = null;
22
23		/**
24		* Thw row manager
25		* @var RowManager
26		*/
27		protected $rowManager;
28
29		/**
30		* Row constructor.
31		* @param Cell[] $cells
32		* @param Style\|null $style
33		* @param RowManager $rowManager
34		*/
35	87	public function __construct(array $cells = [], Style $style = null, RowManager $rowManager)
36		{
37		$this
38	87	->setCells($cells)
39	87	->setStyle($style);
		0 ignored issues – show Bug introduced 2017-05-30 10:40 UTC by Report Bug Copy Issue Report It seems like `$style` defined by parameter `$style` on line `35` can be `null`; however, `Box\Spout\Writer\Common\Entity\Row::setStyle()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
40
41	87	$this->rowManager = $rowManager;
42	87	}
43
44		/**
45		* @return Cell[] $cells
46		*/
47	75	public function getCells()
48		{
49	75	return $this->cells;
50		}
51
52		/**
53		* @param array $cells
54		* @return $this
55		*/
56	87	public function setCells(array $cells)
57		{
58	87	$this->cells = [];
59	87	foreach ($cells as $cell) {
60	84	$this->addCell($cell);
61		}
62	87	return $this;
63		}
64
65		/**
66		* @return Style
67		*/
68	61	public function getStyle()
69		{
70	61	if (!isset($this->style)) {
71	45	$this->setStyle(new Style());
72		}
73	61	return $this->style;
74		}
75
76		/**
77		* @param Style $style
78		* @return Row
79		*/
80	87	public function setStyle($style)
81		{
82	87	$this->style = $style;
83	87	return $this;
84		}
85
86		/**
87		* @param Style $style\|null
		0 ignored issues – show Bug introduced 2017-05-30 10:40 UTC by Report Bug Copy Issue Report There is no parameter named `$style\|null`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
88		* @return Row
89		*/
90		public function applyStyle(Style $style = null)
91		{
92		$this->rowManager->applyStyle($this, $style);
		0 ignored issues – show Bug introduced 2017-07-31 19:01 UTC by Report Bug Copy Issue Report It seems like `$style` defined by parameter `$style` on line `90` can be `null`; however, `Box\Spout\Writer\Common\...owManager::applyStyle()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
93		return $this;
94		}
95
96		/**
97		* @param Cell $cell
98		* @return Row
99		*/
100	85	public function addCell(Cell $cell)
101		{
102	85	$this->cells[] = $cell;
103	85	return $this;
104		}
105
106		/**
107		* Detect whether this row is considered empty.
108		* An empty row has either no cells at all - or only empty cells
109		*
110		* @return bool
111		*/
112	70	public function isEmpty()
113		{
114	70	return $this->rowManager->isEmpty($this);
115		}
116		}
117

box / spout

Pull Request — develop_3.0 (#434)

Row::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like