RowManager::fillMissingIndexesWithEmptyCells() - Code Metrics - Inspection of "various improvements" - box/spout - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop_3.0 (#511)

by Adrien

created 2017-11-19 01:13 UTC

RowManager::fillMissingIndexesWithEmptyCells() A

↳ Parent: RowManager

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	17
c	0
b	0
f	0
ccs	9
cts	9
cp	1
rs	9.2
cc	4
eloc	9
nc	4
nop	1
crap	4

<?php

namespace Box\Spout\Reader\Common\Manager;

use Box\Spout\Reader\Common\Creator\InternalEntityFactoryInterface;
use Box\Spout\Reader\Common\Entity\Row;

/**
 * Class RowManager
 */
class RowManager
{
    /** @var InternalEntityFactoryInterface Factory to create entities */
    private $entityFactory;

    /**
     * @param InternalEntityFactoryInterface $entityFactory Factory to create entities
     */
    public function __construct(InternalEntityFactoryInterface $entityFactory)
    {
        $this->entityFactory = $entityFactory;
    }

    /**
     * Detect whether a row is considered empty.
     * An empty row has all of its cells empty.
     *
     * @param Row $row
     * @return bool
     */
    public function isEmpty(Row $row)
    {
        foreach ($row->getCells() as $cell) {
            if (!$cell->isEmpty()) {
                return false;
            }
        }

        return true;
    }

    /**
     * Fills the missing indexes of a row with empty cells.
     *
     * @param Row $row
     * @return Row
     */
    public function fillMissingIndexesWithEmptyCells(Row $row)
    {
        if ($row->getNumCells() === 0) {
            return $row;
        }

        $rowCells = $row->getCells();
        $maxCellIndex = max(array_keys($rowCells));

        for ($cellIndex = 0; $cellIndex < $maxCellIndex; $cellIndex++) {
            if (!isset($rowCells[$cellIndex])) {
                $row->setCellAtIndex($this->entityFactory->createCell(''), $cellIndex);
            }
        }

        return $row;
    }
}


1		<?php
2
3		namespace Box\Spout\Reader\Common\Manager;
4
5		use Box\Spout\Reader\Common\Creator\InternalEntityFactoryInterface;
6		use Box\Spout\Reader\Common\Entity\Row;
7
8		/**
9		* Class RowManager
10		*/
11		class RowManager
12		{
13		/** @var InternalEntityFactoryInterface Factory to create entities */
14		private $entityFactory;
15
16		/**
17		* @param InternalEntityFactoryInterface $entityFactory Factory to create entities
18		*/
19	73	public function __construct(InternalEntityFactoryInterface $entityFactory)
20		{
21	73	$this->entityFactory = $entityFactory;
22	73	}
23
24		/**
25		* Detect whether a row is considered empty.
26		* An empty row has all of its cells empty.
27		*
28		* @param Row $row
29		* @return bool
30		*/
31	63	public function isEmpty(Row $row)
32		{
33	63	foreach ($row->getCells() as $cell) {
34	57	if (!$cell->isEmpty()) {
35	57	return false;
36		}
37		}
38
39	15	return true;
40		}
41
42		/**
43		* Fills the missing indexes of a row with empty cells.
44		*
45		* @param Row $row
46		* @return Row
47		*/
48	23	public function fillMissingIndexesWithEmptyCells(Row $row)
49		{
50	23	if ($row->getNumCells() === 0) {
51	1	return $row;
52		}
53
54	22	$rowCells = $row->getCells();
55	22	$maxCellIndex = max(array_keys($rowCells));
56
57	22	for ($cellIndex = 0; $cellIndex < $maxCellIndex; $cellIndex++) {
58	20	if (!isset($rowCells[$cellIndex])) {
59	2	$row->setCellAtIndex($this->entityFactory->createCell(''), $cellIndex);
60		}
61		}
62
63	22	return $row;
64		}
65		}
66

box / spout

Pull Request — develop_3.0 (#511)

RowManager::fillMissingIndexesWithEmptyCells() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like