EntityFactory::__construct() - Code Metrics - Inspection of "Move Sheet to Common/Entity" - box/spout - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop_3.0 (#438)

by Adrien

created 2017-05-30 14:43 UTC

EntityFactory::__construct() A

↳ Parent: EntityFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Box\Spout\Writer\Common\Creator;

use Box\Spout\Writer\Common\Entity\Sheet;
use Box\Spout\Writer\Common\Entity\Workbook;
use Box\Spout\Writer\Common\Entity\Worksheet;

/**
 * Class EntityFactory
 * Factory to create entities
 *
 * @package Box\Spout\Writer\Common\Creator
 */
class EntityFactory
{
    /** @var ManagerFactory */
    private $managerFactory;

    /**
     * EntityFactory constructor.
     *
     * @param ManagerFactory $managerFactory
     */
    public function __construct(ManagerFactory $managerFactory)
    {
        $this->managerFactory = $managerFactory;
    }

    /**
     * @return Workbook
     */
    public function createWorkbook()
    {
        return new Workbook();
    }

    /**
     * @param string $worksheetFilePath
     * @param Sheet $externalSheet
     * @return Worksheet
     */
    public function createWorksheet($worksheetFilePath, Sheet $externalSheet)
    {
        return new Worksheet($worksheetFilePath, $externalSheet);
    }

    /**
     * @param int $sheetIndex Index of the sheet, based on order in the workbook (zero-based)
     * @param string $associatedWorkbookId ID of the sheet's associated workbook
     * @return Sheet
     */
    public function createSheet($sheetIndex, $associatedWorkbookId)
    {
        $sheetManager = $this->managerFactory->createSheetManager();
        return new Sheet($sheetIndex, $associatedWorkbookId, $sheetManager);
    }
}

1		<?php
2
3		namespace Box\Spout\Writer\Common\Creator;
4
5		use Box\Spout\Writer\Common\Entity\Sheet;
6		use Box\Spout\Writer\Common\Entity\Workbook;
7		use Box\Spout\Writer\Common\Entity\Worksheet;
8
9		/**
10		* Class EntityFactory
11		* Factory to create entities
12		*
13		* @package Box\Spout\Writer\Common\Creator
14		*/
15		class EntityFactory
16		{
17		/** @var ManagerFactory */
18		private $managerFactory;
19
20		/**
21		* EntityFactory constructor.
22		*
23		* @param ManagerFactory $managerFactory
24		*/
25	99	public function __construct(ManagerFactory $managerFactory)
26		{
27	99	$this->managerFactory = $managerFactory;
28	99	}
29
30		/**
31		* @return Workbook
32		*/
33	89	public function createWorkbook()
34		{
35	89	return new Workbook();
36		}
37
38		/**
39		* @param string $worksheetFilePath
40		* @param Sheet $externalSheet
41		* @return Worksheet
42		*/
43	89	public function createWorksheet($worksheetFilePath, Sheet $externalSheet)
44		{
45	89	return new Worksheet($worksheetFilePath, $externalSheet);
46		}
47
48		/**
49		* @param int $sheetIndex Index of the sheet, based on order in the workbook (zero-based)
50		* @param string $associatedWorkbookId ID of the sheet's associated workbook
51		* @return Sheet
52		*/
53	89	public function createSheet($sheetIndex, $associatedWorkbookId)
54		{
55	89	$sheetManager = $this->managerFactory->createSheetManager();
56	89	return new Sheet($sheetIndex, $associatedWorkbookId, $sheetManager);
57		}
58		}

box / spout

Pull Request — develop_3.0 (#438)

EntityFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like