Complex classes like Style often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Style, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 11 | class Style |
||
| 12 | { |
||
| 13 | /** Default font values */ |
||
| 14 | const DEFAULT_FONT_SIZE = 11; |
||
| 15 | const DEFAULT_FONT_COLOR = Color::BLACK; |
||
| 16 | const DEFAULT_FONT_NAME = 'Arial'; |
||
| 17 | |||
| 18 | /** @var int|null Style ID */ |
||
| 19 | protected $id = null; |
||
| 20 | |||
| 21 | /** @var bool Whether the font should be bold */ |
||
| 22 | protected $fontBold = false; |
||
| 23 | /** @var bool Whether the bold property was set */ |
||
| 24 | protected $hasSetFontBold = false; |
||
| 25 | |||
| 26 | /** @var bool Whether the font should be italic */ |
||
| 27 | protected $fontItalic = false; |
||
| 28 | /** @var bool Whether the italic property was set */ |
||
| 29 | protected $hasSetFontItalic = false; |
||
| 30 | |||
| 31 | /** @var bool Whether the font should be underlined */ |
||
| 32 | protected $fontUnderline = false; |
||
| 33 | /** @var bool Whether the underline property was set */ |
||
| 34 | protected $hasSetFontUnderline = false; |
||
| 35 | |||
| 36 | /** @var bool Whether the font should be struck through */ |
||
| 37 | protected $fontStrikethrough = false; |
||
| 38 | /** @var bool Whether the strikethrough property was set */ |
||
| 39 | protected $hasSetFontStrikethrough = false; |
||
| 40 | |||
| 41 | /** @var int Font size */ |
||
| 42 | protected $fontSize = self::DEFAULT_FONT_SIZE; |
||
| 43 | /** @var bool Whether the font size property was set */ |
||
| 44 | protected $hasSetFontSize = false; |
||
| 45 | |||
| 46 | /** @var string Font color */ |
||
| 47 | protected $fontColor = self::DEFAULT_FONT_COLOR; |
||
| 48 | /** @var bool Whether the font color property was set */ |
||
| 49 | protected $hasSetFontColor = false; |
||
| 50 | |||
| 51 | /** @var string Font name */ |
||
| 52 | protected $fontName = self::DEFAULT_FONT_NAME; |
||
| 53 | /** @var bool Whether the font name property was set */ |
||
| 54 | protected $hasSetFontName = false; |
||
| 55 | |||
| 56 | /** @var bool Whether specific font properties should be applied */ |
||
| 57 | protected $shouldApplyFont = false; |
||
| 58 | |||
| 59 | /** @var bool Whether the text should wrap in the cell (useful for long or multi-lines text) */ |
||
| 60 | protected $shouldWrapText = false; |
||
| 61 | /** @var bool Whether the wrap text property was set */ |
||
| 62 | protected $hasSetWrapText = false; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @var Border |
||
| 66 | */ |
||
| 67 | protected $border = null; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var bool Whether border properties should be applied |
||
| 71 | */ |
||
| 72 | protected $shouldApplyBorder = false; |
||
| 73 | |||
| 74 | /** @var string Background color */ |
||
| 75 | protected $backgroundColor = null; |
||
| 76 | |||
| 77 | /** @var bool */ |
||
| 78 | protected $hasSetBackgroundColor = false; |
||
| 79 | |||
| 80 | |||
| 81 | /** |
||
| 82 | * @return int|null |
||
| 83 | */ |
||
| 84 | 228 | public function getId() |
|
| 88 | |||
| 89 | /** |
||
| 90 | * @param int $id |
||
| 91 | * @return Style |
||
| 92 | */ |
||
| 93 | 270 | public function setId($id) |
|
| 98 | |||
| 99 | /** |
||
| 100 | * @return Border |
||
| 101 | */ |
||
| 102 | 96 | public function getBorder() |
|
| 106 | |||
| 107 | /** |
||
| 108 | * @param Border $border |
||
| 109 | */ |
||
| 110 | 24 | public function setBorder(Border $border) |
|
| 116 | |||
| 117 | /** |
||
| 118 | * @return boolean |
||
| 119 | */ |
||
| 120 | 258 | public function shouldApplyBorder() |
|
| 124 | |||
| 125 | /** |
||
| 126 | * @return boolean |
||
| 127 | */ |
||
| 128 | 150 | public function isFontBold() |
|
| 132 | |||
| 133 | /** |
||
| 134 | * @return Style |
||
| 135 | */ |
||
| 136 | 48 | public function setFontBold() |
|
| 143 | |||
| 144 | /** |
||
| 145 | * @return boolean |
||
| 146 | */ |
||
| 147 | 150 | public function isFontItalic() |
|
| 151 | |||
| 152 | /** |
||
| 153 | * @return Style |
||
| 154 | */ |
||
| 155 | 12 | public function setFontItalic() |
|
| 162 | |||
| 163 | /** |
||
| 164 | * @return boolean |
||
| 165 | */ |
||
| 166 | 150 | public function isFontUnderline() |
|
| 170 | |||
| 171 | /** |
||
| 172 | * @return Style |
||
| 173 | */ |
||
| 174 | 18 | public function setFontUnderline() |
|
| 181 | |||
| 182 | /** |
||
| 183 | * @return boolean |
||
| 184 | */ |
||
| 185 | 150 | public function isFontStrikethrough() |
|
| 189 | |||
| 190 | /** |
||
| 191 | * @return Style |
||
| 192 | */ |
||
| 193 | 12 | public function setFontStrikethrough() |
|
| 200 | |||
| 201 | /** |
||
| 202 | * @return int |
||
| 203 | */ |
||
| 204 | 207 | public function getFontSize() |
|
| 208 | |||
| 209 | /** |
||
| 210 | * @param int $fontSize Font size, in pixels |
||
| 211 | * @return Style |
||
| 212 | */ |
||
| 213 | 153 | public function setFontSize($fontSize) |
|
| 220 | |||
| 221 | /** |
||
| 222 | * @return string |
||
| 223 | */ |
||
| 224 | 207 | public function getFontColor() |
|
| 228 | |||
| 229 | /** |
||
| 230 | * Sets the font color. |
||
| 231 | * |
||
| 232 | * @param string $fontColor ARGB color (@see Color) |
||
| 233 | * @return Style |
||
| 234 | */ |
||
| 235 | 6 | public function setFontColor($fontColor) |
|
| 242 | |||
| 243 | /** |
||
| 244 | * @return string |
||
| 245 | */ |
||
| 246 | 249 | public function getFontName() |
|
| 250 | |||
| 251 | /** |
||
| 252 | * @param string $fontName Name of the font to use |
||
| 253 | * @return Style |
||
| 254 | */ |
||
| 255 | 144 | public function setFontName($fontName) |
|
| 262 | |||
| 263 | /** |
||
| 264 | * @return boolean |
||
| 265 | */ |
||
| 266 | 219 | public function shouldWrapText() |
|
| 270 | |||
| 271 | /** |
||
| 272 | * @param bool|void $shouldWrap Should the text be wrapped |
||
| 273 | * @return Style |
||
| 274 | */ |
||
| 275 | 30 | public function setShouldWrapText($shouldWrap = true) |
|
| 281 | |||
| 282 | /** |
||
| 283 | * @return bool |
||
| 284 | */ |
||
| 285 | 177 | public function hasSetWrapText() |
|
| 289 | |||
| 290 | /** |
||
| 291 | * @return bool Whether specific font properties should be applied |
||
| 292 | */ |
||
| 293 | 171 | public function shouldApplyFont() |
|
| 297 | |||
| 298 | /** |
||
| 299 | * Sets the background color |
||
| 300 | * @param string $color ARGB color (@see Color) |
||
| 301 | * @return Style |
||
| 302 | */ |
||
| 303 | 18 | public function setBackgroundColor($color) |
|
| 309 | |||
| 310 | /** |
||
| 311 | * @return string |
||
| 312 | */ |
||
| 313 | 141 | public function getBackgroundColor() |
|
| 317 | |||
| 318 | /** |
||
| 319 | * |
||
| 320 | * @return bool Whether the background color should be applied |
||
| 321 | */ |
||
| 322 | 147 | public function shouldApplyBackgroundColor() |
|
| 326 | |||
| 327 | /** |
||
| 328 | * Serializes the style for future comparison with other styles. |
||
| 329 | * The ID is excluded from the comparison, as we only care about |
||
| 330 | * actual style properties. |
||
| 331 | * |
||
| 332 | * @return string The serialized style |
||
| 333 | */ |
||
| 334 | 270 | public function serialize() |
|
| 346 | |||
| 347 | /** |
||
| 348 | * Merges the current style with the given style, using the given style as a base. This means that: |
||
| 349 | * - if current style and base style both have property A set, use current style property's value |
||
| 350 | * - if current style has property A set but base style does not, use current style property's value |
||
| 351 | * - if base style has property A set but current style does not, use base style property's value |
||
| 352 | * |
||
| 353 | * @NOTE: This function returns a new style. |
||
| 354 | * |
||
| 355 | * @param Style $baseStyle |
||
| 356 | * @return Style New style corresponding to the merge of the 2 styles |
||
| 357 | */ |
||
| 358 | 93 | public function mergeWith($baseStyle) |
|
| 395 | } |
||
| 396 |