WorksheetManager::__construct() - Code Metrics - Inspection of "StyleMerger and RowManager changes" - box/spout - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop_3.0 (#495)

by Adrien

created 2017-11-10 21:26 UTC

WorksheetManager::__construct() A

↳ Parent: WorksheetManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	10
cts	10
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	17
nc	1
nop	8
crap	1

How to fix Many Parameters

<?php

namespace Box\Spout\Writer\XLSX\Manager;

use Box\Spout\Common\Exception\InvalidArgumentException;
use Box\Spout\Common\Exception\IOException;
use Box\Spout\Common\Helper\Escaper\XLSX as XLSXEscaper;
use Box\Spout\Common\Helper\StringHelper;
use Box\Spout\Common\Manager\OptionsManagerInterface;
use Box\Spout\Writer\Common\Creator\InternalEntityFactory;
use Box\Spout\Writer\Common\Entity\Cell;
use Box\Spout\Writer\Common\Entity\Options;
use Box\Spout\Writer\Common\Entity\Row;
use Box\Spout\Writer\Common\Entity\Style\Style;
use Box\Spout\Writer\Common\Entity\Worksheet;
use Box\Spout\Writer\Common\Helper\CellHelper;
use Box\Spout\Writer\Common\Manager\RowManager;
use Box\Spout\Writer\Common\Manager\Style\StyleMerger;
use Box\Spout\Writer\Common\Manager\WorksheetManagerInterface;
use Box\Spout\Writer\XLSX\Manager\Style\StyleManager;

/**
 * Class WorksheetManager
 * XLSX worksheet manager, providing the interfaces to work with XLSX worksheets.
 */
class WorksheetManager implements WorksheetManagerInterface
{
    /**
     * Maximum number of characters a cell can contain
     * @see https://support.office.com/en-us/article/Excel-specifications-and-limits-16c69c74-3d6a-4aaf-ba35-e6eb276e8eaa [Excel 2007]
     * @see https://support.office.com/en-us/article/Excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3 [Excel 2010]
     * @see https://support.office.com/en-us/article/Excel-specifications-and-limits-ca36e2dc-1f09-4620-b726-67c00b05040f [Excel 2013/2016]
     */
    const MAX_CHARACTERS_PER_CELL = 32767;

    const SHEET_XML_FILE_HEADER = <<<'EOD'
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
EOD;

    /** @var bool Whether inline or shared strings should be used */
    protected $shouldUseInlineStrings;

    /** @var RowManager Manages rows */
    private $rowManager;

    /** @var StyleManager Manages styles */
    private $styleManager;

    /** @var StyleManager Helper to merge styles together */
    private $styleMerger;

    /** @var SharedStringsManager Helper to write shared strings */
    private $sharedStringsManager;

    /** @var XLSXEscaper Strings escaper */
    private $stringsEscaper;

    /** @var StringHelper String helper */
    private $stringHelper;

    /** @var InternalEntityFactory Factory to create entities */
    private $entityFactory;

    /**
     * WorksheetManager constructor.
     *
     * @param OptionsManagerInterface $optionsManager
     * @param RowManager $rowManager
     * @param StyleManager $styleManager
     * @param StyleMerger $styleMerger
     * @param SharedStringsManager $sharedStringsManager
     * @param XLSXEscaper $stringsEscaper
     * @param StringHelper $stringHelper
     * @param InternalEntityFactory $entityFactory
     */
    public function __construct(
        OptionsManagerInterface $optionsManager,
        RowManager $rowManager,
        StyleManager $styleManager,
        StyleMerger $styleMerger,
        SharedStringsManager $sharedStringsManager,
        XLSXEscaper $stringsEscaper,
        StringHelper $stringHelper,
        InternalEntityFactory $entityFactory
    ) {
        $this->shouldUseInlineStrings = $optionsManager->getOption(Options::SHOULD_USE_INLINE_STRINGS);
        $this->rowManager = $rowManager;
        $this->styleManager = $styleManager;
        $this->styleMerger = $styleMerger;

        $this->sharedStringsManager = $sharedStringsManager;
        $this->stringsEscaper = $stringsEscaper;
        $this->stringHelper = $stringHelper;
        $this->entityFactory = $entityFactory;
    }

    /**
     * @return SharedStringsManager
     */
    public function getSharedStringsManager()
    {
        return $this->sharedStringsManager;
    }

    /**
     * {@inheritdoc}
     */
    public function startSheet(Worksheet $worksheet)
    {
        $sheetFilePointer = fopen($worksheet->getFilePath(), 'w');
        $this->throwIfSheetFilePointerIsNotAvailable($sheetFilePointer);

        $worksheet->setFilePointer($sheetFilePointer);

        fwrite($sheetFilePointer, self::SHEET_XML_FILE_HEADER);
        fwrite($sheetFilePointer, '<sheetData>');
    }

    /**
     * Checks if the sheet has been sucessfully created. Throws an exception if not.
     *
     * @param bool|resource $sheetFilePointer Pointer to the sheet data file or FALSE if unable to open the file
     * @throws IOException If the sheet data file cannot be opened for writing
     * @return void
     */
    private function throwIfSheetFilePointerIsNotAvailable($sheetFilePointer)
    {
        if (!$sheetFilePointer) {
            throw new IOException('Unable to open sheet for writing.');
        }
    }

    /**
     * {@inheritdoc}
     */
    public function addRow(Worksheet $worksheet, Row $row)
    {
        if (!$this->rowManager->isEmpty($row)) {
            $this->addNonEmptyRow($worksheet, $row);
        }

        $worksheet->setLastWrittenRowIndex($worksheet->getLastWrittenRowIndex() + 1);
    }

    /**
     * Adds non empty row to the worksheet.
     *
     * @param Worksheet $worksheet The worksheet to add the row to
     * @param Row $row The row to be written
     * @throws IOException If the data cannot be written
     * @throws InvalidArgumentException If a cell value's type is not supported
     * @return void
     */
    private function addNonEmptyRow(Worksheet $worksheet, Row $row)
    {
        $cellIndex = 0;
        $rowStyle = $row->getStyle();
        $rowIndex = $worksheet->getLastWrittenRowIndex() + 1;
        $numCells = count($row->getCells());

        $rowXML = '<row r="' . $rowIndex . '" spans="1:' . $numCells . '">';

        foreach ($row->getCells() as $cell) {
            $rowXML .= $this->applyStyleAndGetCellXML($cell, $rowStyle, $rowIndex, $cellIndex);
            $cellIndex++;
        }

        $rowXML .= '</row>';

        $wasWriteSuccessful = fwrite($worksheet->getFilePointer(), $rowXML);
        if ($wasWriteSuccessful === false) {
            throw new IOException("Unable to write data in {$worksheet->getFilePath()}");
        }
    }

    /**
     * Applies styles to the given style, merging the cell's style with its row's style
     * Then builds and returns xml for the cell.
     *
     * @param Cell $cell
     * @param Style $rowStyle
     * @param int $rowIndex
     * @param int $cellIndex
     * @throws InvalidArgumentException If the given value cannot be processed
     * @return string
     */
    private function applyStyleAndGetCellXML(Cell $cell, Style $rowStyle, $rowIndex, $cellIndex)
    {
        // Apply row and extra styles
        $mergedCellAndRowStyle = $this->styleMerger->merge($cell->getStyle(), $rowStyle);

        $cell->setStyle($mergedCellAndRowStyle);
        $newCellStyle = $this->styleManager->applyExtraStylesIfNeeded($cell);

        $registeredStyle = $this->styleManager->registerStyle($newCellStyle);

        return $this->getCellXML($rowIndex, $cellIndex, $cell, $registeredStyle->getId());
    }

    /**
     * Builds and returns xml for a single cell.
     *
     * @param int $rowIndex
     * @param int $cellNumber
     * @param Cell $cell
     * @param int $styleId
     * @throws InvalidArgumentException If the given value cannot be processed
     * @return string
     */
    private function getCellXML($rowIndex, $cellNumber, Cell $cell, $styleId)
    {
        $columnIndex = CellHelper::getCellIndexFromColumnIndex($cellNumber);
        $cellXML = '<c r="' . $columnIndex . $rowIndex . '"';
        $cellXML .= ' s="' . $styleId . '"';

        if ($cell->isString()) {
            $cellXML .= $this->getCellXMLFragmentForNonEmptyString($cell->getValue());
        } elseif ($cell->isBoolean()) {
            $cellXML .= ' t="b"><v>' . (int) ($cell->getValue()) . '</v></c>';
        } elseif ($cell->isNumeric()) {
            $cellXML .= '><v>' . $cell->getValue() . '</v></c>';
        } elseif ($cell->isEmpty()) {
            if ($this->styleManager->shouldApplyStyleOnEmptyCell($styleId)) {
                $cellXML .= '/>';
            } else {
                // don't write empty cells that do no need styling
                // NOTE: not appending to $cellXML is the right behavior!!
                $cellXML = '';
            }
        } else {
            throw new InvalidArgumentException('Trying to add a value with an unsupported type: ' . gettype($cell->getValue()));
        }

        return $cellXML;
    }

    /**
     * Returns the XML fragment for a cell containing a non empty string
     *
     * @param string $cellValue The cell value
     * @throws InvalidArgumentException If the string exceeds the maximum number of characters allowed per cell
     * @return string The XML fragment representing the cell
     */
    private function getCellXMLFragmentForNonEmptyString($cellValue)
    {
        if ($this->stringHelper->getStringLength($cellValue) > self::MAX_CHARACTERS_PER_CELL) {
            throw new InvalidArgumentException('Trying to add a value that exceeds the maximum number of characters allowed in a cell (32,767)');
        }

        if ($this->shouldUseInlineStrings) {
            $cellXMLFragment = ' t="inlineStr"><is><t>' . $this->stringsEscaper->escape($cellValue) . '</t></is></c>';
        } else {
            $sharedStringId = $this->sharedStringsManager->writeString($cellValue);
            $cellXMLFragment = ' t="s"><v>' . $sharedStringId . '</v></c>';
        }

        return $cellXMLFragment;
    }

    /**
     * {@inheritdoc}
     */
    public function close(Worksheet $worksheet)
    {
        $worksheetFilePointer = $worksheet->getFilePointer();

        if (!is_resource($worksheetFilePointer)) {
            return;
        }

        fwrite($worksheetFilePointer, '</sheetData>');
        fwrite($worksheetFilePointer, '</worksheet>');
        fclose($worksheetFilePointer);
    }
}


1		<?php
2
3		namespace Box\Spout\Writer\XLSX\Manager;
4
5		use Box\Spout\Common\Exception\InvalidArgumentException;
6		use Box\Spout\Common\Exception\IOException;
7		use Box\Spout\Common\Helper\Escaper\XLSX as XLSXEscaper;
8		use Box\Spout\Common\Helper\StringHelper;
9		use Box\Spout\Common\Manager\OptionsManagerInterface;
10		use Box\Spout\Writer\Common\Creator\InternalEntityFactory;
11		use Box\Spout\Writer\Common\Entity\Cell;
12		use Box\Spout\Writer\Common\Entity\Options;
13		use Box\Spout\Writer\Common\Entity\Row;
14		use Box\Spout\Writer\Common\Entity\Style\Style;
15		use Box\Spout\Writer\Common\Entity\Worksheet;
16		use Box\Spout\Writer\Common\Helper\CellHelper;
17		use Box\Spout\Writer\Common\Manager\RowManager;
18		use Box\Spout\Writer\Common\Manager\Style\StyleMerger;
19		use Box\Spout\Writer\Common\Manager\WorksheetManagerInterface;
20		use Box\Spout\Writer\XLSX\Manager\Style\StyleManager;
21
22		/**
23		* Class WorksheetManager
24		* XLSX worksheet manager, providing the interfaces to work with XLSX worksheets.
25		*/
26		class WorksheetManager implements WorksheetManagerInterface
27		{
28		/**
29		* Maximum number of characters a cell can contain
30		* @see https://support.office.com/en-us/article/Excel-specifications-and-limits-16c69c74-3d6a-4aaf-ba35-e6eb276e8eaa [Excel 2007]
31		* @see https://support.office.com/en-us/article/Excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3 [Excel 2010]
32		* @see https://support.office.com/en-us/article/Excel-specifications-and-limits-ca36e2dc-1f09-4620-b726-67c00b05040f [Excel 2013/2016]
33		*/
34		const MAX_CHARACTERS_PER_CELL = 32767;
35
36		const SHEET_XML_FILE_HEADER = <<<'EOD'
37		<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
38		<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
39		EOD;
40
41		/** @var bool Whether inline or shared strings should be used */
42		protected $shouldUseInlineStrings;
43
44		/** @var RowManager Manages rows */
45		private $rowManager;
46
47		/** @var StyleManager Manages styles */
48		private $styleManager;
49
50		/** @var StyleManager Helper to merge styles together */
51		private $styleMerger;
52
53		/** @var SharedStringsManager Helper to write shared strings */
54		private $sharedStringsManager;
55
56		/** @var XLSXEscaper Strings escaper */
57		private $stringsEscaper;
58
59		/** @var StringHelper String helper */
60		private $stringHelper;
61
62		/** @var InternalEntityFactory Factory to create entities */
63		private $entityFactory;
64
65		/**
66		* WorksheetManager constructor.
67		*
68		* @param OptionsManagerInterface $optionsManager
69		* @param RowManager $rowManager
70		* @param StyleManager $styleManager
71		* @param StyleMerger $styleMerger
72		* @param SharedStringsManager $sharedStringsManager
73		* @param XLSXEscaper $stringsEscaper
74		* @param StringHelper $stringHelper
75		* @param InternalEntityFactory $entityFactory
76		*/
77	39	public function __construct(
78		OptionsManagerInterface $optionsManager,
79		RowManager $rowManager,
80		StyleManager $styleManager,
81		StyleMerger $styleMerger,
82		SharedStringsManager $sharedStringsManager,
83		XLSXEscaper $stringsEscaper,
84		StringHelper $stringHelper,
85		InternalEntityFactory $entityFactory
86		) {
87	39	$this->shouldUseInlineStrings = $optionsManager->getOption(Options::SHOULD_USE_INLINE_STRINGS);
88	39	$this->rowManager = $rowManager;
89	39	$this->styleManager = $styleManager;
90	39	$this->styleMerger = $styleMerger;
		0 ignored issues – show Documentation Bug introduced 2017-11-10 21:27 UTC by Report Bug Copy Issue Report It seems like `$styleMerger` of type `object<Box\Spout\Writer\...ager\Style\StyleMerger>` is incompatible with the declared type `object<Box\Spout\Writer\...ger\Style\StyleManager>` of property `$styleMerger`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
91	39	$this->sharedStringsManager = $sharedStringsManager;
92	39	$this->stringsEscaper = $stringsEscaper;
93	39	$this->stringHelper = $stringHelper;
94	39	$this->entityFactory = $entityFactory;
95	39	}
96
97		/**
98		* @return SharedStringsManager
99		*/
100	35	public function getSharedStringsManager()
101		{
102	35	return $this->sharedStringsManager;
103		}
104
105		/**
106		* {@inheritdoc}
107		*/
108	39	public function startSheet(Worksheet $worksheet)
109		{
110	39	$sheetFilePointer = fopen($worksheet->getFilePath(), 'w');
111	39	$this->throwIfSheetFilePointerIsNotAvailable($sheetFilePointer);
112
113	39	$worksheet->setFilePointer($sheetFilePointer);
114
115	39	fwrite($sheetFilePointer, self::SHEET_XML_FILE_HEADER);
116	39	fwrite($sheetFilePointer, '<sheetData>');
117	39	}
118
119		/**
120		* Checks if the sheet has been sucessfully created. Throws an exception if not.
121		*
122		* @param bool\|resource $sheetFilePointer Pointer to the sheet data file or FALSE if unable to open the file
123		* @throws IOException If the sheet data file cannot be opened for writing
124		* @return void
125		*/
126	39	private function throwIfSheetFilePointerIsNotAvailable($sheetFilePointer)
127		{
128	39	if (!$sheetFilePointer) {
129		throw new IOException('Unable to open sheet for writing.');
130		}
131	39	}
132
133		/**
134		* {@inheritdoc}
135		*/
136	31	public function addRow(Worksheet $worksheet, Row $row)
137		{
138	31	if (!$this->rowManager->isEmpty($row)) {
139	31	$this->addNonEmptyRow($worksheet, $row);
140		}
141
142	30	$worksheet->setLastWrittenRowIndex($worksheet->getLastWrittenRowIndex() + 1);
143	30	}
144
145		/**
146		* Adds non empty row to the worksheet.
147		*
148		* @param Worksheet $worksheet The worksheet to add the row to
149		* @param Row $row The row to be written
150		* @throws IOException If the data cannot be written
151		* @throws InvalidArgumentException If a cell value's type is not supported
152		* @return void
153		*/
154	31	private function addNonEmptyRow(Worksheet $worksheet, Row $row)
155		{
156	31	$cellIndex = 0;
157	31	$rowStyle = $row->getStyle();
158	31	$rowIndex = $worksheet->getLastWrittenRowIndex() + 1;
159	31	$numCells = count($row->getCells());
160
161	31	$rowXML = '<row r="' . $rowIndex . '" spans="1:' . $numCells . '">';
162
163	31	foreach ($row->getCells() as $cell) {
164	31	$rowXML .= $this->applyStyleAndGetCellXML($cell, $rowStyle, $rowIndex, $cellIndex);
165	30	$cellIndex++;
166		}
167
168	30	$rowXML .= '</row>';
169
170	30	$wasWriteSuccessful = fwrite($worksheet->getFilePointer(), $rowXML);
171	30	if ($wasWriteSuccessful === false) {
172		throw new IOException("Unable to write data in {$worksheet->getFilePath()}");
173		}
174	30	}
175
176		/**
177		* Applies styles to the given style, merging the cell's style with its row's style
178		* Then builds and returns xml for the cell.
179		*
180		* @param Cell $cell
181		* @param Style $rowStyle
182		* @param int $rowIndex
183		* @param int $cellIndex
184		* @throws InvalidArgumentException If the given value cannot be processed
185		* @return string
186		*/
187	31	private function applyStyleAndGetCellXML(Cell $cell, Style $rowStyle, $rowIndex, $cellIndex)
188		{
189		// Apply row and extra styles
190	31	$mergedCellAndRowStyle = $this->styleMerger->merge($cell->getStyle(), $rowStyle);
		0 ignored issues – show Bug introduced 2017-11-10 21:27 UTC by Report Bug Copy Issue Report The method `merge()` does not seem to exist on `object<Box\Spout\Writer\...ger\Style\StyleManager>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
191	31	$cell->setStyle($mergedCellAndRowStyle);
192	31	$newCellStyle = $this->styleManager->applyExtraStylesIfNeeded($cell);
193
194	31	$registeredStyle = $this->styleManager->registerStyle($newCellStyle);
195
196	31	return $this->getCellXML($rowIndex, $cellIndex, $cell, $registeredStyle->getId());
197		}
198
199		/**
200		* Builds and returns xml for a single cell.
201		*
202		* @param int $rowIndex
203		* @param int $cellNumber
204		* @param Cell $cell
205		* @param int $styleId
206		* @throws InvalidArgumentException If the given value cannot be processed
207		* @return string
208		*/
209	31	private function getCellXML($rowIndex, $cellNumber, Cell $cell, $styleId)
210		{
211	31	$columnIndex = CellHelper::getCellIndexFromColumnIndex($cellNumber);
212	31	$cellXML = '<c r="' . $columnIndex . $rowIndex . '"';
213	31	$cellXML .= ' s="' . $styleId . '"';
214
215	31	if ($cell->isString()) {
216	30	$cellXML .= $this->getCellXMLFragmentForNonEmptyString($cell->getValue());
217	4	} elseif ($cell->isBoolean()) {
218	1	$cellXML .= ' t="b"><v>' . (int) ($cell->getValue()) . '</v></c>';
219	4	} elseif ($cell->isNumeric()) {
220	1	$cellXML .= '><v>' . $cell->getValue() . '</v></c>';
221	4	} elseif ($cell->isEmpty()) {
222	2	if ($this->styleManager->shouldApplyStyleOnEmptyCell($styleId)) {
223	1	$cellXML .= '/>';
224		} else {
225		// don't write empty cells that do no need styling
226		// NOTE: not appending to $cellXML is the right behavior!!
227	2	$cellXML = '';
228		}
229		} else {
230	2	throw new InvalidArgumentException('Trying to add a value with an unsupported type: ' . gettype($cell->getValue()));
231		}
232
233	30	return $cellXML;
234		}
235
236		/**
237		* Returns the XML fragment for a cell containing a non empty string
238		*
239		* @param string $cellValue The cell value
240		* @throws InvalidArgumentException If the string exceeds the maximum number of characters allowed per cell
241		* @return string The XML fragment representing the cell
242		*/
243	30	private function getCellXMLFragmentForNonEmptyString($cellValue)
244		{
245	30	if ($this->stringHelper->getStringLength($cellValue) > self::MAX_CHARACTERS_PER_CELL) {
246		throw new InvalidArgumentException('Trying to add a value that exceeds the maximum number of characters allowed in a cell (32,767)');
247		}
248
249	30	if ($this->shouldUseInlineStrings) {
250	27	$cellXMLFragment = ' t="inlineStr"><is><t>' . $this->stringsEscaper->escape($cellValue) . '</t></is></c>';
251		} else {
252	3	$sharedStringId = $this->sharedStringsManager->writeString($cellValue);
253	3	$cellXMLFragment = ' t="s"><v>' . $sharedStringId . '</v></c>';
254		}
255
256	30	return $cellXMLFragment;
257		}
258
259		/**
260		* {@inheritdoc}
261		*/
262	35	public function close(Worksheet $worksheet)
263		{
264	35	$worksheetFilePointer = $worksheet->getFilePointer();
265
266	35	if (!is_resource($worksheetFilePointer)) {
267		return;
268		}
269
270	35	fwrite($worksheetFilePointer, '</sheetData>');
271	35	fwrite($worksheetFilePointer, '</worksheet>');
272	35	fclose($worksheetFilePointer);
273	35	}
274		}
275

box / spout

Pull Request — develop_3.0 (#495)

WorksheetManager::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like