Assets - Code Metrics - Inspection of "Refactor code" - botble/laravel-assets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50def4...4d092b )

by Sang

created 2018-10-25 11:04 UTC

Assets F

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	362
Duplicated Lines	12.98 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	60
lcom	1
cbo	1
dl	47
loc	362
rs	3.6
c	0
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	addJavascript()	0	8	2
A	addStylesheets()	0	8	2
A	addStylesheetsDirectly()	13	13	4
A	addJavascriptDirectly()	14	14	4
A	removeStylesheets()	10	10	3
A	removeJavascript()	10	10	3
D	getJavascript()	0	58	17
B	getStylesheets()	0	39	10
A	javascriptToHtml()	0	4	1
A	stylesheetToHtml()	0	4	1
B	itemToHtml()	0	32	9
A	renderHeader()	0	6	1
A	renderFooter()	0	5	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Assets often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Assets, and based on these observations, apply Extract Interface, too.

<?php

namespace Botble\Assets;

use Collective\Html\HtmlBuilder;
use Illuminate\Config\Repository;

/**
 * Class Assets
 * @package Botble\Assets
 * @author Sang Nguyen
 * @since 22/07/2015 11:23 PM
 */
class Assets
{
    /**
     * @var Repository
     */
    protected $config;

    /**
     * @var HtmlBuilder
     */
    protected $htmlBuilder;

    /**
     * @var array
     */
    protected $javascript = [];

    /**
     * @var array
     */
    protected $stylesheets = [];

    /**
     * @var string
     */
    protected $build = '';

    /**
     * @var array
     */
    protected $appendedJs = [
        'top'    => [],
        'bottom' => [],
    ];

    /**
     * @var array
     */
    protected $appendedCss = [];

    /**
     * Assets constructor.
     * @author Sang Nguyen
     * @param Repository $config
     * @param HtmlBuilder $htmlBuilder
     */
    public function __construct(Repository $config, HtmlBuilder $htmlBuilder)
    {
        $this->config = $config;
        $this->htmlBuilder = $htmlBuilder;

        $this->javascript = $this->config->get('assets.javascript');

        $this->stylesheets = $this->config->get('assets.stylesheets');


        $this->build = $this->config->get('assets.enable_version') ? '?v=' . $this->config->get('assets.version') : '';
    }

    /**
     * Add Javascript to current module
     *
     * @param array $assets
     * @return $this
     * @author Sang Nguyen
     */
    public function addJavascript($assets)
    {
        if (!is_array($assets)) {
            $assets = [$assets];
        }
        $this->javascript = array_merge($this->javascript, $assets);
        return $this;
    }

    /**
     * Add Css to current module
     *
     * @param array $assets
     * @return $this
     * @author Sang Nguyen
     */
    public function addStylesheets($assets)
    {
        if (!is_array($assets)) {
            $assets = [$assets];
        }
        $this->stylesheets = array_merge($this->stylesheets, $assets);
        return $this;
    }

    /**
     * @param $assets
     * @return $this
     * @author Sang Nguyen
     */
    public function addStylesheetsDirectly($assets)

    {
        if (!is_array($assets)) {
            $assets = func_get_args();
        }
        foreach ($assets as &$item) {
            $item = $item . $this->build;
            if (!in_array($item, $this->appendedCss)) {
                $this->appendedCss[] = ['src' => $item, 'attributes' => []];
            }
        }
        return $this;
    }

    /**
     * @param $assets
     * @param string $location
     * @return $this
     * @author Sang Nguyen
     */
    public function addJavascriptDirectly($assets, $location = 'bottom')

    {
        if (!is_array($assets)) {
            $assets = func_get_args();
        }

        foreach ($assets as &$item) {
            $item = $item . $this->build;
            if (!in_array($item, $this->appendedJs[$location])) {
                $this->appendedJs[$location][] = ['src' => $item, 'attributes' => []];
            }
        }
        return $this;
    }

    /**
     * Remove Css to current module
     *
     * @param array $assets
     * @return $this
     * @author Sang Nguyen
     */
    public function removeStylesheets($assets)

    {
        if (!is_array($assets)) {
            $assets = [$assets];
        }
        foreach ($assets as $rem) {
            unset($this->stylesheets[array_search($rem, $this->stylesheets)]);
        }
        return $this;
    }

    /**
     * Add Javascript to current module
     *
     * @param array $assets
     * @return $this
     * @author Sang Nguyen
     */
    public function removeJavascript($assets)

    {
        if (!is_array($assets)) {
            $assets = [$assets];
        }
        foreach ($assets as $rem) {
            unset($this->javascript[array_search($rem, $this->javascript)]);
        }
        return $this;
    }

    /**
     * Get All Javascript in current module
     *
     * @param string $location : top or bottom
     * @param boolean $version : show version?
     * @return array
     * @author Sang Nguyen
     */
    public function getJavascript($location = null, $version = true)
    {
        $scripts = [];
        // get the final scripts need for page
        $this->javascript = array_unique($this->javascript);
        foreach ($this->javascript as $js) {
            $jsConfig = 'assets.resources.javascript.' . $js;

            if ($this->config->has($jsConfig)) {
                if (!empty($location) && $location != $this->config->get($jsConfig . '.location')) {
                    // Skip assets that don't match this location
                    continue;
                }

                $src = $this->config->get($jsConfig . '.src.local');
                $cdn = false;
                if ($this->config->get($jsConfig . '.use_cdn') && !$this->config->get('assets.offline')) {
                    $src = $this->config->get($jsConfig . '.src.cdn');
                    $cdn = true;
                }

                if ($this->config->get($jsConfig . '.include_style')) {
                    $this->addStylesheets([$js]);
                }

                $attributes = $this->config->get($jsConfig . '.attributes', []);
                if ($cdn === false) {
                    array_forget($attributes, 'integrity');
                    array_forget($attributes, 'crossorigin');
                }

                $version = $version ? $this->build : '';
                if (!is_array($src)) {
                    $scripts[] = ['src' => $src . $version, 'attributes' => $attributes];
                } else {
                    foreach ($src as $s) {
                        $scripts[] = ['src' => $s . $version, 'attributes' => $attributes];
                    }
                }

                if (empty($src) && $cdn && $location === 'top' && $this->config->has($jsConfig . '.fallback')) {
                    // Fallback to local script if CDN fails
                    $fallback = $this->config->get($jsConfig . '.fallback');
                    $scripts[] = [
                        'src'         => $src,
                        'fallback'    => $fallback,
                        'fallbackURL' => $this->config->get($jsConfig . '.src.local'),
                    ];
                }
            }
        }

        if (isset($this->appendedJs[$location])) {
            $scripts = array_merge($scripts, $this->appendedJs[$location]);
        }

        return $scripts;
    }

    /**
     * Get All CSS in current module
     *
     * @param array $lastModules : append last CSS to current module
     * @param boolean $version : show version?
     * @return array
     * @author Sang Nguyen
     */
    public function getStylesheets($lastModules = [], $version = true)
    {
        $stylesheets = [];
        if (!empty($lastModules)) {
            $this->stylesheets = array_merge($this->stylesheets, $lastModules);
        }
        // get the final scripts need for page
        $this->stylesheets = array_unique($this->stylesheets);
        foreach ($this->stylesheets as $style) {
            if ($this->config->has('assets.resources.stylesheets.' . $style)) {
                $src = $this->config->get('assets.resources.stylesheets.' . $style . '.src.local');
                $cdn = false;
                if ($this->config->get('assets.resources.stylesheets.' . $style . '.use_cdn') && !$this->config->get('assets.offline')) {
                    $src = $this->config->get('assets.resources.stylesheets.' . $style . '.src.cdn');
                    $cdn = true;
                }

                $attributes = $this->config->get('assets.resources.stylesheets.' . $style . '.attributes', []);
                if ($cdn === false) {
                    array_forget($attributes, 'integrity');
                    array_forget($attributes, 'crossorigin');
                }

                if (!is_array($src)) {
                    $src = [$src];
                }
                foreach ($src as $s) {
                    $stylesheets[] = [
                        'src'        => $s . ($version ? $this->build : ''),
                        'attributes' => $attributes,
                    ];
                }
            }
        }

        $stylesheets = array_merge($stylesheets, $this->appendedCss);

        return $stylesheets;
    }

    /**
     * @param $name
     * @param bool $version
     * @author Sang Nguyen
     */
    public function javascriptToHtml($name, $version = true)
    {
        return $this->itemToHtml($name, $version, 'script');
    }

    /**
     * @param $name
     * @param bool $version
     * @author Sang Nguyen
     */
    public function stylesheetToHtml($name, $version = true)
    {
        return $this->itemToHtml($name, $version, 'style');
    }

    /**
     * @param $name
     * @param bool $version
     * @param string $type
     * @return null|string
     */
    protected function itemToHtml($name, $version = true, $type = 'style')
    {
        if (!in_array($type, ['style', 'script'])) {
            return null;
        }

        $config = 'assets.resources.stylesheets.' . $name;
        if ($type === 'script') {
            $config = 'assets.resources.javascript.' . $name;
        }

        if ($this->config->has($config)) {

            $src = $this->config->get($config . '.src.local');
            if ($this->config->get($config . '.use_cdn') && !$this->config->get('assets.offline')) {
                $src = $this->config->get($config . '.src.cdn');
            }

            if (!is_array($src)) {
                $src = [$src];
            }

            $html = '';
            foreach ($src as $item) {
                $html .= $this->htmlBuilder->{$type}($item . ($version ? $this->build : ''), ['class' => 'hidden'])->toHtml();
            }

            return $html;
        }

        return null;
    }

    /**
     * @return string
     * @throws \Throwable
     * @author Sang Nguyen
     */
    public function renderHeader()
    {
        $stylesheets = $this->getStylesheets(['core']);
        $headScripts = $this->getJavascript('top');
        return view('assets::header', compact('stylesheets', 'headScripts'))->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @return string
     * @throws \Throwable
     * @author Sang Nguyen
     */
    public function renderFooter()
    {
        $bodyScripts = $this->getJavascript('bottom');
        return view('assets::footer', compact('bodyScripts'))->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Push — master ( 50def4...4d092b )

Assets F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

1		<?php
2
3		namespace Botble\Assets;
4
5		use Collective\Html\HtmlBuilder;
6		use Illuminate\Config\Repository;
7
8		/**
9		* Class Assets
10		* @package Botble\Assets
11		* @author Sang Nguyen
12		* @since 22/07/2015 11:23 PM
13		*/
14		class Assets
15		{
16		/**
17		* @var Repository
18		*/
19		protected $config;
20
21		/**
22		* @var HtmlBuilder
23		*/
24		protected $htmlBuilder;
25
26		/**
27		* @var array
28		*/
29		protected $javascript = [];
30
31		/**
32		* @var array
33		*/
34		protected $stylesheets = [];
35
36		/**
37		* @var string
38		*/
39		protected $build = '';
40
41		/**
42		* @var array
43		*/
44		protected $appendedJs = [
45		'top' => [],
46		'bottom' => [],
47		];
48
49		/**
50		* @var array
51		*/
52		protected $appendedCss = [];
53
54		/**
55		* Assets constructor.
56		* @author Sang Nguyen
57		* @param Repository $config
58		* @param HtmlBuilder $htmlBuilder
59		*/
60		public function __construct(Repository $config, HtmlBuilder $htmlBuilder)
61		{
62		$this->config = $config;
63		$this->htmlBuilder = $htmlBuilder;
64
65		$this->javascript = $this->config->get('assets.javascript');
		0 ignored issues – show Documentation Bug introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report It seems like `$this->config->get('assets.javascript')` of type `*` is incompatible with the declared type `array` of property `$javascript`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
66		$this->stylesheets = $this->config->get('assets.stylesheets');
		0 ignored issues – show Documentation Bug introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report It seems like `$this->config->get('assets.stylesheets')` of type `*` is incompatible with the declared type `array` of property `$stylesheets`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
67
68		$this->build = $this->config->get('assets.enable_version') ? '?v=' . $this->config->get('assets.version') : '';
69		}
70
71		/**
72		* Add Javascript to current module
73		*
74		* @param array $assets
75		* @return $this
76		* @author Sang Nguyen
77		*/
78		public function addJavascript($assets)
79		{
80		if (!is_array($assets)) {
81		$assets = [$assets];
82		}
83		$this->javascript = array_merge($this->javascript, $assets);
84		return $this;
85		}
86
87		/**
88		* Add Css to current module
89		*
90		* @param array $assets
91		* @return $this
92		* @author Sang Nguyen
93		*/
94		public function addStylesheets($assets)
95		{
96		if (!is_array($assets)) {
97		$assets = [$assets];
98		}
99		$this->stylesheets = array_merge($this->stylesheets, $assets);
100		return $this;
101		}
102
103		/**
104		* @param $assets
105		* @return $this
106		* @author Sang Nguyen
107		*/
108	View Code Duplication	public function addStylesheetsDirectly($assets)
		0 ignored issues – show Duplication introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		if (!is_array($assets)) {
111		$assets = func_get_args();
112		}
113		foreach ($assets as &$item) {
114		$item = $item . $this->build;
115		if (!in_array($item, $this->appendedCss)) {
116		$this->appendedCss[] = ['src' => $item, 'attributes' => []];
117		}
118		}
119		return $this;
120		}
121
122		/**
123		* @param $assets
124		* @param string $location
125		* @return $this
126		* @author Sang Nguyen
127		*/
128	View Code Duplication	public function addJavascriptDirectly($assets, $location = 'bottom')
		0 ignored issues – show Duplication introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		{
130		if (!is_array($assets)) {
131		$assets = func_get_args();
132		}
133
134		foreach ($assets as &$item) {
135		$item = $item . $this->build;
136		if (!in_array($item, $this->appendedJs[$location])) {
137		$this->appendedJs[$location][] = ['src' => $item, 'attributes' => []];
138		}
139		}
140		return $this;
141		}
142
143		/**
144		* Remove Css to current module
145		*
146		* @param array $assets
147		* @return $this
148		* @author Sang Nguyen
149		*/
150	View Code Duplication	public function removeStylesheets($assets)
		0 ignored issues – show Duplication introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		if (!is_array($assets)) {
153		$assets = [$assets];
154		}
155		foreach ($assets as $rem) {
156		unset($this->stylesheets[array_search($rem, $this->stylesheets)]);
157		}
158		return $this;
159		}
160
161		/**
162		* Add Javascript to current module
163		*
164		* @param array $assets
165		* @return $this
166		* @author Sang Nguyen
167		*/
168	View Code Duplication	public function removeJavascript($assets)
		0 ignored issues – show Duplication introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
169		{
170		if (!is_array($assets)) {
171		$assets = [$assets];
172		}
173		foreach ($assets as $rem) {
174		unset($this->javascript[array_search($rem, $this->javascript)]);
175		}
176		return $this;
177		}
178
179		/**
180		* Get All Javascript in current module
181		*
182		* @param string $location : top or bottom
183		* @param boolean $version : show version?
184		* @return array
185		* @author Sang Nguyen
186		*/
187		public function getJavascript($location = null, $version = true)
188		{
189		$scripts = [];
190		// get the final scripts need for page
191		$this->javascript = array_unique($this->javascript);
192		foreach ($this->javascript as $js) {
193		$jsConfig = 'assets.resources.javascript.' . $js;
194
195		if ($this->config->has($jsConfig)) {
196		if (!empty($location) && $location != $this->config->get($jsConfig . '.location')) {
197		// Skip assets that don't match this location
198		continue;
199		}
200
201		$src = $this->config->get($jsConfig . '.src.local');
202		$cdn = false;
203		if ($this->config->get($jsConfig . '.use_cdn') && !$this->config->get('assets.offline')) {
204		$src = $this->config->get($jsConfig . '.src.cdn');
205		$cdn = true;
206		}
207
208		if ($this->config->get($jsConfig . '.include_style')) {
209		$this->addStylesheets([$js]);
210		}
211
212		$attributes = $this->config->get($jsConfig . '.attributes', []);
213		if ($cdn === false) {
214		array_forget($attributes, 'integrity');
215		array_forget($attributes, 'crossorigin');
216		}
217
218		$version = $version ? $this->build : '';
219		if (!is_array($src)) {
220		$scripts[] = ['src' => $src . $version, 'attributes' => $attributes];
221		} else {
222		foreach ($src as $s) {
223		$scripts[] = ['src' => $s . $version, 'attributes' => $attributes];
224		}
225		}
226
227		if (empty($src) && $cdn && $location === 'top' && $this->config->has($jsConfig . '.fallback')) {
228		// Fallback to local script if CDN fails
229		$fallback = $this->config->get($jsConfig . '.fallback');
230		$scripts[] = [
231		'src' => $src,
232		'fallback' => $fallback,
233		'fallbackURL' => $this->config->get($jsConfig . '.src.local'),
234		];
235		}
236		}
237		}
238
239		if (isset($this->appendedJs[$location])) {
240		$scripts = array_merge($scripts, $this->appendedJs[$location]);
241		}
242
243		return $scripts;
244		}
245
246		/**
247		* Get All CSS in current module
248		*
249		* @param array $lastModules : append last CSS to current module
250		* @param boolean $version : show version?
251		* @return array
252		* @author Sang Nguyen
253		*/
254		public function getStylesheets($lastModules = [], $version = true)
255		{
256		$stylesheets = [];
257		if (!empty($lastModules)) {
258		$this->stylesheets = array_merge($this->stylesheets, $lastModules);
259		}
260		// get the final scripts need for page
261		$this->stylesheets = array_unique($this->stylesheets);
262		foreach ($this->stylesheets as $style) {
263		if ($this->config->has('assets.resources.stylesheets.' . $style)) {
264		$src = $this->config->get('assets.resources.stylesheets.' . $style . '.src.local');
265		$cdn = false;
266		if ($this->config->get('assets.resources.stylesheets.' . $style . '.use_cdn') && !$this->config->get('assets.offline')) {
267		$src = $this->config->get('assets.resources.stylesheets.' . $style . '.src.cdn');
268		$cdn = true;
269		}
270
271		$attributes = $this->config->get('assets.resources.stylesheets.' . $style . '.attributes', []);
272		if ($cdn === false) {
273		array_forget($attributes, 'integrity');
274		array_forget($attributes, 'crossorigin');
275		}
276
277		if (!is_array($src)) {
278		$src = [$src];
279		}
280		foreach ($src as $s) {
281		$stylesheets[] = [
282		'src' => $s . ($version ? $this->build : ''),
283		'attributes' => $attributes,
284		];
285		}
286		}
287		}
288
289		$stylesheets = array_merge($stylesheets, $this->appendedCss);
290
291		return $stylesheets;
292		}
293
294		/**
295		* @param $name
296		* @param bool $version
297		* @author Sang Nguyen
298		*/
299		public function javascriptToHtml($name, $version = true)
300		{
301		return $this->itemToHtml($name, $version, 'script');
302		}
303
304		/**
305		* @param $name
306		* @param bool $version
307		* @author Sang Nguyen
308		*/
309		public function stylesheetToHtml($name, $version = true)
310		{
311		return $this->itemToHtml($name, $version, 'style');
312		}
313
314		/**
315		* @param $name
316		* @param bool $version
317		* @param string $type
318		* @return null\|string
319		*/
320		protected function itemToHtml($name, $version = true, $type = 'style')
321		{
322		if (!in_array($type, ['style', 'script'])) {
323		return null;
324		}
325
326		$config = 'assets.resources.stylesheets.' . $name;
327		if ($type === 'script') {
328		$config = 'assets.resources.javascript.' . $name;
329		}
330
331		if ($this->config->has($config)) {
332
333		$src = $this->config->get($config . '.src.local');
334		if ($this->config->get($config . '.use_cdn') && !$this->config->get('assets.offline')) {
335		$src = $this->config->get($config . '.src.cdn');
336		}
337
338		if (!is_array($src)) {
339		$src = [$src];
340		}
341
342		$html = '';
343		foreach ($src as $item) {
344		$html .= $this->htmlBuilder->{$type}($item . ($version ? $this->build : ''), ['class' => 'hidden'])->toHtml();
345		}
346
347		return $html;
348		}
349
350		return null;
351		}
352
353		/**
354		* @return string
355		* @throws \Throwable
356		* @author Sang Nguyen
357		*/
358		public function renderHeader()
359		{
360		$stylesheets = $this->getStylesheets(['core']);
361		$headScripts = $this->getJavascript('top');
362		return view('assets::header', compact('stylesheets', 'headScripts'))->render();
		0 ignored issues – show Bug introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
363		}
364
365		/**
366		* @return string
367		* @throws \Throwable
368		* @author Sang Nguyen
369		*/
370		public function renderFooter()
371		{
372		$bodyScripts = $this->getJavascript('bottom');
373		return view('assets::footer', compact('bodyScripts'))->render();
		0 ignored issues – show Bug introduced 2018-10-25 10:45 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
374		}
375		}
376

botble / laravel-assets

Push — master ( 50def4...4d092b )

Assets F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like