test_phi.test_phi_creation() - Code Metrics - Inspection of "refactor(test_phi): split into 1 'test case' for a..." - boromir674/so-magic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — mpeta ( 55bdfc...e243a9 )

by Konstantinos

created 2021-06-19 15:06 UTC

test_phi.test_phi_creation() B

↳ Parent: test_phi

Complexity

Conditions

Size

Total Lines	77
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	49
nop	4
dl	0
loc	77
rs	8.669
c	0
b	0
f	0

How to fix Long Method

import pytest


@pytest.fixture
def registering_phi_at_the_same_key_error():
    from so_magic.utils.registry import ObjectRegistryError
    return ObjectRegistryError


@pytest.fixture
def app_phi_function(somagic):
    return somagic._data_manager.phi_class


@pytest.fixture
def assert_function_properties_values():
    def _f(func, expected_name: str, expected_doc: str):
        assert func.__name__ == expected_name
        assert func.__doc__ == expected_doc
    return _f


@pytest.fixture
def phi_registry():
    from so_magic.data.features.phi import phi_registry
    return phi_registry


def test_initial_phi_registry(phi_registry):
    assert phi_registry.objects == {}
    assert 'any-key' not in phi_registry


def test_phi_creation(app_phi_function, phi_registry, registering_phi_at_the_same_key_error,
                      assert_function_properties_values):

    PhiFunction = app_phi_function

    @PhiFunction.register('pame')
    def ela(x):
        """ela Docstring"""
        return x + 1

    assert 'pame' in phi_registry
    assert_function_properties_values(ela, 'ela', 'ela Docstring')

    assert phi_registry.get('pame').__name__ == 'ela'
    assert phi_registry.get('pame').__doc__ == 'ela Docstring'
    test_value = 5
    assert phi_registry.get('pame')(test_value) == test_value + 1

    @PhiFunction.register('')
    def gg(x):
        return x * 2
    assert 'gg' in phi_registry

    @PhiFunction.register()
    def dd(x):
        return x * 2
    assert 'dd' in phi_registry
    assert phi_registry.get('dd')(4) == 8

    @PhiFunction.register('edw')
    class Edw:
        def __call__(self, data, **kwargs):
            return data + 5
    assert 'edw' in phi_registry
    assert phi_registry.get('edw')(3) == 8

    @PhiFunction.register('')
    class qw:
        def __call__(self, data, **kwargs):
            """Subtract 5 from the input number.

            Args:
                data ([type]): numerical value

            Returns:
                [type]: the result of the subtraction
            """
            return data - 5
    
    assert 'qw' in phi_registry
    assert phi_registry.get('qw')(3) == -2

    assert_function_properties_values(phi_registry.get('qw'), 'qw', qw.__call__.__doc__)

    @PhiFunction.register()
    class Nai:
        def __call__(self, data, **kwargs):
            """Subtract 1 to the input number."""            
            return data - 1

    assert 'Nai' in phi_registry

    assert_function_properties_values(phi_registry.get('Nai'), 'Nai', 'Subtract 1 to the input number.')
    
    assert phi_registry.get('Nai')(3) == 2

    def gg(x):
        return x

    test_value = 1
    assert gg(test_value) == test_value
    assert phi_registry.get('gg')(test_value) == test_value * 2

    with pytest.raises(registering_phi_at_the_same_key_error):
        PhiFunction.register('')(gg)

    assert phi_registry.get('gg')(test_value) == test_value * 2


1			import pytest
2
3
4			@pytest.fixture
5			def registering_phi_at_the_same_key_error():
6			from so_magic.utils.registry import ObjectRegistryError
7			return ObjectRegistryError
8
9
10			@pytest.fixture
11			def app_phi_function(somagic):
12			return somagic._data_manager.phi_class
13
14
15			@pytest.fixture
16			def assert_function_properties_values():
17			def _f(func, expected_name: str, expected_doc: str):
18			assert func.__name__ == expected_name
19			assert func.__doc__ == expected_doc
20			return _f
21
22
23			@pytest.fixture
24			def phi_registry():
25			from so_magic.data.features.phi import phi_registry
26			return phi_registry
27
28
29			def test_initial_phi_registry(phi_registry):
30			assert phi_registry.objects == {}
31			assert 'any-key' not in phi_registry
32
33
34			def test_phi_creation(app_phi_function, phi_registry, registering_phi_at_the_same_key_error,
35			assert_function_properties_values):
36
37			PhiFunction = app_phi_function
38
39			@PhiFunction.register('pame')
40			def ela(x):
41			"""ela Docstring"""
42			return x + 1
43
44			assert 'pame' in phi_registry
45			assert_function_properties_values(ela, 'ela', 'ela Docstring')
46
47			assert phi_registry.get('pame').__name__ == 'ela'
48			assert phi_registry.get('pame').__doc__ == 'ela Docstring'
49			test_value = 5
50			assert phi_registry.get('pame')(test_value) == test_value + 1
51
52			@PhiFunction.register('')
53			def gg(x):
54			return x * 2
55			assert 'gg' in phi_registry
56
57			@PhiFunction.register()
58			def dd(x):
59			return x * 2
60			assert 'dd' in phi_registry
61			assert phi_registry.get('dd')(4) == 8
62
63			@PhiFunction.register('edw')
64			class Edw:
65			def __call__(self, data, **kwargs):
66			return data + 5
67			assert 'edw' in phi_registry
68			assert phi_registry.get('edw')(3) == 8
69
70			@PhiFunction.register('')
71			class qw:
72			def __call__(self, data, **kwargs):
73			"""Subtract 5 from the input number.
74
75			Args:
76			data ([type]): numerical value
77
78			Returns:
79			[type]: the result of the subtraction
80			"""
81			return data - 5
82
83			assert 'qw' in phi_registry
84			assert phi_registry.get('qw')(3) == -2
85
86			assert_function_properties_values(phi_registry.get('qw'), 'qw', qw.__call__.__doc__)
87
88			@PhiFunction.register()
89			class Nai:
90			def __call__(self, data, **kwargs):
91			"""Subtract 1 to the input number."""
92			return data - 1
93
94			assert 'Nai' in phi_registry
95
96			assert_function_properties_values(phi_registry.get('Nai'), 'Nai', 'Subtract 1 to the input number.')
97
98			assert phi_registry.get('Nai')(3) == 2
99
100			def gg(x):
101			return x
102
103			test_value = 1
104			assert gg(test_value) == test_value
105			assert phi_registry.get('gg')(test_value) == test_value * 2
106
107			with pytest.raises(registering_phi_at_the_same_key_error):
108			PhiFunction.register('')(gg)
109
110			assert phi_registry.get('gg')(test_value) == test_value * 2
111

boromir674 / so-magic

Push — mpeta ( 55bdfc...e243a9 )

test_phi.test_phi_creation() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like