RootPage::getHref() - Code Metrics - bookdown/Bookdown.Bookdown - Measure and Improve Code Quality continuously with Scrutinizer

RootPage::getHref() A
last analyzed 2016-03-04 17:46 UTC

↳ Parent: RootPage

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
namespace Bookdown\Bookdown\Content;

use Bookdown\Bookdown\Config\RootConfig;

class RootPage extends IndexPage
{
    public function __construct(RootConfig $config)
    {
        $this->config = $config;
        $this->setTitle($config->getTitle());
    }

    public function getHref()
    {
        return $this->config->getRootHref();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getNumber()
    {
        return '';
    }

    public function getTarget()
    {
        return $this->getConfig()->getTarget() . 'index.html';
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function isRoot()
    {
        return true;
    }
}


1		<?php
2		namespace Bookdown\Bookdown\Content;
3
4		use Bookdown\Bookdown\Config\RootConfig;
5
6		class RootPage extends IndexPage
7		{
8	22	public function __construct(RootConfig $config)
9		{
10	22	$this->config = $config;
11	22	$this->setTitle($config->getTitle());
12	22	}
13
14	17	public function getHref()
15		{
16	17	return $this->config->getRootHref();
		0 ignored issues – show Bug introduced 2016-02-18 09:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Bookdown\Bookdown\Config\IndexConfig` as the method `getRootHref()` does only exist in the following sub-classes of `Bookdown\Bookdown\Config\IndexConfig`: `Bookdown\Bookdown\Config\RootConfig`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
17		}
18
19	17	public function getNumber()
20		{
21	17	return '';
22		}
23
24	21	public function getTarget()
25		{
26	21	return $this->getConfig()->getTarget() . 'index.html';
		0 ignored issues – show Bug introduced 2016-02-18 09:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Bookdown\Bookdown\Config\IndexConfig` as the method `getTarget()` does only exist in the following sub-classes of `Bookdown\Bookdown\Config\IndexConfig`: `Bookdown\Bookdown\Config\RootConfig`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
27		}
28
29	10	public function isRoot()
30		{
31	10	return true;
32		}
33		}
34

bookdown / Bookdown.Bookdown

RootPage::getHref() A last analyzed 2016-03-04 17:46 UTC

Complexity

Size

Duplication

Code Coverage

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RootPage::getHref() A
last analyzed 2016-03-04 17:46 UTC