StartServerService::handle() - Code Metrics - bogdananton/Selenium-Setup - Measure and Improve Code Quality continuously with Scrutinizer

StartServerService::handle() C
last analyzed 2016-06-05 13:36 UTC

↳ Parent: StartServerService

Complexity

Conditions	8
Paths	36

Size

Total Lines	68
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	8
Bugs	2	Features	4

Metric	Value
c	8
b	2
f	4
dl	0
loc	68
rs	6.5974
cc	8
eloc	37
nc	36
nop	0

How to fix Long Method

<?php
namespace SeleniumSetup\Service;

use SeleniumSetup\Locker\ServerItemFactory;

class StartServerService extends AbstractService
{
    protected function createFolders()
    {
        // Create the build folder. (Where the binaries will reside).
        if (!$this->fileSystem->isDir(($this->config->getBuildPath()))) {
            $this->fileSystem->createDir($this->config->getBuildPath());
        }
        
        // Create the tmp folder.
        if (!$this->fileSystem->isDir(($this->config->getTmpPath()))) {
            $this->fileSystem->createDir($this->config->getTmpPath());
        }
        
        // Create the logs folder.
        if (!$this->fileSystem->isDir($this->config->getLogsPath())) {
            $this->fileSystem->createDir($this->config->getLogsPath());
        }
    }

    protected function downloadDrivers()
    {
        foreach ($this->config->getBinaries() as $binary) {
            // Skip binaries that don't belong to the current operating system.
            if (
                !is_null($binary->getOs()) && $binary->getOs() != $this->env->getOsName() ||
                !is_null($binary->getOsType()) && $binary->getOsType() != $this->env->getOsType()
            ) {
                continue;
            }

            $binaryPath = $this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName();

            if (!$this->fileSystem->isFile($binaryPath)) {
                $this->output->writeln(
                    sprintf('Downloading %s %s ...', $binary->getLabel(), $binary->getVersion())
                );
                
                // Download.
                $downloadTo = $this->config->getBuildPath() . DIRECTORY_SEPARATOR . pathinfo($binary->getDownloadUrl(), PATHINFO_BASENAME);
                $download = $this->env->download($binary->getDownloadUrl(), $downloadTo);
                $this->output->writeln($download);

                // Unzip.
                if (in_array(pathinfo($binary->getDownloadUrl(), PATHINFO_EXTENSION), ['zip', 'tar', 'tar.gz'])) {
                    $zip = new \ZipArchive;
                    $res = $zip->open($downloadTo);
                    if ($res === true) {
                        $zip->extractTo(
                            $this->config->getBuildPath(),
                            [$binary->getBinName()]
                        );
                        $zip->close();
                    }
                } else {
                    $this->fileSystem->rename($downloadTo, $this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName());
                }

                // Make executable.
                $this->env->makeExecutable($this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName());
            } else {
                $this->output->writeln(
                    sprintf('Skipping %s %s. Binary already exists.', $binary->getLabel(), $binary->getVersion())
                );
            }
        }
    }
    
    public function test()
    {
        return $this->env->test();
    }
    
    public function handle()
    {
        // @todo should allow only registered instances to be called

        $this->createFolders();
        $this->downloadDrivers();

        // Add build folder to path.
        $this->env->addPathToGlobalPath($this->config->getBuildPath());
        
        // Warn if Chrome or Firefox binaries are not available.
        if ($chromeVersion = $this->env->getChromeVersion()) {
            $this->output->writeln('Chrome binary found, v.' . $chromeVersion);
        } else {
            $this->output->writeln('<info>WARNING: Chrome binary not found.</info>');
        }

        if ($firefoxVersion = $this->env->getFirefoxVersion()) {
            $this->output->writeln('Firefox binary found, v.' . $firefoxVersion);
        } else {
            $this->output->writeln('<info>WARNING: Firefox binary not found.</info>');
        }
        
        // Warn if display is not available.
        if ($this->env->isLinux()) {
            if ($this->env->hasXvfb()) {
                $this->output->writeln('<info>Xvfb is installed. Good.</info>');
            } else {
                $this->output->writeln('<info>WARNING: Xvfb is not installed.</info>');
            }
        }
        
        // $pid = $this->env->startDisplayProcess();


        // Start Selenium Server instance.
        $this->output->writeln(
            sprintf('Starting Selenium Server (%s) ... %s:%s', $this->config->getName(), $this->config->getHostname(), $this->config->getPort())
        );

        $pid = $this->env->startSeleniumProcess();
        if ($pid > 0) {
            // Make sure that we capture the right PID.
            while ($this->env->listenToPort($this->config->getPort()) == '') {
                $this->output->write('<info>.</info>');
            }
            $parentPid = $this->env->getPidFromListeningToPort($this->config->getPort());
            if ($parentPid) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $pid = $parentPid;
            }

            // @todo open the lock file only to update the status and ports, the instance was already added.
            $this->locker->openLockFile();
            $this->locker->addServer(
                ServerItemFactory::createFromProperties(
                    $this->config->getName(),
                    $pid,
                    $this->config->getPort(),
                    $this->config->getFilePath()
                )
            );
            $this->locker->writeToLockFile();
        }

        $this->output->writeln('<info>Done</info>');
        $this->output->writeln(
            sprintf('Test it at http://%s:%s/wd/hub/', $this->config->getHostname(), $this->config->getPort())
        );
    }
}

1			<?php
2			namespace SeleniumSetup\Service;
3
4			use SeleniumSetup\Locker\ServerItemFactory;
5
6			class StartServerService extends AbstractService
7			{
8			protected function createFolders()
9			{
10			// Create the build folder. (Where the binaries will reside).
11			if (!$this->fileSystem->isDir(($this->config->getBuildPath()))) {
12			$this->fileSystem->createDir($this->config->getBuildPath());
13			}
14
15			// Create the tmp folder.
16			if (!$this->fileSystem->isDir(($this->config->getTmpPath()))) {
17			$this->fileSystem->createDir($this->config->getTmpPath());
18			}
19
20			// Create the logs folder.
21			if (!$this->fileSystem->isDir($this->config->getLogsPath())) {
22			$this->fileSystem->createDir($this->config->getLogsPath());
23			}
24			}
25
26			protected function downloadDrivers()
27			{
28			foreach ($this->config->getBinaries() as $binary) {
29			// Skip binaries that don't belong to the current operating system.
30			if (
31			!is_null($binary->getOs()) && $binary->getOs() != $this->env->getOsName() \|\|
32			!is_null($binary->getOsType()) && $binary->getOsType() != $this->env->getOsType()
33			) {
34			continue;
35			}
36
37			$binaryPath = $this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName();
38
39			if (!$this->fileSystem->isFile($binaryPath)) {
40			$this->output->writeln(
41			sprintf('Downloading %s %s ...', $binary->getLabel(), $binary->getVersion())
42			);
43
44			// Download.
45			$downloadTo = $this->config->getBuildPath() . DIRECTORY_SEPARATOR . pathinfo($binary->getDownloadUrl(), PATHINFO_BASENAME);
46			$download = $this->env->download($binary->getDownloadUrl(), $downloadTo);
47			$this->output->writeln($download);
48
49			// Unzip.
50			if (in_array(pathinfo($binary->getDownloadUrl(), PATHINFO_EXTENSION), ['zip', 'tar', 'tar.gz'])) {
51			$zip = new \ZipArchive;
52			$res = $zip->open($downloadTo);
53			if ($res === true) {
54			$zip->extractTo(
55			$this->config->getBuildPath(),
56			[$binary->getBinName()]
57			);
58			$zip->close();
59			}
60			} else {
61			$this->fileSystem->rename($downloadTo, $this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName());
62			}
63
64			// Make executable.
65			$this->env->makeExecutable($this->config->getBuildPath() . DIRECTORY_SEPARATOR . $binary->getBinName());
66			} else {
67			$this->output->writeln(
68			sprintf('Skipping %s %s. Binary already exists.', $binary->getLabel(), $binary->getVersion())
69			);
70			}
71			}
72			}
73
74			public function test()
75			{
76			return $this->env->test();
77			}
78
79			public function handle()
80			{
81			// @todo should allow only registered instances to be called
82
83			$this->createFolders();
84			$this->downloadDrivers();
85
86			// Add build folder to path.
87			$this->env->addPathToGlobalPath($this->config->getBuildPath());
88
89			// Warn if Chrome or Firefox binaries are not available.
90			if ($chromeVersion = $this->env->getChromeVersion()) {
91			$this->output->writeln('Chrome binary found, v.' . $chromeVersion);
92			} else {
93			$this->output->writeln('<info>WARNING: Chrome binary not found.</info>');
94			}
95
96			if ($firefoxVersion = $this->env->getFirefoxVersion()) {
97			$this->output->writeln('Firefox binary found, v.' . $firefoxVersion);
98			} else {
99			$this->output->writeln('<info>WARNING: Firefox binary not found.</info>');
100			}
101
102			// Warn if display is not available.
103			if ($this->env->isLinux()) {
104			if ($this->env->hasXvfb()) {
105			$this->output->writeln('<info>Xvfb is installed. Good.</info>');
106			} else {
107			$this->output->writeln('<info>WARNING: Xvfb is not installed.</info>');
108			}
109			}
110
111			// $pid = $this->env->startDisplayProcess();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-05 01:23 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
112
113			// Start Selenium Server instance.
114			$this->output->writeln(
115			sprintf('Starting Selenium Server (%s) ... %s:%s', $this->config->getName(), $this->config->getHostname(), $this->config->getPort())
116			);
117
118			$pid = $this->env->startSeleniumProcess();
119			if ($pid > 0) {
120			// Make sure that we capture the right PID.
121			while ($this->env->listenToPort($this->config->getPort()) == '') {
122			$this->output->write('<info>.</info>');
123			}
124			$parentPid = $this->env->getPidFromListeningToPort($this->config->getPort());
125			if ($parentPid) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-05 01:23 UTC by Report Bug Copy Issue Report The expression `$parentPid` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
126			$pid = $parentPid;
127			}
128
129			// @todo open the lock file only to update the status and ports, the instance was already added.
130			$this->locker->openLockFile();
131			$this->locker->addServer(
132			ServerItemFactory::createFromProperties(
133			$this->config->getName(),
134			$pid,
135			$this->config->getPort(),
136			$this->config->getFilePath()
137			)
138			);
139			$this->locker->writeToLockFile();
140			}
141
142			$this->output->writeln('<info>Done</info>');
143			$this->output->writeln(
144			sprintf('Test it at http://%s:%s/wd/hub/', $this->config->getHostname(), $this->config->getPort())
145			);
146			}
147			}

bogdananton / Selenium-Setup

GitHub Access Token became invalid

StartServerService::handle() C last analyzed 2016-06-05 13:36 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

StartServerService::handle() C
last analyzed 2016-06-05 13:36 UTC