Boekkooi\Bundle\TwigJackBundle\Assetic\TwigFormulaLoader

Complexity

Total Complexity

20

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	load()	0	15	3
C	loadNode()	0	68	16

<?php
namespace Boekkooi\Bundle\TwigJackBundle\Assetic;

use Assetic\Extension\Twig\AsseticFilterFunction;
use Assetic\Extension\Twig\AsseticNode;
use Assetic\Factory\Loader\FormulaLoaderInterface;
use Assetic\Factory\Resource\ResourceInterface;
use Psr\Log\LoggerInterface;

/**
 * @author Warnar Boekkooi <warnar@boekkooi.net>
 */
class TwigFormulaLoader implements FormulaLoaderInterface
{
    private $twig;
    private $logger;

    public function __construct(\Twig_Environment $twig, LoggerInterface $logger = null)
    {
        $this->twig = $twig;
        $this->logger = $logger;
    }

    public function load(ResourceInterface $resource)
    {
        try {
            $tokens = $this->twig->tokenize($resource->getContent(), (string) $resource);
            $nodes  = $this->twig->parse($tokens);
        } catch (\Exception $e) {
            if ($this->logger) {
                $this->logger->error(sprintf('The template "%s" contains an error: %s', $resource, $e->getMessage()));
            }

            return array();
        }

        return $this->loadNode($nodes);

It seems like $nodes defined by $this->twig->parse($tokens) on line 28 can be null; however, Boekkooi\Bundle\TwigJackBundle\Assetic\TwigFormulaLoader::loadNode() does not accept null, maybe add an additional type check?

    }

    /**
     * Loads assets from the supplied node.
     *
     * @param \Twig_Node $node
     *
     * @return array An array of asset formulae indexed by name
     */
    private function loadNode(\Twig_Node $node)
    {
        $formulae = array();

        if ($node instanceof AsseticNode) {
            $formulae[$node->getAttribute('name')] = array(
                $node->getAttribute('inputs'),
                $node->getAttribute('filters'),
                array(
                    'output'  => $node->getAttribute('asset')->getTargetPath(),
                    'name'    => $node->getAttribute('name'),
                    'debug'   => $node->getAttribute('debug'),
                    'combine' => $node->getAttribute('combine'),
                    'vars'    => $node->getAttribute('vars'),
                ),
            );
        } elseif ($node instanceof \Twig_Node_Expression_Function) {
            $name = version_compare(\Twig_Environment::VERSION, '1.2.0-DEV', '<')
                ? $node->getNode('name')->getAttribute('name')
                : $node->getAttribute('name');

            if ($this->twig->getFunction($name) instanceof AsseticFilterFunction) {
                $arguments = array();
                foreach ($node->getNode('arguments') as $argument) {
                    $arguments[] = eval('return '.$this->twig->compile($argument).';');

It is generally not recommended to use eval unless absolutely required.

                }

                /** @var \Assetic\Extension\Twig\AsseticFilterInvoker $invoker */
                $invoker = $this->twig->getExtension('assetic')->getFilterInvoker($name);

It seems like you code against a concrete implementation and not the interface Twig_ExtensionInterface as the method getFilterInvoker() does only exist in the following implementations of said interface: Assetic\Extension\Twig\AsseticExtension, Symfony\Bundle\AsseticBundle\Twig\AsseticExtension.

                $inputs  = isset($arguments[0]) ? (array) $arguments[0] : array();
                $filters = $invoker->getFilters();
                $options = array_replace($invoker->getOptions(), isset($arguments[1]) ? $arguments[1] : array());

                if (!isset($options['name'])) {
                    $options['name'] = $invoker->getFactory()->generateAssetName($inputs, $filters, $options);
                }

                $formulae[$options['name']] = array($inputs, $filters, $options);
            }
        }

        foreach ($node as $child) {
            if ($child instanceof \Twig_Node) {
                $formulae += $this->loadNode($child);
            }
        }

        if ($node->hasAttribute('embedded_templates')) {
            foreach ($node->getAttribute('embedded_templates') as $child) {
                $formulae += $this->loadNode($child);
            }
        }

        // We need to also check the parent since else it won't get parsed
        if ($node->hasNode('parent') && $node->getNode('parent') instanceof \Twig_Node_Expression_Constant) {
            $parent = $node->getNode('parent')->getAttribute('value');
            if ($parent[0] === '!') {
                $source = $this->twig->getLoader()->getSource($parent);
                $tokens = $this->twig->tokenize($source, $parent);
                $nodes  = $this->twig->parse($tokens);

                $formulae += $this->loadNode($nodes);

It seems like $nodes defined by $this->twig->parse($tokens) on line 107 can be null; however, Boekkooi\Bundle\TwigJackBundle\Assetic\TwigFormulaLoader::loadNode() does not accept null, maybe add an additional type check?

            }
        }

        return $formulae;
    }
}