TaskManager_DeleteElementAction   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 30
Duplicated Lines 100 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 2
Bugs 0 Features 1
Metric Value
wmc 3
c 2
b 0
f 1
lcom 0
cbo 0
dl 30
loc 30
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getName() 4 4 1
A performAction() 10 10 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Craft;
4
5
/**
6
 * Task Manager Delete Element Action.
7
 *
8
 * @author    Bob Olde Hampsink <[email protected]>
9
 * @copyright Copyright (c) 2015, Bob Olde Hampsink
10
 * @license   MIT
11
 *
12
 * @link      http://github.com/boboldehampsink
13
 */
14 View Code Duplication
class TaskManager_DeleteElementAction extends BaseElementAction
15
{
16
    /**
17
     * Get element action name.
18
     *
19
     * @return string
20
     */
21
    public function getName()
22
    {
23
        return Craft::t('Delete task(s)');
24
    }
25
26
    /**
27
     * Delete given task.
28
     *
29
     * @param ElementCriteriaModel $criteria
30
     *
31
     * @return bool
32
     */
33
    public function performAction(ElementCriteriaModel $criteria)
34
    {
35
        foreach ($criteria->id as $taskId) {
36
            craft()->tasks->deleteTaskById($taskId);
37
        }
38
39
        $this->setMessage(Craft::t('Task(s) deleted.'));
40
41
        return true;
42
    }
43
}
44