Bobbyshaw\WatsonVisualRecognition\Commands\BaseCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	getDefaultClient()	0	4	1
A	getClient()	0	4	1

<?php

namespace Bobbyshaw\WatsonVisualRecognition\Commands;

use Bobbyshaw\WatsonVisualRecognition\Client;
use Bobbyshaw\WatsonVisualRecognition\ClientInterface;
use Symfony\Component\Console\Command\Command;

/**
 * Class BaseCommand
 * @package Bobbyshaw\WatsonVisualRecognition\Commands
 */
abstract class BaseCommand extends Command
{

    /** @var Client|ClientInterface  */
    protected $client;

    /**
     * GetClassifiersCommand constructor.
     *
     * @param null|string $name
     * @param ClientInterface $client
     */
    public function __construct($name = null, ClientInterface $client = null)
    {
        $this->client = isset($client) ? $client : $this->getDefaultClient();

isset($client) ? $client : $this->getDefaultClient() is of type object<Bobbyshaw\WatsonVisualRecognition\ClientInterface>, but the property $client was declared to be of type object<Bobbyshaw\WatsonVisualRecognition\Client>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        parent::__construct($name);
    }

    /**
     * @return Client
     */
    public function getDefaultClient()
    {
        return new Client();
    }

    /**
     * @return Client|ClientInterface
     */
    public function getClient()
    {
        return $this->client;
    }
}