SecurityEventsListener::onSwitchUser() - Code Metrics - Inspection of "Added user actions" - bobalazek/web-application-starter-kit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 851100...f799d7 )

by Borut

created 2016-05-12 19:57 UTC

SecurityEventsListener::onSwitchUser() A

↳ Parent: SecurityEventsListener

Complexity

Conditions	2
Paths	2

Size

Total Lines	53
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	53
rs	9.5797
cc	2
eloc	38
nc	2
nop	1

How to fix Long Method

<?php

namespace Application\EventListener;

use Application\Entity\UserActionEntity;
use Symfony\Component\Security\Http\SecurityEvents;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Silex\Application;

/**
 * @author Borut Balažek <[email protected]>
 */
class SecurityEventsListener implements EventSubscriberInterface
{
    protected $app;

    public function __construct(Application $app)
    {
        $this->app = $app;
    }

    public function onInteractiveLogin($event)
    {
        $app = $this->app;

        $token = $event->getAuthenticationToken();
        $user = $token->getUser();

        $userActionEntity = new UserActionEntity();
        $userActionEntity
            ->setUser($user)
            ->setKey('user.login')
            ->setType('event')
            ->setMessage('User has been logged in!')
            ->setIp($app['request']->getClientIp())
            ->setUserAgent($app['request']->headers->get('User-Agent'))
        ;

        $app['orm.em']->persist($userActionEntity);
        $app['orm.em']->flush();
    }

    public function onSwitchUser($event)
    {
        $app = $this->app;

        $user = $app['security']->getToken()->getUser();
        $targetUser = $event->getTargetUser();

        if ($app['security']->isGranted('ROLE_PREVIOUS_ADMIN')) {
            $targetUser = $app['orm.em']
                ->find(
                    'Application\Entity\UserEntity',
                    $targetUser->getId()
                )
            ;
            $userActionEntity = new UserActionEntity();
            $userActionEntity
                ->setUser($targetUser)
                ->setKey('user.switch.back')
                ->setType('event')
                ->setMessage(
                    'User has switched back to own user (from user with ID "'.$user->getId().'")!'
                )
                ->setData(array(
                    'user_id' => $targetUser->getId(),
                    'from_user_id' => $user->getId(),
                ))
                ->setIp($app['request']->getClientIp())
                ->setUserAgent($app['request']->headers->get('User-Agent'))
            ;

            $app['orm.em']->persist($userActionEntity);
            $app['orm.em']->flush();
        } else {
            $userActionEntity = new UserActionEntity();
            $userActionEntity
                ->setUser($user)
                ->setKey('user.switch')
                ->setType('event')
                ->setMessage(
                    'User has switched to user with ID "'.$targetUser->getId().'"!'
                )
                ->setData(array(
                    'user_id' => $user->getId(),
                    'to_user_id' => $targetUser->getId(),
                ))
                ->setIp($app['request']->getClientIp())
                ->setUserAgent($app['request']->headers->get('User-Agent'))
            ;

            $app['orm.em']->persist($userActionEntity);
            $app['orm.em']->flush();
        }
    }

    public static function getSubscribedEvents()
    {
        return array(
            SecurityEvents::INTERACTIVE_LOGIN => array('onInteractiveLogin'),
            SecurityEvents::SWITCH_USER => array('onSwitchUser'),
        );
    }
}


1			<?php
2
3			namespace Application\EventListener;
4
5			use Application\Entity\UserActionEntity;
6			use Symfony\Component\Security\Http\SecurityEvents;
7			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
8			use Silex\Application;
9
10			/**
11			* @author Borut Balažek <[email protected]>
12			*/
13			class SecurityEventsListener implements EventSubscriberInterface
14			{
15			protected $app;
16
17			public function __construct(Application $app)
18			{
19			$this->app = $app;
20			}
21
22			public function onInteractiveLogin($event)
23			{
24			$app = $this->app;
25
26			$token = $event->getAuthenticationToken();
27			$user = $token->getUser();
28
29			$userActionEntity = new UserActionEntity();
30			$userActionEntity
31			->setUser($user)
32			->setKey('user.login')
33			->setType('event')
34			->setMessage('User has been logged in!')
35			->setIp($app['request']->getClientIp())
36			->setUserAgent($app['request']->headers->get('User-Agent'))
37			;
38
39			$app['orm.em']->persist($userActionEntity);
40			$app['orm.em']->flush();
41			}
42
43			public function onSwitchUser($event)
44			{
45			$app = $this->app;
46
47			$user = $app['security']->getToken()->getUser();
48			$targetUser = $event->getTargetUser();
49
50			if ($app['security']->isGranted('ROLE_PREVIOUS_ADMIN')) {
51			$targetUser = $app['orm.em']
52			->find(
53			'Application\Entity\UserEntity',
54			$targetUser->getId()
55			)
56			;
57			$userActionEntity = new UserActionEntity();
58			$userActionEntity
59			->setUser($targetUser)
60			->setKey('user.switch.back')
61			->setType('event')
62			->setMessage(
63			'User has switched back to own user (from user with ID "'.$user->getId().'")!'
64			)
65			->setData(array(
66			'user_id' => $targetUser->getId(),
67			'from_user_id' => $user->getId(),
68			))
69			->setIp($app['request']->getClientIp())
70			->setUserAgent($app['request']->headers->get('User-Agent'))
71			;
72
73			$app['orm.em']->persist($userActionEntity);
74			$app['orm.em']->flush();
75			} else {
76			$userActionEntity = new UserActionEntity();
77			$userActionEntity
78			->setUser($user)
79			->setKey('user.switch')
80			->setType('event')
81			->setMessage(
82			'User has switched to user with ID "'.$targetUser->getId().'"!'
83			)
84			->setData(array(
85			'user_id' => $user->getId(),
86			'to_user_id' => $targetUser->getId(),
87			))
88			->setIp($app['request']->getClientIp())
89			->setUserAgent($app['request']->headers->get('User-Agent'))
90			;
91
92			$app['orm.em']->persist($userActionEntity);
93			$app['orm.em']->flush();
94			}
95			}
96
97			public static function getSubscribedEvents()
98			{
99			return array(
100			SecurityEvents::INTERACTIVE_LOGIN => array('onInteractiveLogin'),
101			SecurityEvents::SWITCH_USER => array('onSwitchUser'),
102			);
103			}
104			}
105

bobalazek / web-application-starter-kit

GitHub Access Token became invalid

Push — develop ( 851100...f799d7 )

SecurityEventsListener::onSwitchUser() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like