Complex classes like UserEntity often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UserEntity, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class UserEntity implements AdvancedUserInterface, \Serializable |
||
| 20 | { |
||
| 21 | /** |
||
| 22 | * @var int |
||
| 23 | * |
||
| 24 | * @ORM\Column(name="id", type="integer") |
||
| 25 | * @ORM\Id |
||
| 26 | * @ORM\GeneratedValue(strategy="IDENTITY") |
||
| 27 | */ |
||
| 28 | protected $id; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * What is the locale for this user? |
||
| 32 | * |
||
| 33 | * @var string |
||
| 34 | * |
||
| 35 | * @ORM\Column(name="locale", type="string", length=8, nullable=true) |
||
| 36 | */ |
||
| 37 | protected $locale = 'en_US'; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var string |
||
| 41 | * |
||
| 42 | * @ORM\Column(name="username", type="string", length=64, unique=true) |
||
| 43 | */ |
||
| 44 | protected $username; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @var string |
||
| 48 | * |
||
| 49 | * @ORM\Column(name="email", type="string", length=64, unique=true) |
||
| 50 | */ |
||
| 51 | protected $email; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * We must confirm the new password, so temporary save it inside this field. |
||
| 55 | * |
||
| 56 | * @var string |
||
| 57 | * |
||
| 58 | * @ORM\Column(name="new_email", type="string", length=64, nullable=true) |
||
| 59 | */ |
||
| 60 | protected $newEmail; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var array |
||
| 64 | * |
||
| 65 | * @ORM\Column(name="roles", type="json_array", nullable=true) |
||
| 66 | */ |
||
| 67 | protected $roles; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var string |
||
| 71 | * |
||
| 72 | * @ORM\Column(name="password", type="string", length=255) |
||
| 73 | */ |
||
| 74 | protected $password; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Used only when saving the user. |
||
| 78 | * |
||
| 79 | * @var string |
||
| 80 | */ |
||
| 81 | protected $plainPassword; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * Used only when saving a new password. |
||
| 85 | * |
||
| 86 | * @var string |
||
| 87 | */ |
||
| 88 | protected $oldPassword; |
||
| 89 | |||
| 90 | /** |
||
| 91 | * @var string |
||
| 92 | * |
||
| 93 | * @ORM\Column(name="salt", type="string", length=255, nullable=true) |
||
| 94 | */ |
||
| 95 | protected $salt; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * @var bool |
||
| 99 | * |
||
| 100 | * @ORM\Column(name="enabled", type="boolean") |
||
| 101 | */ |
||
| 102 | protected $enabled = true; |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @var bool |
||
| 106 | * |
||
| 107 | * @ORM\Column(name="locked", type="boolean") |
||
| 108 | */ |
||
| 109 | protected $locked = false; |
||
| 110 | |||
| 111 | /** |
||
| 112 | * @var string |
||
| 113 | * |
||
| 114 | * @ORM\Column(name="reset_password_code", type="string", length=255, nullable=true, unique=true) |
||
| 115 | */ |
||
| 116 | protected $resetPasswordCode; |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @var string |
||
| 120 | * |
||
| 121 | * @ORM\Column(name="activation_code", type="string", length=255, nullable=true, unique=true) |
||
| 122 | */ |
||
| 123 | protected $activationCode; |
||
| 124 | |||
| 125 | /** |
||
| 126 | * @var string |
||
| 127 | * |
||
| 128 | * @ORM\Column(name="new_email_code", type="string", length=255, nullable=true, unique=true) |
||
| 129 | */ |
||
| 130 | protected $newEmailCode; |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @var \DateTime |
||
| 134 | * |
||
| 135 | * @ORM\Column(name="time_last_active", type="datetime", nullable=true) |
||
| 136 | */ |
||
| 137 | protected $timeLastActive; |
||
| 138 | |||
| 139 | /** |
||
| 140 | * @var \DateTime |
||
| 141 | * |
||
| 142 | * @ORM\Column(name="time_reset_password_code_expires", type="datetime", nullable=true) |
||
| 143 | */ |
||
| 144 | protected $timeResetPasswordCodeExpires; |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @var \DateTime |
||
| 148 | * |
||
| 149 | * @ORM\Column(name="time_created", type="datetime") |
||
| 150 | */ |
||
| 151 | protected $timeCreated; |
||
| 152 | |||
| 153 | /** |
||
| 154 | * @var \DateTime |
||
| 155 | * |
||
| 156 | * @ORM\Column(name="time_updated", type="datetime") |
||
| 157 | */ |
||
| 158 | protected $timeUpdated; |
||
| 159 | |||
| 160 | /** |
||
| 161 | * @ORM\OneToOne(targetEntity="Application\Entity\ProfileEntity", mappedBy="user", cascade={"all"}) |
||
| 162 | **/ |
||
| 163 | protected $profile; |
||
| 164 | |||
| 165 | /** |
||
| 166 | * @var ArrayCollection |
||
| 167 | * |
||
| 168 | * @ORM\OneToMany(targetEntity="Application\Entity\PostEntity", mappedBy="user", cascade={"all"}) |
||
| 169 | */ |
||
| 170 | protected $posts; |
||
| 171 | |||
| 172 | /** |
||
| 173 | * @var ArrayCollection |
||
| 174 | * |
||
| 175 | * @ORM\OneToMany(targetEntity="Application\Entity\UserActionEntity", mappedBy="user", cascade={"all"}) |
||
| 176 | */ |
||
| 177 | protected $userActions; |
||
| 178 | |||
| 179 | /** |
||
| 180 | * Otherwise known as: userExpired / accountExpired. |
||
| 181 | * |
||
| 182 | * @var bool |
||
| 183 | */ |
||
| 184 | protected $expired = false; |
||
| 185 | |||
| 186 | /** |
||
| 187 | * @var bool |
||
| 188 | */ |
||
| 189 | protected $credentialsExpired = false; |
||
| 190 | |||
| 191 | /** |
||
| 192 | * The constructor. |
||
| 193 | */ |
||
| 194 | public function __construct() |
||
| 215 | |||
| 216 | /*** Id ***/ |
||
| 217 | /** |
||
| 218 | * @return int |
||
| 219 | */ |
||
| 220 | public function getId() |
||
| 224 | |||
| 225 | /** |
||
| 226 | * @param int $id |
||
| 227 | * |
||
| 228 | * @return UserEntity |
||
| 229 | */ |
||
| 230 | public function setId($id) |
||
| 236 | |||
| 237 | /*** Locale ***/ |
||
| 238 | /** |
||
| 239 | * @return string |
||
| 240 | */ |
||
| 241 | public function getLocale() |
||
| 245 | |||
| 246 | /** |
||
| 247 | * @param string $locale |
||
| 248 | * |
||
| 249 | * @return UserEntity |
||
| 250 | */ |
||
| 251 | public function setLocale($locale) |
||
| 257 | |||
| 258 | /*** Username ***/ |
||
| 259 | /** |
||
| 260 | * @return string |
||
| 261 | */ |
||
| 262 | public function getUsername() |
||
| 266 | |||
| 267 | /** |
||
| 268 | * @param string $username |
||
| 269 | * |
||
| 270 | * @return UserEntity |
||
| 271 | */ |
||
| 272 | public function setUsername($username) |
||
| 278 | |||
| 279 | /*** Email ***/ |
||
| 280 | /** |
||
| 281 | * @return string |
||
| 282 | */ |
||
| 283 | public function getEmail() |
||
| 287 | |||
| 288 | /** |
||
| 289 | * @param string $email |
||
| 290 | * |
||
| 291 | * @return UserEntity |
||
| 292 | */ |
||
| 293 | public function setEmail($email) |
||
| 299 | |||
| 300 | /*** New email ***/ |
||
| 301 | /** |
||
| 302 | * @return string |
||
| 303 | */ |
||
| 304 | public function getNewEmail() |
||
| 308 | |||
| 309 | /** |
||
| 310 | * @param string $newEmail |
||
| 311 | * |
||
| 312 | * @return UserEntity |
||
| 313 | */ |
||
| 314 | public function setNewEmail($newEmail) |
||
| 320 | |||
| 321 | /*** Password ***/ |
||
| 322 | /** |
||
| 323 | * @return string |
||
| 324 | */ |
||
| 325 | public function getPassword() |
||
| 329 | |||
| 330 | /** |
||
| 331 | * @param string $password |
||
| 332 | * |
||
| 333 | * @return UserEntity |
||
| 334 | */ |
||
| 335 | public function setPassword($password) |
||
| 343 | |||
| 344 | /*** Plain password ***/ |
||
| 345 | /** |
||
| 346 | * @return string |
||
| 347 | */ |
||
| 348 | public function getPlainPassword() |
||
| 352 | |||
| 353 | /** |
||
| 354 | * @param string $plainPassword |
||
| 355 | * @param EncoderFactory $encoderFactory |
||
| 356 | * |
||
| 357 | * @return UserEntity |
||
| 358 | */ |
||
| 359 | public function setPlainPassword($plainPassword, EncoderFactory $encoderFactory = null) |
||
| 376 | |||
| 377 | /*** Old password ***/ |
||
| 378 | /** |
||
| 379 | * @return string |
||
| 380 | */ |
||
| 381 | public function getOldPassword() |
||
| 385 | |||
| 386 | /** |
||
| 387 | * @param string $oldPassword |
||
| 388 | * |
||
| 389 | * @return UserEntity |
||
| 390 | */ |
||
| 391 | public function setOldPassword($oldPassword) |
||
| 397 | |||
| 398 | /*** Salt ***/ |
||
| 399 | /** |
||
| 400 | * @return string |
||
| 401 | */ |
||
| 402 | public function getSalt() |
||
| 406 | |||
| 407 | /** |
||
| 408 | * @param string $salt |
||
| 409 | * |
||
| 410 | * @return UserEntity |
||
| 411 | */ |
||
| 412 | public function setSalt($salt) |
||
| 418 | |||
| 419 | /*** Enabled ***/ |
||
| 420 | /** |
||
| 421 | * @return bool |
||
| 422 | */ |
||
| 423 | public function getEnabled() |
||
| 427 | |||
| 428 | /** |
||
| 429 | * @return bool |
||
| 430 | */ |
||
| 431 | public function isEnabled() |
||
| 435 | |||
| 436 | /** |
||
| 437 | * @param bool $enabled |
||
| 438 | */ |
||
| 439 | public function setEnabled($enabled) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * @return UserEntity |
||
| 448 | */ |
||
| 449 | public function enable() |
||
| 455 | |||
| 456 | /** |
||
| 457 | * @return UserEntity |
||
| 458 | */ |
||
| 459 | public function disable() |
||
| 465 | |||
| 466 | /*** Locked ***/ |
||
| 467 | /** |
||
| 468 | * @return bool |
||
| 469 | */ |
||
| 470 | public function getLocked() |
||
| 474 | |||
| 475 | /** |
||
| 476 | * @return bool |
||
| 477 | */ |
||
| 478 | public function isLocked() |
||
| 482 | |||
| 483 | /** |
||
| 484 | * @param bool $locked |
||
| 485 | * |
||
| 486 | * @return UserEntity |
||
| 487 | */ |
||
| 488 | public function setLocked($locked) |
||
| 494 | |||
| 495 | /** |
||
| 496 | * @return UserEntity |
||
| 497 | */ |
||
| 498 | public function lock() |
||
| 504 | |||
| 505 | /** |
||
| 506 | * @return bool |
||
| 507 | */ |
||
| 508 | public function isAccountNonLocked() |
||
| 512 | |||
| 513 | /*** Reset password code ***/ |
||
| 514 | /** |
||
| 515 | * @return string |
||
| 516 | */ |
||
| 517 | public function getResetPasswordCode() |
||
| 521 | |||
| 522 | /** |
||
| 523 | * @param string $resetPasswordCode |
||
| 524 | * |
||
| 525 | * @return UserEntity |
||
| 526 | */ |
||
| 527 | public function setResetPasswordCode($resetPasswordCode) |
||
| 533 | |||
| 534 | /*** Activation code ***/ |
||
| 535 | /** |
||
| 536 | * @return string |
||
| 537 | */ |
||
| 538 | public function getActivationCode() |
||
| 542 | |||
| 543 | /** |
||
| 544 | * @param string $activationCode |
||
| 545 | * |
||
| 546 | * @return UserEntity |
||
| 547 | */ |
||
| 548 | public function setActivationCode($activationCode) |
||
| 554 | |||
| 555 | /*** New email code ***/ |
||
| 556 | /** |
||
| 557 | * @return string |
||
| 558 | */ |
||
| 559 | public function getNewEmailCode() |
||
| 563 | |||
| 564 | /** |
||
| 565 | * @param string $newEmailCode |
||
| 566 | * |
||
| 567 | * @return UserEntity |
||
| 568 | */ |
||
| 569 | public function setNewEmailCode($newEmailCode) |
||
| 575 | |||
| 576 | /*** Time last active ***/ |
||
| 577 | /** |
||
| 578 | * @return \DateTime |
||
| 579 | */ |
||
| 580 | public function getTimeLastActive() |
||
| 584 | |||
| 585 | /** |
||
| 586 | * @param $timeLastActive |
||
| 587 | * |
||
| 588 | * @return UserEntity |
||
| 589 | */ |
||
| 590 | public function setTimeLastActive(\Datetime $timeLastActive = null) |
||
| 596 | |||
| 597 | /*** Time reset password code expires ***/ |
||
| 598 | /** |
||
| 599 | * @return \DateTime |
||
| 600 | */ |
||
| 601 | public function getTimeResetPasswordCodeExpires() |
||
| 605 | |||
| 606 | /** |
||
| 607 | * @param $timeResetPasswordCodeExpires |
||
| 608 | * |
||
| 609 | * @return UserEntity |
||
| 610 | */ |
||
| 611 | public function setTimeResetPasswordCodeExpires(\Datetime $timeResetPasswordCodeExpires = null) |
||
| 617 | |||
| 618 | /*** Time created ***/ |
||
| 619 | /** |
||
| 620 | * @return \DateTime |
||
| 621 | */ |
||
| 622 | public function getTimeCreated() |
||
| 626 | |||
| 627 | /** |
||
| 628 | * @param \DateTime $timeCreated |
||
| 629 | * |
||
| 630 | * @return UserEntity |
||
| 631 | */ |
||
| 632 | public function setTimeCreated(\Datetime $timeCreated) |
||
| 638 | |||
| 639 | /*** Time updated ***/ |
||
| 640 | /** |
||
| 641 | * @return \DateTime |
||
| 642 | */ |
||
| 643 | public function getTimeUpdated() |
||
| 647 | |||
| 648 | /** |
||
| 649 | * @param \DateTime $timeUpdated |
||
| 650 | * |
||
| 651 | * @return UserEntity |
||
| 652 | */ |
||
| 653 | public function setTimeUpdated(\DateTime $timeUpdated) |
||
| 659 | |||
| 660 | /*** Expired ***/ |
||
| 661 | /** |
||
| 662 | * @return bool |
||
| 663 | */ |
||
| 664 | public function getExpired() |
||
| 668 | |||
| 669 | /** |
||
| 670 | * @return bool |
||
| 671 | */ |
||
| 672 | public function isExpired() |
||
| 676 | |||
| 677 | /** |
||
| 678 | * @return bool |
||
| 679 | */ |
||
| 680 | public function isAccountNonExpired() |
||
| 684 | |||
| 685 | /*** Credentials expired ***/ |
||
| 686 | /** |
||
| 687 | * @return bool |
||
| 688 | */ |
||
| 689 | public function getCredentialsExpired() |
||
| 693 | |||
| 694 | /** |
||
| 695 | * @return bool |
||
| 696 | */ |
||
| 697 | public function isCredentialsExpired() |
||
| 701 | |||
| 702 | /** |
||
| 703 | * @return bool |
||
| 704 | */ |
||
| 705 | public function isCredentialsNonExpired() |
||
| 709 | |||
| 710 | /*** Roles ***/ |
||
| 711 | /** |
||
| 712 | * @return array |
||
| 713 | */ |
||
| 714 | public function getRoles() |
||
| 724 | |||
| 725 | /** |
||
| 726 | * @param array $roles |
||
| 727 | * |
||
| 728 | * @return UserEntity |
||
| 729 | */ |
||
| 730 | public function setRoles(array $roles) |
||
| 736 | |||
| 737 | /** |
||
| 738 | * @param string $role |
||
| 739 | * |
||
| 740 | * @return bool |
||
| 741 | */ |
||
| 742 | public function hasRole($role) |
||
| 749 | |||
| 750 | /*** Profile ***/ |
||
| 751 | /** |
||
| 752 | * @return ProfileEntity |
||
| 753 | */ |
||
| 754 | public function getProfile() |
||
| 758 | |||
| 759 | /** |
||
| 760 | * @param ProfileEntity $profile |
||
| 761 | * |
||
| 762 | * @return UserEntity |
||
| 763 | */ |
||
| 764 | public function setProfile(ProfileEntity $profile) |
||
| 772 | |||
| 773 | /*** Posts ***/ |
||
| 774 | /** |
||
| 775 | * @return array |
||
| 776 | */ |
||
| 777 | public function getPosts() |
||
| 781 | |||
| 782 | /** |
||
| 783 | * @param ArrayCollection $posts |
||
| 784 | * |
||
| 785 | * @return UserEntity |
||
| 786 | */ |
||
| 787 | public function setPosts($posts) |
||
| 793 | |||
| 794 | /*** User actions ***/ |
||
| 795 | /** |
||
| 796 | * @return array |
||
| 797 | */ |
||
| 798 | public function getUserActions() |
||
| 802 | |||
| 803 | /** |
||
| 804 | * @param $userActions |
||
| 805 | * |
||
| 806 | * @return UserEntity |
||
| 807 | */ |
||
| 808 | public function setUserActions($userActions) |
||
| 814 | |||
| 815 | /** |
||
| 816 | * @param AdvancedUserInterface $user |
||
| 817 | * |
||
| 818 | * @return bool |
||
| 819 | */ |
||
| 820 | public function isEqualTo(AdvancedUserInterface $user) |
||
| 844 | |||
| 845 | /** |
||
| 846 | * {@inheritdoc} |
||
| 847 | */ |
||
| 848 | public function eraseCredentials() |
||
| 852 | |||
| 853 | /** |
||
| 854 | * @return string |
||
| 855 | */ |
||
| 856 | public function serialize() |
||
| 866 | |||
| 867 | /** |
||
| 868 | * {@inheritdoc} |
||
| 869 | */ |
||
| 870 | public function unserialize($serialized) |
||
| 879 | |||
| 880 | /** |
||
| 881 | * @return string |
||
| 882 | */ |
||
| 883 | public function __toString() |
||
| 887 | |||
| 888 | /** |
||
| 889 | * @param $allData Show all the data for this user. |
||
| 890 | * |
||
| 891 | * @return array |
||
| 892 | */ |
||
| 893 | public function toArray($allData = true) |
||
| 917 | |||
| 918 | /** |
||
| 919 | * @ORM\PreUpdate |
||
| 920 | */ |
||
| 921 | public function preUpdate() |
||
| 925 | |||
| 926 | /** |
||
| 927 | * @ORM\PrePersist |
||
| 928 | */ |
||
| 929 | public function prePersist() |
||
| 934 | } |
||
| 935 |