Application\Controller\MembersArea\Tools\EmailController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	93
Duplicated Lines	16.13 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	15	15	2
B	previewTemplatesAction()	0	62	6

<?php

namespace Application\Controller\MembersArea\Tools;

use Application\Tool\Helpers;
use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Borut Balažek <bobalazek124@gmail.com>
 */
class EmailController
{
    /**
     * @param Request     $request
     * @param Application $app
     *
     * @return Response
     */
    public function indexAction(Request $request, Application $app)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $data = array();

        if (!$app['security']->isGranted('ROLE_ADMIN')) {
            $app->abort(403);
        }

        return new Response(
            $app['twig']->render(
                'contents/members-area/tools/email.html.twig',
                $data
            )
        );
    }

    /**
     * @param Request     $request
     * @param Application $app
     *
     * @return Response
     */
    public function previewTemplatesAction(Request $request, Application $app)
    {
        if (!$app['security']->isGranted('ROLE_ADMIN')) {
            $app->abort(403);
        }

        $data = array();

        $templates = array();
        $template = $request->query->get('template', false);
        $raw = $request->query->has('raw');

        // Set some possible global defaults for the template
        $emailData = array(
            'app' => $app,
            'user' => $app['user'],
            'content' => 'Hello world!',
            'formData' => array(
                'message' => 'Just a test message!',
            ),
        );

        if ($template && $raw) {
            $app['debug'] = false;
            $app['showProfiler'] = false;

            return $app['mailer.css_to_inline_styles_converter'](
                'emails/'.$template.'.html.twig',
                $emailData
            );
        }

        $templatesArray = Helpers::rglob(
            APP_DIR.'/templates/emails/*.html.twig'
        );

        if ($templatesArray) {

The expression $templatesArray of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($templatesArray as $templatePath) {
                $templatePath = str_replace(
                    APP_DIR.'/templates/emails/',
                    '',
                    $templatePath
                );

                $templates[] = str_replace(
                    '.html.twig',
                    '',
                    $templatePath
                );
            }
        }

        $data['template'] = $template;
        $data['templates'] = $templates;

        return new Response(
            $app['twig']->render(
                'contents/members-area/tools/email/preview-templates.html.twig',
                $data
            )
        );
    }
}