MyController - Code Metrics - Inspection of "Many changes and stuff" - bobalazek/web-application-starter-kit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( f799d7...e8545c )

by Borut

created 2016-05-15 10:09 UTC

MyController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	202
Duplicated Lines	18.32 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes	10
Bugs	4	Features	0

Metric	Value
wmc	11
c	10
b	4
f	0
lcom	0
cbo	7
dl	37
loc	202
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	6	1
A	profileAction()	0	8	1
B	settingsAction()	0	64	4
B	passwordAction()	0	52	4
B	actionsAction()	37	37	1

How to fix Duplicated Code

<?php

namespace Application\Controller\MembersArea;

use Application\Entity\UserActionEntity;
use Application\Form\Type\User\SettingsType;
use Application\Form\Type\User\PasswordType;
use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Borut Balažek <[email protected]>
 */
class MyController
{
    /**
     * @param Application $app
     *
     * @return Response
     */
    public function indexAction(Application $app)
    {
        return $app->redirect(
            $app['url_generator']->generate('members-area.my.profile')
        );
    }

    /**
     * @param Application $app
     *
     * @return Response
     */
    public function profileAction(Application $app)
    {
        return new Response(
            $app['twig']->render(
                'contents/members-area/my/profile.html.twig'
            )
        );
    }

    /**
     * @param Request     $request
     * @param Application $app
     *
     * @return Response
     */
    public function settingsAction(Request $request, Application $app)
    {
        $userOld = $app['user']->toArray(false);

        $form = $app['form.factory']->create(
            new SettingsType(),
            $app['user']
        );

        if ($request->getMethod() == 'POST') {
            $form->handleRequest($request);

            if ($form->isValid()) {
                $userEntity = $form->getData();

                if ($userEntity->getProfile()->getRemoveImage()) {
                    $userEntity->getProfile()->setImageUrl(null);
                }

                /*** Image ***/
                $userEntity
                    ->getProfile()
                    ->setImageUploadPath($app['baseUrl'].'/assets/uploads/')
                    ->setImageUploadDir(WEB_DIR.'/assets/uploads/')
                    ->imageUpload()
                ;
                $app['orm.em']->persist($userEntity);

                $userActionEntity = new UserActionEntity();
                $userActionEntity
                    ->setUser($userEntity)
                    ->setKey('user.settings.change')
                    ->setMessage('User has changed his settings!')
                    ->setData(array(
                        'old' => $userOld,
                        'new' => $app['user']->toArray(false),
                    ))
                    ->setIp($app['request']->getClientIp())
                    ->setUserAgent($app['request']->headers->get('User-Agent'))
                ;
                $app['orm.em']->persist($userActionEntity);

                $app['orm.em']->flush();

                $app['flashbag']->add(
                    'success',
                    $app['translator']->trans(
                        'Your settings were successfully saved!'
                    )
                );
            } else {
                $app['orm.em']->refresh($app['user']);
            }
        }

        return new Response(
            $app['twig']->render(
                'contents/members-area/my/settings.html.twig',
                array(
                    'form' => $form->createView(),
                )
            )
        );
    }

    /**
     * @param Request     $request
     * @param Application $app
     *
     * @return Response
     */
    public function passwordAction(Request $request, Application $app)
    {
        $form = $app['form.factory']->create(
            new PasswordType(),
            $app['user']
        );

        if ($request->getMethod() == 'POST') {
            $form->handleRequest($request);

            if ($form->isValid()) {
                $userEntity = $form->getData();

                if ($userEntity->getPlainPassword()) {
                    $userEntity->setPlainPassword(
                        $userEntity->getPlainPassword(),
                        $app['security.encoder_factory']
                    );

                    $app['orm.em']->persist($userEntity);

                    $userActionEntity = new UserActionEntity();
                    $userActionEntity
                        ->setUser($userEntity)
                        ->setKey('user.password.change')
                        ->setMessage('User has changed his password!')
                        ->setIp($app['request']->getClientIp())
                        ->setUserAgent($app['request']->headers->get('User-Agent'))
                    ;
                    $app['orm.em']->persist($userActionEntity);

                    $app['orm.em']->flush();

                    $app['flashbag']->add(
                        'success',
                        $app['translator']->trans(
                            'Your password was successfully changed!'
                        )
                    );
                }
            }
        }

        return new Response(
            $app['twig']->render(
                'contents/members-area/my/password.html.twig',
                array(
                    'form' => $form->createView(),
                )
            )
        );
    }

    /**
     * @param Request     $request
     * @param Application $app
     *
     * @return Response
     */
    public function actionsAction(Request $request, Application $app)

    {
        $limitPerPage = $request->query->get('limit_per_page', 20);
        $currentPage = $request->query->get('page');

        $userActionResults = $app['orm.em']
            ->createQueryBuilder()
            ->select('ua')
            ->from('Application\Entity\UserActionEntity', 'ua')
            ->where('ua.user = ?1')
            ->setParameter(1, $app['user'])
        ;

        $pagination = $app['paginator']->paginate(
            $userActionResults,
            $currentPage,
            $limitPerPage,
            array(
                'route' => 'members-area.my.actions',
                'defaultSortFieldName' => 'ua.timeCreated',
                'defaultSortDirection' => 'desc',
                'searchFields' => array(
                    'ua.key',
                    'ua.ip',
                ),
            )
        );

        return new Response(
            $app['twig']->render(
                'contents/members-area/my/actions.html.twig',
                array(
                    'pagination' => $pagination,
                )
            )
        );
    }
}


1		<?php
2
3		namespace Application\Controller\MembersArea;
4
5		use Application\Entity\UserActionEntity;
6		use Application\Form\Type\User\SettingsType;
7		use Application\Form\Type\User\PasswordType;
8		use Silex\Application;
9		use Symfony\Component\HttpFoundation\Request;
10		use Symfony\Component\HttpFoundation\Response;
11
12		/**
13		* @author Borut Balažek <[email protected]>
14		*/
15		class MyController
16		{
17		/**
18		* @param Application $app
19		*
20		* @return Response
21		*/
22		public function indexAction(Application $app)
23		{
24		return $app->redirect(
25		$app['url_generator']->generate('members-area.my.profile')
26		);
27		}
28
29		/**
30		* @param Application $app
31		*
32		* @return Response
33		*/
34		public function profileAction(Application $app)
35		{
36		return new Response(
37		$app['twig']->render(
38		'contents/members-area/my/profile.html.twig'
39		)
40		);
41		}
42
43		/**
44		* @param Request $request
45		* @param Application $app
46		*
47		* @return Response
48		*/
49		public function settingsAction(Request $request, Application $app)
50		{
51		$userOld = $app['user']->toArray(false);
52
53		$form = $app['form.factory']->create(
54		new SettingsType(),
55		$app['user']
56		);
57
58		if ($request->getMethod() == 'POST') {
59		$form->handleRequest($request);
60
61		if ($form->isValid()) {
62		$userEntity = $form->getData();
63
64		if ($userEntity->getProfile()->getRemoveImage()) {
65		$userEntity->getProfile()->setImageUrl(null);
66		}
67
68		/* Image */
69		$userEntity
70		->getProfile()
71		->setImageUploadPath($app['baseUrl'].'/assets/uploads/')
72		->setImageUploadDir(WEB_DIR.'/assets/uploads/')
73		->imageUpload()
74		;
75		$app['orm.em']->persist($userEntity);
76
77		$userActionEntity = new UserActionEntity();
78		$userActionEntity
79		->setUser($userEntity)
80		->setKey('user.settings.change')
81		->setMessage('User has changed his settings!')
82		->setData(array(
83		'old' => $userOld,
84		'new' => $app['user']->toArray(false),
85		))
86		->setIp($app['request']->getClientIp())
87		->setUserAgent($app['request']->headers->get('User-Agent'))
88		;
89		$app['orm.em']->persist($userActionEntity);
90
91		$app['orm.em']->flush();
92
93		$app['flashbag']->add(
94		'success',
95		$app['translator']->trans(
96		'Your settings were successfully saved!'
97		)
98		);
99		} else {
100		$app['orm.em']->refresh($app['user']);
101		}
102		}
103
104		return new Response(
105		$app['twig']->render(
106		'contents/members-area/my/settings.html.twig',
107		array(
108		'form' => $form->createView(),
109		)
110		)
111		);
112		}
113
114		/**
115		* @param Request $request
116		* @param Application $app
117		*
118		* @return Response
119		*/
120		public function passwordAction(Request $request, Application $app)
121		{
122		$form = $app['form.factory']->create(
123		new PasswordType(),
124		$app['user']
125		);
126
127		if ($request->getMethod() == 'POST') {
128		$form->handleRequest($request);
129
130		if ($form->isValid()) {
131		$userEntity = $form->getData();
132
133		if ($userEntity->getPlainPassword()) {
134		$userEntity->setPlainPassword(
135		$userEntity->getPlainPassword(),
136		$app['security.encoder_factory']
137		);
138
139		$app['orm.em']->persist($userEntity);
140
141		$userActionEntity = new UserActionEntity();
142		$userActionEntity
143		->setUser($userEntity)
144		->setKey('user.password.change')
145		->setMessage('User has changed his password!')
146		->setIp($app['request']->getClientIp())
147		->setUserAgent($app['request']->headers->get('User-Agent'))
148		;
149		$app['orm.em']->persist($userActionEntity);
150
151		$app['orm.em']->flush();
152
153		$app['flashbag']->add(
154		'success',
155		$app['translator']->trans(
156		'Your password was successfully changed!'
157		)
158		);
159		}
160		}
161		}
162
163		return new Response(
164		$app['twig']->render(
165		'contents/members-area/my/password.html.twig',
166		array(
167		'form' => $form->createView(),
168		)
169		)
170		);
171		}
172
173		/**
174		* @param Request $request
175		* @param Application $app
176		*
177		* @return Response
178		*/
179	View Code Duplication	public function actionsAction(Request $request, Application $app)
		0 ignored issues – show Duplication introduced 2016-05-15 10:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		{
181		$limitPerPage = $request->query->get('limit_per_page', 20);
182		$currentPage = $request->query->get('page');
183
184		$userActionResults = $app['orm.em']
185		->createQueryBuilder()
186		->select('ua')
187		->from('Application\Entity\UserActionEntity', 'ua')
188		->where('ua.user = ?1')
189		->setParameter(1, $app['user'])
190		;
191
192		$pagination = $app['paginator']->paginate(
193		$userActionResults,
194		$currentPage,
195		$limitPerPage,
196		array(
197		'route' => 'members-area.my.actions',
198		'defaultSortFieldName' => 'ua.timeCreated',
199		'defaultSortDirection' => 'desc',
200		'searchFields' => array(
201		'ua.key',
202		'ua.ip',
203		),
204		)
205		);
206
207		return new Response(
208		$app['twig']->render(
209		'contents/members-area/my/actions.html.twig',
210		array(
211		'pagination' => $pagination,
212		)
213		)
214		);
215		}
216		}
217

bobalazek / web-application-starter-kit

GitHub Access Token became invalid

Push — develop ( f799d7...e8545c )

MyController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like