bobalazek /
web-application-starter-kit
| Conditions | 6 |
| Paths | 6 |
| Total Lines | 63 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function previewTemplatesAction(Request $request, Application $app) |
||
| 43 | { |
||
| 44 | if (!$app['security']->isGranted('ROLE_ADMIN')) { |
||
| 45 | $app->abort(403); |
||
| 46 | } |
||
| 47 | |||
| 48 | $data = array(); |
||
| 49 | |||
| 50 | $templates = array(); |
||
| 51 | $template = $request->query->get('template', false); |
||
| 52 | $raw = $request->query->has('raw'); |
||
| 53 | |||
| 54 | // Set some possible global defaults for the template |
||
| 55 | $emailData = array( |
||
| 56 | 'app' => $app, |
||
| 57 | 'user' => $app['user'], |
||
| 58 | 'content' => 'Hello world!', |
||
| 59 | 'formData' => array( |
||
| 60 | 'message' => 'Just a test message!', |
||
| 61 | ), |
||
| 62 | 'e' => new \Exception('Some error happened!'), |
||
| 63 | ); |
||
| 64 | |||
| 65 | if ($template && $raw) { |
||
| 66 | $app['debug'] = false; |
||
| 67 | $app['showProfiler'] = false; |
||
| 68 | |||
| 69 | return $app['mailer.css_to_inline_styles_converter']( |
||
| 70 | 'emails/'.$template.'.html.twig', |
||
| 71 | $emailData |
||
| 72 | ); |
||
| 73 | } |
||
| 74 | |||
| 75 | $templatesArray = Helpers::rglob( |
||
| 76 | APP_DIR.'/templates/emails/*.html.twig' |
||
| 77 | ); |
||
| 78 | |||
| 79 | if (!empty($templatesArray)) { |
||
| 80 | foreach ($templatesArray as $templatePath) { |
||
| 81 | $templatePath = str_replace( |
||
| 82 | APP_DIR.'/templates/emails/', |
||
| 83 | '', |
||
| 84 | $templatePath |
||
| 85 | ); |
||
| 86 | |||
| 87 | $templates[] = str_replace( |
||
| 88 | '.html.twig', |
||
| 89 | '', |
||
| 90 | $templatePath |
||
| 91 | ); |
||
| 92 | } |
||
| 93 | } |
||
| 94 | |||
| 95 | $data['template'] = $template; |
||
| 96 | $data['templates'] = $templates; |
||
| 97 | |||
| 98 | return new Response( |
||
| 99 | $app['twig']->render( |
||
| 100 | 'contents/members-area/tools/email/preview-templates.html.twig', |
||
| 101 | $data |
||
| 102 | ) |
||
| 103 | ); |
||
| 104 | } |
||
| 105 | } |
||
| 106 |
