FileManager::getPhpFiles() - Code Metrics - Inspection of "Fixes #42" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

by Bill

created 2017-08-23 04:33 UTC

FileManager::getPhpFiles() A

↳ Parent: FileManager

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.2
c	0
b	0
f	0
cc	4
eloc	10
nc	4
nop	1

<?php declare(strict_types = 1);

namespace Churn\Managers;

use Churn\Collections\FileCollection;
use Churn\Values\Config;
use RecursiveDirectoryIterator;
use RecursiveIteratorIterator;
use Churn\Values\File;

class FileManager
{
    /**
     * FileManager constructor.
     * @param Config $config Configuration Settings.
     */
    public function __construct(Config $config)
    {
        $this->config = $config;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Recursively finds all files with the .php extension in the provided
     * $path and returns list as array.
     * @param  string $path Path to look for .php files.
     * @return FileCollection
     */
    public function getPhpFiles(string $path): FileCollection
    {
        $directoryIterator = new RecursiveDirectoryIterator($path);
        $files = new FileCollection;
        foreach (new RecursiveIteratorIterator($directoryIterator) as $file) {
            if ($file->getExtension() !== 'php') {
                continue;
            }

            if (in_array($file->getPathname(), $this->config->getFilesToIgnore())) {
                continue;
            }

            $files->push(new File(['displayPath' => $file->getPathName(), 'fullPath' => $file->getRealPath()]));
        }

        return $files;
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Churn\Managers;
4
5			use Churn\Collections\FileCollection;
6			use Churn\Values\Config;
7			use RecursiveDirectoryIterator;
8			use RecursiveIteratorIterator;
9			use Churn\Values\File;
10
11			class FileManager
12			{
13			/**
14			* FileManager constructor.
15			* @param Config $config Configuration Settings.
16			*/
17			public function __construct(Config $config)
18			{
19			$this->config = $config;
			0 ignored issues – show Bug introduced 2017-08-23 04:38 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21
22			/**
23			* Recursively finds all files with the .php extension in the provided
24			* $path and returns list as array.
25			* @param string $path Path to look for .php files.
26			* @return FileCollection
27			*/
28			public function getPhpFiles(string $path): FileCollection
29			{
30			$directoryIterator = new RecursiveDirectoryIterator($path);
31			$files = new FileCollection;
32			foreach (new RecursiveIteratorIterator($directoryIterator) as $file) {
33			if ($file->getExtension() !== 'php') {
34			continue;
35			}
36
37			if (in_array($file->getPathname(), $this->config->getFilesToIgnore())) {
38			continue;
39			}
40
41			$files->push(new File(['displayPath' => $file->getPathName(), 'fullPath' => $file->getRealPath()]));
42			}
43
44			return $files;
45			}
46			}
47

bmitch / churn-php

Pull Request — master (#59)

FileManager::getPhpFiles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like