ProcessFactory::createGitCommitProcess() - Code Metrics - Inspection of "Fixes #42" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#59)

by Bill

created 2017-08-23 04:33 UTC

ProcessFactory::createGitCommitProcess() A

↳ Parent: ProcessFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php declare(strict_types = 1);

namespace Churn\Factories;

use Churn\Processes\ChurnProcess;
use Churn\Values\Config;
use Churn\Values\File;
use Symfony\Component\Process\Process;

class ProcessFactory
{
    /**
     * ProcessFactory constructor.
     * @param Config $config Configuration Settings.
     */
    public function __construct(Config $config)
    {
        $this->config = $config;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Creates a Git Commit Process that will run on $file.
     * @param File $file File that the process will execute on.
     * @return ChurnProcess
     */
    public function createGitCommitProcess(File $file): ChurnProcess
    {
        $process = new Process(
            'git -C ' . getcwd() . " log --since=\"" . $this->config->getCommitsSince() . "\"  --name-only --pretty=format: " . $file->getFullPath(). " | sort | uniq -c | sort -nr"
        );

        return new ChurnProcess($file, $process, 'GitCommitProcess');
    }

    /**
     * Creates a Cyclomatic Complexity Process that will run on $file.
     * @param File $file File that the process will execute on.
     * @return ChurnProcess
     */
    public function createCyclomaticComplexityProcess(File $file): ChurnProcess
    {
        $rootFolder = __DIR__ . '/../../';

        $process = new Process(
            "php {$rootFolder}CyclomaticComplexityAssessorRunner {$file->getFullPath()}"
        );

        return new ChurnProcess($file, $process, 'CyclomaticComplexityProcess');
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Churn\Factories;
4
5			use Churn\Processes\ChurnProcess;
6			use Churn\Values\Config;
7			use Churn\Values\File;
8			use Symfony\Component\Process\Process;
9
10			class ProcessFactory
11			{
12			/**
13			* ProcessFactory constructor.
14			* @param Config $config Configuration Settings.
15			*/
16			public function __construct(Config $config)
17			{
18			$this->config = $config;
			0 ignored issues – show Bug introduced 2017-08-23 04:38 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			/**
22			* Creates a Git Commit Process that will run on $file.
23			* @param File $file File that the process will execute on.
24			* @return ChurnProcess
25			*/
26			public function createGitCommitProcess(File $file): ChurnProcess
27			{
28			$process = new Process(
29			'git -C ' . getcwd() . " log --since=\"" . $this->config->getCommitsSince() . "\" --name-only --pretty=format: " . $file->getFullPath(). " \| sort \| uniq -c \| sort -nr"
30			);
31
32			return new ChurnProcess($file, $process, 'GitCommitProcess');
33			}
34
35			/**
36			* Creates a Cyclomatic Complexity Process that will run on $file.
37			* @param File $file File that the process will execute on.
38			* @return ChurnProcess
39			*/
40			public function createCyclomaticComplexityProcess(File $file): ChurnProcess
41			{
42			$rootFolder = __DIR__ . '/../../';
43
44			$process = new Process(
45			"php {$rootFolder}CyclomaticComplexityAssessorRunner {$file->getFullPath()}"
46			);
47
48			return new ChurnProcess($file, $process, 'CyclomaticComplexityProcess');
49			}
50			}
51

bmitch / churn-php

Pull Request — master (#59)

ProcessFactory::createGitCommitProcess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like