ResultsLogic::process() - Code Metrics - Inspection of "Merge pull request #151 from bmitch/refactor" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7195f8...c1e355 )

by Bill

created 2017-10-19 03:08 UTC

ResultsLogic::process() A

↳ Parent: ResultsLogic

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	3

<?php declare(strict_types = 1);

namespace Churn\Logic;

use Churn\Results\ResultsParser;
use Illuminate\Support\Collection;

class ResultsLogic
{
    /**
     * ResultsLogic constructor.
     * @param ResultsParser $parser Results Parser.
     */
    public function __construct(ResultsParser $parser)
    {
        $this->parser = $parser;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Processes the results into a ResultCollection.
     * @param Collection $completedProcesses Collection of completed processes.
     * @param float      $minScore           Minimum score to show.
     * @param integer    $filesToShow        Max number of files to show.
     * @return mixed
     */
    public function process(Collection $completedProcesses, float $minScore, int $filesToShow)
    {
        $resultCollection = $this->parser->parse($completedProcesses);
        $resultCollection = $resultCollection->whereScoreAbove($minScore);
        $resultCollection = $resultCollection->orderByScoreDesc();
        return $resultCollection->take($filesToShow);
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Churn\Logic;
4
5			use Churn\Results\ResultsParser;
6			use Illuminate\Support\Collection;
7
8			class ResultsLogic
9			{
10			/**
11			* ResultsLogic constructor.
12			* @param ResultsParser $parser Results Parser.
13			*/
14			public function __construct(ResultsParser $parser)
15			{
16			$this->parser = $parser;
			0 ignored issues – show Bug introduced 2017-10-19 03:07 UTC by Report Bug Copy Issue Report The property `parser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			}
18
19			/**
20			* Processes the results into a ResultCollection.
21			* @param Collection $completedProcesses Collection of completed processes.
22			* @param float $minScore Minimum score to show.
23			* @param integer $filesToShow Max number of files to show.
24			* @return mixed
25			*/
26			public function process(Collection $completedProcesses, float $minScore, int $filesToShow)
27			{
28			$resultCollection = $this->parser->parse($completedProcesses);
29			$resultCollection = $resultCollection->whereScoreAbove($minScore);
30			$resultCollection = $resultCollection->orderByScoreDesc();
31			return $resultCollection->take($filesToShow);
32			}
33			}
34

bmitch / churn-php

Push — master ( 7195f8...c1e355 )

ResultsLogic::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like