ChurnCommand::displayTable() - Code Metrics - Inspection of "Fixes #8" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by Bill

created 2017-06-14 23:25 UTC

ChurnCommand::displayTable() A

↳ Parent: ChurnCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php declare(strict_types = 1);

namespace Churn\Commands;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputArgument;
use RecursiveDirectoryIterator;
use RecursiveIteratorIterator;
use Churn\Assessors\GitCommitCount\GitCommitCountAssessor;
use Churn\Assessors\CyclomaticComplexity\CyclomaticComplexityAssessor;
use Churn\Services\CommandService;
use Symfony\Component\Console\Helper\Table;
use Illuminate\Support\Collection;
use SplFileInfo;

class ChurnCommand extends Command
{
    /**
     * Class constructor.
     */
    public function __construct()
    {
        parent::__construct();
        $this->commitCountAssessor = new GitCommitCountAssessor(new CommandService);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->complexityAssessor = new CyclomaticComplexityAssessor();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Configure the command
     * @return void
     */
    protected function configure()
    {
        $this->setName('run')
            ->addArgument('path', InputArgument::REQUIRED, 'Path to source to check.')
            ->setDescription('Check files')
            ->setHelp('Checks the churn on the provided path argument(s).');
    }

    /**
     * Exectute the command
     * @param  InputInterface  $input  Input.
     * @param  OutputInterface $output Output.
     * @return void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $path = $input->getArgument('path');

        $directoryIterator = new RecursiveDirectoryIterator($path);

        $results = Collection::make();
        foreach (new RecursiveIteratorIterator($directoryIterator) as $file) {
            if ($file->getExtension() !== 'php') {
                continue;
            }
            $results->push($this->getResults($file));
        }
        $results = $results->sortByDesc('score');
        $this->displayTable($output, $results);
    }

    /**
     * Calculate the results for a file.
     * @param  \SplFileInfo $file File.
     * @return array
     */
    protected function getResults(SplFileInfo $file): array
    {
        $commits    = $this->commitCountAssessor->assess($file->getRealPath());
        $complexity = $this->complexityAssessor->assess($file->getRealPath());

        return [
            'file'       => $file->getRealPath(),
            'commits'    => $commits,
            'complexity' => $complexity,
            'score'      => ($commits/ 10) * ($complexity * 8.75),
        ];
    }

    /**
     * Displays the results in a table.
     * @param  OutputInterface                $output  Output.
     * @param  \Illuminate\Support\Collection $results Results.
     * @return void
     */
    protected function displayTable(OutputInterface $output, Collection $results)
    {
        $table = new Table($output);
        $table->setHeaders(['File', 'Times Changed', 'Complexity', 'Score']);
        foreach ($results as $resultsRow) {
            $table->addRow($resultsRow);
        }
        $table->render();
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Churn\Commands;
4
5			use Symfony\Component\Console\Command\Command;
6			use Symfony\Component\Console\Input\InputInterface;
7			use Symfony\Component\Console\Output\OutputInterface;
8			use Symfony\Component\Console\Input\InputArgument;
9			use RecursiveDirectoryIterator;
10			use RecursiveIteratorIterator;
11			use Churn\Assessors\GitCommitCount\GitCommitCountAssessor;
12			use Churn\Assessors\CyclomaticComplexity\CyclomaticComplexityAssessor;
13			use Churn\Services\CommandService;
14			use Symfony\Component\Console\Helper\Table;
15			use Illuminate\Support\Collection;
16			use SplFileInfo;
17
18			class ChurnCommand extends Command
19			{
20			/**
21			* Class constructor.
22			*/
23			public function __construct()
24			{
25			parent::__construct();
26			$this->commitCountAssessor = new GitCommitCountAssessor(new CommandService);
			0 ignored issues – show Bug introduced 2017-06-14 23:29 UTC by Report Bug Copy Issue Report The property `commitCountAssessor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			$this->complexityAssessor = new CyclomaticComplexityAssessor();
			0 ignored issues – show Bug introduced 2017-06-14 23:29 UTC by Report Bug Copy Issue Report The property `complexityAssessor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			}
29
30			/**
31			* Configure the command
32			* @return void
33			*/
34			protected function configure()
35			{
36			$this->setName('run')
37			->addArgument('path', InputArgument::REQUIRED, 'Path to source to check.')
38			->setDescription('Check files')
39			->setHelp('Checks the churn on the provided path argument(s).');
40			}
41
42			/**
43			* Exectute the command
44			* @param InputInterface $input Input.
45			* @param OutputInterface $output Output.
46			* @return void
47			*/
48			protected function execute(InputInterface $input, OutputInterface $output)
49			{
50			$path = $input->getArgument('path');
51
52			$directoryIterator = new RecursiveDirectoryIterator($path);
53
54			$results = Collection::make();
55			foreach (new RecursiveIteratorIterator($directoryIterator) as $file) {
56			if ($file->getExtension() !== 'php') {
57			continue;
58			}
59			$results->push($this->getResults($file));
60			}
61			$results = $results->sortByDesc('score');
62			$this->displayTable($output, $results);
63			}
64
65			/**
66			* Calculate the results for a file.
67			* @param \SplFileInfo $file File.
68			* @return array
69			*/
70			protected function getResults(SplFileInfo $file): array
71			{
72			$commits = $this->commitCountAssessor->assess($file->getRealPath());
73			$complexity = $this->complexityAssessor->assess($file->getRealPath());
74
75			return [
76			'file' => $file->getRealPath(),
77			'commits' => $commits,
78			'complexity' => $complexity,
79			'score' => ($commits/ 10) * ($complexity * 8.75),
80			];
81			}
82
83			/**
84			* Displays the results in a table.
85			* @param OutputInterface $output Output.
86			* @param \Illuminate\Support\Collection $results Results.
87			* @return void
88			*/
89			protected function displayTable(OutputInterface $output, Collection $results)
90			{
91			$table = new Table($output);
92			$table->setHeaders(['File', 'Times Changed', 'Complexity', 'Score']);
93			foreach ($results as $resultsRow) {
94			$table->addRow($resultsRow);
95			}
96			$table->render();
97			}
98			}
99

bmitch / churn-php

Pull Request — master (#12)

ChurnCommand::displayTable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like