ResultCollection::normalizeAgainst() - Code Metrics - Inspection of "add min score threshold and some tests" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#87)

unknown

created 2017-08-31 03:06 UTC

ResultCollection::normalizeAgainst() A

↳ Parent: ResultCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	1

<?php declare(strict_types = 1);

namespace Churn\Results;

use Illuminate\Support\Collection;
use Churn\Values\Config;

class ResultCollection extends Collection
{
    /**
     * Order results by their score in descending order.
     * @return self
     */
    public function orderByScoreDesc(): self
    {
        return $this->sortByDesc(function (Result $result) {
            return $result->getScore();
        });
    }

    /**
     * Normalize results against config.
     * @param  Config $config
     * @return array
     */
    public function normalizeAgainst(Config $config): array
    {
        $minScore = $config->getMinScoreToShow();

        return array_values(
            $this->orderByScoreDesc()
                ->when($minScore !== 0, $this->filterByMinScore($minScore))
                ->take($config->getFilesToShow())
                ->toArray()
        );
    }

    /**
     * Filter by min score.
     *
     * @param  int      $minScore
     * @return \Closure
     */
    private function filterByMinScore($minScore): \Closure
    {
        return function (ResultCollection $results) use ($minScore) {
            return $results->filter(function (Result $result) use ($minScore) {
                return $result->getScore() >= $minScore;
            });
        };
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Churn\Results;
4
5			use Illuminate\Support\Collection;
6			use Churn\Values\Config;
7
8			class ResultCollection extends Collection
9			{
10			/**
11			* Order results by their score in descending order.
12			* @return self
13			*/
14			public function orderByScoreDesc(): self
15			{
16			return $this->sortByDesc(function (Result $result) {
17			return $result->getScore();
18			});
19			}
20
21			/**
22			* Normalize results against config.
23			* @param Config $config
24			* @return array
25			*/
26			public function normalizeAgainst(Config $config): array
27			{
28			$minScore = $config->getMinScoreToShow();
29
30			return array_values(
31			$this->orderByScoreDesc()
32			->when($minScore !== 0, $this->filterByMinScore($minScore))
33			->take($config->getFilesToShow())
34			->toArray()
35			);
36			}
37
38			/**
39			* Filter by min score.
40			*
41			* @param int $minScore
42			* @return \Closure
43			*/
44			private function filterByMinScore($minScore): \Closure
45			{
46			return function (ResultCollection $results) use ($minScore) {
47			return $results->filter(function (Result $result) use ($minScore) {
48			return $result->getScore() >= $minScore;
49			});
50			};
51			}
52			}
53

bmitch / churn-php

Pull Request — master (#87)

ResultCollection::normalizeAgainst() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like