CyclomaticComplexityAssessor::assess() - Code Metrics - Inspection of "Refactor CyclomaticComplexityAssessor" - bmitch/churn-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#351)

by Fabien

created 2022-03-04 21:27 UTC

CyclomaticComplexityAssessor::assess() A

↳ Parent: CyclomaticComplexityAssessor

Complexity

Conditions	5
Paths	8

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	11
c	0
b	0
f	0
dl	0
loc	20
rs	9.6111
cc	5
nc	8
nop	1

<?php

declare(strict_types=1);

namespace Churn\Assessor;

/**
 * @internal
 */
class CyclomaticComplexityAssessor
{
    /**
     * @var array<int, int>
     */
    private $tokens = [
        \T_CLASS => 1,
        \T_INTERFACE => 1,
        \T_TRAIT => 1,
        \T_IF => 1,
        \T_ELSEIF => 1,
        \T_FOR => 1,
        \T_FOREACH => 1,
        \T_WHILE => 1,
        \T_CASE => 1,
        \T_CATCH => 1,
        \T_BOOLEAN_AND => 1,
        \T_LOGICAL_AND => 1,
        \T_BOOLEAN_OR => 1,
        \T_LOGICAL_OR => 1,
        \T_COALESCE => 1,
    ];

    /**
     * Class constructor.
     */
    public function __construct()
    {
        $this->init();
    }

    /**
     * Assess the files cyclomatic complexity.
     *
     * @param string $contents The contents of a PHP file.
     */
    public function assess(string $contents): int
    {
        $tokens = \token_get_all($contents);
        $score = 0;
        foreach ($tokens as $token) {
            if (\is_array($token)) {
                $score += $this->getComplexity($token[0]);

                continue;
            }
            if ('?' !== $token) {
                continue;
            }

            $score += 1;
        }

        return 0 === $score

            ? 1
            : $score;
    }

    /**
     * Add missing tokens depending on the PHP version.
     */
    private function init(): void
    {
        $tokens = [
            // Since PHP 7.4
            'T_COALESCE_EQUAL',
            // Since PHP 8.1
            'T_ENUM',
        ];
        foreach ($tokens as $token) {
            if (!\defined($token)) {
                continue;
            }

            $this->tokens[(int) \constant($token)] = 1;
        }
    }

    /**
     * @param integer $code Code of a PHP token.
     */
    private function getComplexity(int $code): int
    {
        return $this->tokens[$code] ?? 0;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Churn\Assessor;
6
7			/**
8			* @internal
9			*/
10			class CyclomaticComplexityAssessor
11			{
12			/**
13			* @var array<int, int>
14			*/
15			private $tokens = [
16			\T_CLASS => 1,
17			\T_INTERFACE => 1,
18			\T_TRAIT => 1,
19			\T_IF => 1,
20			\T_ELSEIF => 1,
21			\T_FOR => 1,
22			\T_FOREACH => 1,
23			\T_WHILE => 1,
24			\T_CASE => 1,
25			\T_CATCH => 1,
26			\T_BOOLEAN_AND => 1,
27			\T_LOGICAL_AND => 1,
28			\T_BOOLEAN_OR => 1,
29			\T_LOGICAL_OR => 1,
30			\T_COALESCE => 1,
31			];
32
33			/**
34			* Class constructor.
35			*/
36			public function __construct()
37			{
38			$this->init();
39			}
40
41			/**
42			* Assess the files cyclomatic complexity.
43			*
44			* @param string $contents The contents of a PHP file.
45			*/
46			public function assess(string $contents): int
47			{
48			$tokens = \token_get_all($contents);
49			$score = 0;
50			foreach ($tokens as $token) {
51			if (\is_array($token)) {
52			$score += $this->getComplexity($token[0]);
53
54			continue;
55			}
56			if ('?' !== $token) {
57			continue;
58			}
59
60			$score += 1;
61			}
62
63			return 0 === $score
			0 ignored issues – show introduced 2022-03-04 21:29 UTC by Report Bug Copy Issue Report The condition `0 === $score` is always `true`. Loading history...
64			? 1
65			: $score;
66			}
67
68			/**
69			* Add missing tokens depending on the PHP version.
70			*/
71			private function init(): void
72			{
73			$tokens = [
74			// Since PHP 7.4
75			'T_COALESCE_EQUAL',
76			// Since PHP 8.1
77			'T_ENUM',
78			];
79			foreach ($tokens as $token) {
80			if (!\defined($token)) {
81			continue;
82			}
83
84			$this->tokens[(int) \constant($token)] = 1;
85			}
86			}
87
88			/**
89			* @param integer $code Code of a PHP token.
90			*/
91			private function getComplexity(int $code): int
92			{
93			return $this->tokens[$code] ?? 0;
94			}
95			}
96

bmitch / churn-php

Pull Request — master (#351)

CyclomaticComplexityAssessor::assess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like