ConstructorLoopSniff::process() - Code Metrics - Inspection of "Merge pull request #87 from bmitch/bmitchell-#86" - bmitch/Codor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a71fff...d60187 )

by Bill

created 2017-06-01 21:53 UTC

ConstructorLoopSniff::process() B

↳ Parent: ConstructorLoopSniff

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.6737
c	0
b	0
f	0
cc	5
eloc	13
nc	5
nop	2

<?php declare(strict_types = 1);

namespace Codor\Sniffs\Classes;

use PHP_CodeSniffer_Sniff;
use PHP_CodeSniffer_File;

class ConstructorLoopSniff implements PHP_CodeSniffer_Sniff
{

    /**
     * The loop tokens we're lookin for.
     * @var array
     */
    protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];

    /**
     * Returns the token types that this sniff is interested in.
     * @return array
     */
    public function register(): array
    {
        return [T_FUNCTION];
    }

    /**
     * Processes the tokens that this sniff is interested in.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
     * @param int                  $stackPtr  The position in the stack where
     *                                        the token was found.
     * @return void
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $tokens            = $phpcsFile->getTokens();
        $token             = $tokens[$stackPtr];
        $functionNameToken = $tokens[$stackPtr + 2];
        $functionName      = $functionNameToken['content'];

        if ($functionName !== '__construct') {
            return;
        }
        // If this is an interface we don't check it.
        if (! isset($token['scope_opener'])) {
            return;
        }

        for ($index=$token['scope_opener']; $index <= $token['scope_closer']; $index++) {
            if (in_array($tokens[$index]['type'], $this->loops)) {
                $phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr);
                continue;
            }
        }
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Codor\Sniffs\Classes;
4
5			use PHP_CodeSniffer_Sniff;
6			use PHP_CodeSniffer_File;
7
8			class ConstructorLoopSniff implements PHP_CodeSniffer_Sniff
9			{
10
11			/**
12			* The loop tokens we're lookin for.
13			* @var array
14			*/
15			protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];
16
17			/**
18			* Returns the token types that this sniff is interested in.
19			* @return array
20			*/
21			public function register(): array
22			{
23			return [T_FUNCTION];
24			}
25
26			/**
27			* Processes the tokens that this sniff is interested in.
28			*
29			* @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
30			* @param int $stackPtr The position in the stack where
31			* the token was found.
32			* @return void
33			*/
34			public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
35			{
36			$tokens = $phpcsFile->getTokens();
37			$token = $tokens[$stackPtr];
38			$functionNameToken = $tokens[$stackPtr + 2];
39			$functionName = $functionNameToken['content'];
40
41			if ($functionName !== '__construct') {
42			return;
43			}
44			// If this is an interface we don't check it.
45			if (! isset($token['scope_opener'])) {
46			return;
47			}
48
49			for ($index=$token['scope_opener']; $index <= $token['scope_closer']; $index++) {
50			if (in_array($tokens[$index]['type'], $this->loops)) {
51			$phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr);
52			continue;
53			}
54			}
55			}
56			}
57

bmitch / Codor

Push — master ( a71fff...d60187 )

ConstructorLoopSniff::process() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like