ConstructorLoopSniff::process() - Code Metrics - Inspection of "Merge pull request #83 from bmitch/bmitchell-#71" - bmitch/Codor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5e9323...97dbcd )

by Bill

created 2017-05-30 23:14 UTC

ConstructorLoopSniff::process() A

↳ Parent: ConstructorLoopSniff

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.2
c	0
b	0
f	0
cc	4
eloc	13
nc	4
nop	2

<?php declare(strict_types = 1);

namespace Codor\Sniffs\Classes;

use PHP_CodeSniffer_Sniff;
use PHP_CodeSniffer_File;

class ConstructorLoopSniff implements PHP_CodeSniffer_Sniff
{

    /**
     * The loop tokens we're lookin for.
     * @var array
     */
    protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];

    /**
     * Returns the token types that this sniff is interested in.
     * @return array
     */
    public function register(): array
    {
        return [T_FUNCTION];
    }

    /**
     * Processes the tokens that this sniff is interested in.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
     * @param int                  $stackPtr  The position in the stack where
     *                                        the token was found.
     * @return void
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $tokens            = $phpcsFile->getTokens();
        $token             = $tokens[$stackPtr];
        $functionNameToken = $tokens[$stackPtr + 2];
        $functionName      = $functionNameToken['content'];
        if ($functionName !== '__construct') {
            return;
        }

        $startIndex   = $token['scope_opener'];
        $endIndex = $token['scope_closer'];

        for ($index=$startIndex; $index <= $endIndex; $index++) {
            if (in_array($tokens[$index]['type'], $this->loops)) {
                $phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr);
                continue;
            }
        }
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Codor\Sniffs\Classes;
4
5			use PHP_CodeSniffer_Sniff;
6			use PHP_CodeSniffer_File;
7
8			class ConstructorLoopSniff implements PHP_CodeSniffer_Sniff
9			{
10
11			/**
12			* The loop tokens we're lookin for.
13			* @var array
14			*/
15			protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];
16
17			/**
18			* Returns the token types that this sniff is interested in.
19			* @return array
20			*/
21			public function register(): array
22			{
23			return [T_FUNCTION];
24			}
25
26			/**
27			* Processes the tokens that this sniff is interested in.
28			*
29			* @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
30			* @param int $stackPtr The position in the stack where
31			* the token was found.
32			* @return void
33			*/
34			public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
35			{
36			$tokens = $phpcsFile->getTokens();
37			$token = $tokens[$stackPtr];
38			$functionNameToken = $tokens[$stackPtr + 2];
39			$functionName = $functionNameToken['content'];
40			if ($functionName !== '__construct') {
41			return;
42			}
43
44			$startIndex = $token['scope_opener'];
45			$endIndex = $token['scope_closer'];
46
47			for ($index=$startIndex; $index <= $endIndex; $index++) {
48			if (in_array($tokens[$index]['type'], $this->loops)) {
49			$phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr);
50			continue;
51			}
52			}
53			}
54			}
55

bmitch / Codor

Push — master ( 5e9323...97dbcd )

ConstructorLoopSniff::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like