ClassLengthSniff::process() - Code Metrics - Inspection of "Fixes #22" - bmitch/Codor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Bill

created 2016-12-06 23:07 UTC

ClassLengthSniff::process() A

↳ Parent: ClassLengthSniff

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	2

<?php

namespace Codor\Sniffs\Classes;

use PHP_CodeSniffer_Sniff;
use PHP_CodeSniffer_File;

class ClassLengthSniff implements PHP_CodeSniffer_Sniff
{

    /**
     * The maximum number of lines a class
     * should have.
     * @var integer
     */
    protected $maxLength = 200;

    /**
     * Returns the token types that this sniff is interested in.
     * @return array
     */
    public function register()
    {
        return [T_CLASS];
    }

    /**
     * Processes the tokens that this sniff is interested in.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
     * @param integer              $stackPtr  The position in the stack where
     *                                    the token was found.
     * @return void
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $tokens = $phpcsFile->getTokens();
        $token = $tokens[$stackPtr];
        
        $openParenthesis = $tokens[$token['scope_opener']];
        $closedParenthesis = $tokens[$token['scope_closer']];

        $classLength = $closedParenthesis['line'] - $openParenthesis['line'];

        if ($classLength > $this->maxLength) {
            $phpcsFile->addError("Class is {$classLength} lines. Must be {$this->maxLength} lines or fewer.", $stackPtr);
        }
    }
}


1			<?php
2
3			namespace Codor\Sniffs\Classes;
4
5			use PHP_CodeSniffer_Sniff;
6			use PHP_CodeSniffer_File;
7
8			class ClassLengthSniff implements PHP_CodeSniffer_Sniff
9			{
10
11			/**
12			* The maximum number of lines a class
13			* should have.
14			* @var integer
15			*/
16			protected $maxLength = 200;
17
18			/**
19			* Returns the token types that this sniff is interested in.
20			* @return array
21			*/
22			public function register()
23			{
24			return [T_CLASS];
25			}
26
27			/**
28			* Processes the tokens that this sniff is interested in.
29			*
30			* @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
31			* @param integer $stackPtr The position in the stack where
32			* the token was found.
33			* @return void
34			*/
35			public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
36			{
37			$tokens = $phpcsFile->getTokens();
38			$token = $tokens[$stackPtr];
39
40			$openParenthesis = $tokens[$token['scope_opener']];
41			$closedParenthesis = $tokens[$token['scope_closer']];
42
43			$classLength = $closedParenthesis['line'] - $openParenthesis['line'];
44
45			if ($classLength > $this->maxLength) {
46			$phpcsFile->addError("Class is {$classLength} lines. Must be {$this->maxLength} lines or fewer.", $stackPtr);
47			}
48			}
49			}
50

bmitch / Codor

Pull Request — master (#30)

ClassLengthSniff::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like