LinesAfterMethodSniff::process() - Code Metrics - Inspection of "Merge pull request #79 from bmitch/bmitchell-#76" - bmitch/Codor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b735aa...4d9fca )

by Bill

created 2017-04-10 22:15 UTC

LinesAfterMethodSniff::process() B

↳ Parent: LinesAfterMethodSniff

Complexity

Conditions	4
Paths	6

Size

Total Lines	22
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.9197
c	0
b	0
f	0
cc	4
eloc	14
nc	6
nop	2

<?php declare(strict_types = 1);

namespace Codor\Sniffs\Syntax;

use PHP_CodeSniffer_Sniff;
use PHP_CodeSniffer_File;

class LinesAfterMethodSniff implements PHP_CodeSniffer_Sniff
{

    /**
     * Returns the token types that this sniff is interested in.
     * @return array
     */
    public function register(): array
    {
        return [T_FUNCTION];
    }

    /**
     * Processes the tokens that this sniff is interested in.
     * @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
     * @param integer              $stackPtr  The position in the stack where
     *                                    the token was found.
     * @return void
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $tokens           = $phpcsFile->getTokens();
        $endOfMethodIndex = $tokens[$stackPtr]['scope_closer'];
        $endOfMethodLine  = $tokens[$endOfMethodIndex]['line'];

        $nextCodeLine = 0;
        for ($index=$endOfMethodIndex + 1; $index <= count($tokens); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $currentToken = $tokens[$index];
            if ($currentToken['type'] == 'T_WHITESPACE') {
                continue;
            }
            $nextCodeLine = $currentToken['line'];
            break;
        }

        $linesBetween = $nextCodeLine - $endOfMethodLine - 1;

        if ($linesBetween > 1) {
            $phpcsFile->addError("No more than 1 line after a method/function is allowed.", $stackPtr);
        }
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Codor\Sniffs\Syntax;
4
5			use PHP_CodeSniffer_Sniff;
6			use PHP_CodeSniffer_File;
7
8			class LinesAfterMethodSniff implements PHP_CodeSniffer_Sniff
9			{
10
11			/**
12			* Returns the token types that this sniff is interested in.
13			* @return array
14			*/
15			public function register(): array
16			{
17			return [T_FUNCTION];
18			}
19
20			/**
21			* Processes the tokens that this sniff is interested in.
22			* @param PHP_CodeSniffer_File $phpcsFile The file where the token was found.
23			* @param integer $stackPtr The position in the stack where
24			* the token was found.
25			* @return void
26			*/
27			public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
28			{
29			$tokens = $phpcsFile->getTokens();
30			$endOfMethodIndex = $tokens[$stackPtr]['scope_closer'];
31			$endOfMethodLine = $tokens[$endOfMethodIndex]['line'];
32
33			$nextCodeLine = 0;
34			for ($index=$endOfMethodIndex + 1; $index <= count($tokens); $index++) {
			0 ignored issues – show Performance Best Practice introduced 2017-04-10 22:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
35			$currentToken = $tokens[$index];
36			if ($currentToken['type'] == 'T_WHITESPACE') {
37			continue;
38			}
39			$nextCodeLine = $currentToken['line'];
40			break;
41			}
42
43			$linesBetween = $nextCodeLine - $endOfMethodLine - 1;
44
45			if ($linesBetween > 1) {
46			$phpcsFile->addError("No more than 1 line after a method/function is allowed.", $stackPtr);
47			}
48			}
49			}
50

bmitch / Codor

Push — master ( b735aa...4d9fca )

LinesAfterMethodSniff::process() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like