Application\Users\Crud::createOne()

Complexity

Conditions	7
Paths	48

Size

Total Lines	80
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	6
Bugs	1	Features	0

<?php
    public function createOne($data)
    {
        // password
        $password = isset($data['password']) ? $data['password'] : null;
        $password2 = isset($data['password2']) ? $data['password2'] : null;

        if (empty($password)) {
            throw ValidatorException::exception('password', __('Password can\'t be empty'));
        }

        if ($password !== $password2) {
            throw ValidatorException::exception('password2', __('Password is not equal'));
        }

        if ($data['id'] == '') {
            unset($data['id']);
        }

        /** @var $row Row */
        $row = $this->getTable()->create();
        $row->setFromArray($data);
        $row->status = Table::STATUS_PENDING;
        $row->save();

        $userId = $row->id;

        // create auth
        Auth\Table::getInstance()->generateEquals($row, $password);

        // create activation token
        // valid for 5 days
        $actionRow = UsersActions\Table::getInstance()->generate($userId, UsersActions\Table::ACTION_ACTIVATION, 5);

        // send activation email
        // generate activation URL
        $activationUrl = Router::getFullUrl(
            'users',
            'activation',
            ['code' => $actionRow->code, 'id' => $userId]
        );

        $subject = "Activation";

        $body = Application::getInstance()->dispatch(
            'users',
            'mail/template',
            [
                'template' => 'registration',
                'vars' => ['user' => $row, 'activationUrl' => $activationUrl, 'password' => $password]
            ]
        )->render();

        try {
            $mail = Mailer::create();
            $mail->Subject = $subject;
            $mail->msgHTML(nl2br($body));
            $mail->addAddress($data['email']);
            Mailer::send($mail);
        } catch (\Exception $e) {
            Logger::log(
                'error',
                $e->getMessage(),
                ['module' => 'users', 'controller' => 'change-email', 'userId' => $userId]
            );

            throw new Exception('Unable to send email. Please contact administrator.');
        }

        // show notification and redirect
        Messages::addSuccess(

The call to addSuccess() misses a required argument $...$text.

            "Your account has been created and an activation link has" .
            "been sent to the e-mail address you entered.<br/>" .
            "Note that you must activate the account by clicking on the activation link" .
            "when you get the e-mail before you can login."
        );
        // wtf?
        // redirectTo('index', 'index');

67% of this comment could be valid code. Did you maybe forget this after debugging?

        return $userId;
    }
}