Table::getImages() - Code Metrics - Inspection of "Merge pull request #259 from AntonShevchuk/master" - bluzphp/skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 503636...a81f54 )

by Anton

created 2016-10-03 15:04 UTC

Table::getImages() A

↳ Parent: Table

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
ccs	3
cts	3
cp	1
crap	2

<?php
/**
 * @copyright Bluz PHP Team
 * @link https://github.com/bluzphp/skeleton
 */

/**
 * @namespace
 */
namespace Application\Media;

use Application\Exception;
use Bluz\Proxy\Auth;

/**
 * Table
 *
 * @package  Application\Media
 *
 * @method   static Row findRow($primaryKey)
 * @method   static Row findRowWhere($whereList)
 */
class Table extends \Bluz\Db\Table
{
    /**
     * Table
     *
     * @var string
     */
    protected $table = 'media';

    /**
     * Primary key(s)
     * @var array
     */
    protected $primary = array('id');

    /**
     * Get images of current user
     *
     * @return Row[]
     * @throws Exception
     */
    public function getImages()
    {
        /** @var Row $user */
        if (!$user = Auth::getIdentity()) {
            throw new Exception('User not found');
        }

        return $this->getImagesByUserId($user->id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Get images by owner
     *
     * @param  integer $id
     * @return Row[]
     */
    public function getImagesByUserId($id)
    {
        return self::select()
            ->where('type LIKE (?)', 'image/%')
            ->andWhere('userId = ?', $id)
            ->execute();
    }
}


1		<?php
2		/**
3		* @copyright Bluz PHP Team
4		* @link https://github.com/bluzphp/skeleton
5		*/
6
7		/**
8		* @namespace
9		*/
10		namespace Application\Media;
11
12		use Application\Exception;
13		use Bluz\Proxy\Auth;
14
15		/**
16		* Table
17		*
18		* @package Application\Media
19		*
20		* @method static Row findRow($primaryKey)
21		* @method static Row findRowWhere($whereList)
22		*/
23		class Table extends \Bluz\Db\Table
24		{
25		/**
26		* Table
27		*
28		* @var string
29		*/
30		protected $table = 'media';
31
32		/**
33		* Primary key(s)
34		* @var array
35		*/
36		protected $primary = array('id');
37
38		/**
39		* Get images of current user
40		*
41		* @return Row[]
42		* @throws Exception
43		*/
44	1	public function getImages()
45		{
46		/** @var Row $user */
47	1	if (!$user = Auth::getIdentity()) {
48		throw new Exception('User not found');
49		}
50
51	1	return $this->getImagesByUserId($user->id);
		0 ignored issues – show Bug introduced 2016-09-06 14:23 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Bluz\Auth\EntityInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
52		}
53
54		/**
55		* Get images by owner
56		*
57		* @param integer $id
58		* @return Row[]
59		*/
60	1	public function getImagesByUserId($id)
61		{
62	1	return self::select()
63	1	->where('type LIKE (?)', 'image/%')
64	1	->andWhere('userId = ?', $id)
65	1	->execute();
66		}
67		}
68

bluzphp / skeleton

Push — master ( 503636...a81f54 )

Table::getImages() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like