Acl::change() - Code Metrics - Inspection of "Refactoring phinx migrations" - bluzphp/skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#280)

by Anton

created 2017-03-17 17:37 UTC

Acl::change() B

↳ Parent: Acl

Complexity

Conditions	1
Paths	1

Size

Total Lines	141
Code Lines	87

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	87
nc	1
nop	0
dl	0
loc	141
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php

use Phinx\Migration\AbstractMigration;

class Acl extends AbstractMigration
namespace YourVendor;

class YourClass { }
{
    /**
     * Change Method.
     *
     * Write your reversible migrations using this method.
     *
     * More information on writing migrations is available here:
     * http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class
     *
     * The following commands can be used in this method and Phinx will
     * automatically reverse them when rolling back:
     *
     *    createTable
     *    renameTable
     *    addColumn
     *    renameColumn
     *    addIndex
     *    addForeignKey
     *
     * Remember to call "create()" or "update()" and NOT "save()" when working
     * with the Table class.
     */
    public function change()
    {
        $roles = $this->table('acl_roles', ['primary_key' => ['id', 'code']]);
        $roles
            ->addColumn('name', 'string', ['length'=>255])
            ->addColumn('created', 'timestamp', ['default' => 'CURRENT_TIMESTAMP', 'update' => ''])
            ->addIndex(['name'], ['unique' => true])
            ->create();

        $privileges = $this->table('acl_privileges', ['primary_key' => ['roleId', 'module', 'privilege']]);
        $privileges
            ->addColumn('roleId', 'integer')
            ->addColumn('module', 'string', ['length'=>32])
            ->addColumn('privilege', 'string', ['length'=>32])
            ->addForeignKey('roleId', $roles, 'id', [
                'delete' => 'CASCADE',
                'update' => 'CASCADE'
            ])
            ->create();

        $usersRoles = $this->table('acl_users_roles', ['id' => false, 'primary_key' => ['userId', 'roleId']]);
        $usersRoles
            ->addColumn('userId', 'integer')
            ->addColumn('roleId', 'integer')
            ->addForeignKey('userId', 'users', 'id', [
                'delete' => 'CASCADE',
                'update' => 'CASCADE'
            ])
            ->addForeignKey('roleId', $roles, 'id', [
                'delete' => 'CASCADE',
                'update' => 'CASCADE'
            ])
            ->create();


        $roles = [
            [
                'id' => 1,
                'name' => 'system'
            ],
            [
                'id' => 2,
                'name' => 'admin'
            ],
            [
                'id' => 3,
                'name' => 'member'
            ],
            [
                'id' => 4,
                'name' => 'guest'
            ],
        ];
        $this->table('acl_roles')->insert($roles)->save();

        $privileges = [
            [
                'roleId' => 2,
                'module' => 'acl',
                'privilege' => 'Management'
            ],
            [
                'roleId' => 2,
                'module' => 'acl',
                'privilege' => 'View'
            ],
            [
                'roleId' => 2,
                'module' => 'cache',
                'privilege' => 'Management'
            ],
            [
                'roleId' => 2,
                'module' => 'dashboard',
                'privilege' => 'Dashboard'
            ],
            [
                'roleId' => 2,
                'module' => 'pages',
                'privilege' => 'Management'
            ],
            [
                'roleId' => 2,
                'module' => 'system',
                'privilege' => 'Info'
            ],
            [
                'roleId' => 2,
                'module' => 'users',
                'privilege' => 'EditEmail'
            ],
            [
                'roleId' => 2,
                'module' => 'users',
                'privilege' => 'EditPassword'
            ],
            [
                'roleId' => 2,
                'module' => 'users',
                'privilege' => 'Management'
            ],
            [
                'roleId' => 2,
                'module' => 'users',
                'privilege' => 'ViewProfile'
            ],
            [
                'roleId' => 3,
                'module' => 'users',
                'privilege' => 'EditEmail'
            ],
            [
                'roleId' => 3,
                'module' => 'users',
                'privilege' => 'EditPassword'
            ],
            [
                'roleId' => 3,
                'module' => 'users',
                'privilege' => 'Management'
            ],
            [
                'roleId' => 3,
                'module' => 'users',
                'privilege' => 'ViewProfile'
            ],
        ];
        $this->table('acl_privileges')->insert($privileges)->save();

        $usersRoles = [
            [
                'userId' => 1,
                'roleId' => 1
            ],
            [
                'userId' => 2,
                'roleId' => 2
            ],
        ];
        $this->table('acl_users_roles')->insert($usersRoles)->save();
    }
}


1			<?php
2
3			use Phinx\Migration\AbstractMigration;
4
5			class Acl extends AbstractMigration
			0 ignored issues – show Coding Style Compatibility introduced 2017-03-17 17:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			/**
8			* Change Method.
9			*
10			* Write your reversible migrations using this method.
11			*
12			* More information on writing migrations is available here:
13			* http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class
14			*
15			* The following commands can be used in this method and Phinx will
16			* automatically reverse them when rolling back:
17			*
18			* createTable
19			* renameTable
20			* addColumn
21			* renameColumn
22			* addIndex
23			* addForeignKey
24			*
25			* Remember to call "create()" or "update()" and NOT "save()" when working
26			* with the Table class.
27			*/
28			public function change()
29			{
30			$roles = $this->table('acl_roles', ['primary_key' => ['id', 'code']]);
31			$roles
32			->addColumn('name', 'string', ['length'=>255])
33			->addColumn('created', 'timestamp', ['default' => 'CURRENT_TIMESTAMP', 'update' => ''])
34			->addIndex(['name'], ['unique' => true])
35			->create();
36
37			$privileges = $this->table('acl_privileges', ['primary_key' => ['roleId', 'module', 'privilege']]);
38			$privileges
39			->addColumn('roleId', 'integer')
40			->addColumn('module', 'string', ['length'=>32])
41			->addColumn('privilege', 'string', ['length'=>32])
42			->addForeignKey('roleId', $roles, 'id', [
43			'delete' => 'CASCADE',
44			'update' => 'CASCADE'
45			])
46			->create();
47
48			$usersRoles = $this->table('acl_users_roles', ['id' => false, 'primary_key' => ['userId', 'roleId']]);
49			$usersRoles
50			->addColumn('userId', 'integer')
51			->addColumn('roleId', 'integer')
52			->addForeignKey('userId', 'users', 'id', [
53			'delete' => 'CASCADE',
54			'update' => 'CASCADE'
55			])
56			->addForeignKey('roleId', $roles, 'id', [
57			'delete' => 'CASCADE',
58			'update' => 'CASCADE'
59			])
60			->create();
61
62
63			$roles = [
64			[
65			'id' => 1,
66			'name' => 'system'
67			],
68			[
69			'id' => 2,
70			'name' => 'admin'
71			],
72			[
73			'id' => 3,
74			'name' => 'member'
75			],
76			[
77			'id' => 4,
78			'name' => 'guest'
79			],
80			];
81			$this->table('acl_roles')->insert($roles)->save();
82
83			$privileges = [
84			[
85			'roleId' => 2,
86			'module' => 'acl',
87			'privilege' => 'Management'
88			],
89			[
90			'roleId' => 2,
91			'module' => 'acl',
92			'privilege' => 'View'
93			],
94			[
95			'roleId' => 2,
96			'module' => 'cache',
97			'privilege' => 'Management'
98			],
99			[
100			'roleId' => 2,
101			'module' => 'dashboard',
102			'privilege' => 'Dashboard'
103			],
104			[
105			'roleId' => 2,
106			'module' => 'pages',
107			'privilege' => 'Management'
108			],
109			[
110			'roleId' => 2,
111			'module' => 'system',
112			'privilege' => 'Info'
113			],
114			[
115			'roleId' => 2,
116			'module' => 'users',
117			'privilege' => 'EditEmail'
118			],
119			[
120			'roleId' => 2,
121			'module' => 'users',
122			'privilege' => 'EditPassword'
123			],
124			[
125			'roleId' => 2,
126			'module' => 'users',
127			'privilege' => 'Management'
128			],
129			[
130			'roleId' => 2,
131			'module' => 'users',
132			'privilege' => 'ViewProfile'
133			],
134			[
135			'roleId' => 3,
136			'module' => 'users',
137			'privilege' => 'EditEmail'
138			],
139			[
140			'roleId' => 3,
141			'module' => 'users',
142			'privilege' => 'EditPassword'
143			],
144			[
145			'roleId' => 3,
146			'module' => 'users',
147			'privilege' => 'Management'
148			],
149			[
150			'roleId' => 3,
151			'module' => 'users',
152			'privilege' => 'ViewProfile'
153			],
154			];
155			$this->table('acl_privileges')->insert($privileges)->save();
156
157			$usersRoles = [
158			[
159			'userId' => 1,
160			'roleId' => 1
161			],
162			[
163			'userId' => 2,
164			'roleId' => 2
165			],
166			];
167			$this->table('acl_users_roles')->insert($usersRoles)->save();
168			}
169			}
170

bluzphp / skeleton

Pull Request — master (#280)

Acl::change() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like