Complex classes like Router often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Router, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 27 | class Router |
||
| 28 | { |
||
| 29 | use Options; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Or should be as properties? |
||
| 33 | */ |
||
| 34 | const DEFAULT_MODULE = 'index'; |
||
| 35 | const DEFAULT_CONTROLLER = 'index'; |
||
| 36 | const ERROR_MODULE = 'error'; |
||
| 37 | const ERROR_CONTROLLER = 'index'; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var string base URL |
||
| 41 | */ |
||
| 42 | protected $baseUrl; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string REQUEST_URI minus Base URL |
||
| 46 | */ |
||
| 47 | protected $cleanUri; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var string default module |
||
| 51 | */ |
||
| 52 | protected $defaultModule = self::DEFAULT_MODULE; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var string default Controller |
||
| 56 | */ |
||
| 57 | protected $defaultController = self::DEFAULT_CONTROLLER; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @var string error module |
||
| 61 | */ |
||
| 62 | protected $errorModule = self::ERROR_MODULE; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @var string error Controller |
||
| 66 | */ |
||
| 67 | protected $errorController = self::ERROR_CONTROLLER; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var array instance parameters |
||
| 71 | */ |
||
| 72 | protected $params = array(); |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @var array instance raw parameters |
||
| 76 | */ |
||
| 77 | protected $rawParams = array(); |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @var array routers map |
||
| 81 | */ |
||
| 82 | protected $routers = array(); |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @var array reverse map |
||
| 86 | */ |
||
| 87 | protected $reverse = array(); |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Constructor of Router |
||
| 91 | */ |
||
| 92 | 630 | public function __construct() |
|
| 143 | |||
| 144 | /** |
||
| 145 | * Get the base URL. |
||
| 146 | * |
||
| 147 | * @return string |
||
| 148 | */ |
||
| 149 | 36 | public function getBaseUrl() |
|
| 153 | |||
| 154 | /** |
||
| 155 | * Set the base URL. |
||
| 156 | * |
||
| 157 | * @param string $baseUrl |
||
| 158 | * @return void |
||
| 159 | */ |
||
| 160 | 630 | public function setBaseUrl($baseUrl) |
|
| 164 | |||
| 165 | /** |
||
| 166 | * Get an action parameter |
||
| 167 | * |
||
| 168 | * @param string $key |
||
| 169 | * @param mixed $default Default value to use if key not found |
||
| 170 | * @return mixed |
||
| 171 | */ |
||
| 172 | public function getParam($key, $default = null) |
||
| 176 | |||
| 177 | /** |
||
| 178 | * Set an action parameter |
||
| 179 | * |
||
| 180 | * A $value of null will unset the $key if it exists |
||
| 181 | * |
||
| 182 | * @param string $key |
||
| 183 | * @param mixed $value |
||
| 184 | * @return void |
||
| 185 | */ |
||
| 186 | 1 | public function setParam($key, $value) |
|
| 196 | |||
| 197 | /** |
||
| 198 | * Get parameters |
||
| 199 | * |
||
| 200 | * @return array |
||
| 201 | */ |
||
| 202 | public function getParams() |
||
| 206 | |||
| 207 | /** |
||
| 208 | * Get raw params, w/out module and controller |
||
| 209 | * |
||
| 210 | * @return array |
||
| 211 | */ |
||
| 212 | public function getRawParams() |
||
| 216 | |||
| 217 | /** |
||
| 218 | * Get default module |
||
| 219 | * |
||
| 220 | * @return string |
||
| 221 | */ |
||
| 222 | 630 | public function getDefaultModule() |
|
| 226 | |||
| 227 | /** |
||
| 228 | * Set default module |
||
| 229 | * |
||
| 230 | * @param string $defaultModule |
||
| 231 | * @return void |
||
| 232 | */ |
||
| 233 | public function setDefaultModule($defaultModule) |
||
| 237 | |||
| 238 | /** |
||
| 239 | * Get default controller |
||
| 240 | * |
||
| 241 | * @return string |
||
| 242 | */ |
||
| 243 | 630 | public function getDefaultController() |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Set default controller |
||
| 250 | * |
||
| 251 | * @param string $defaultController |
||
| 252 | * @return void |
||
| 253 | */ |
||
| 254 | public function setDefaultController($defaultController) |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Get error module |
||
| 261 | * |
||
| 262 | * @return string |
||
| 263 | */ |
||
| 264 | 1 | public function getErrorModule() |
|
| 268 | |||
| 269 | /** |
||
| 270 | * Set error module |
||
| 271 | * |
||
| 272 | * @param string $errorModule |
||
| 273 | * @return void |
||
| 274 | */ |
||
| 275 | public function setErrorModule($errorModule) |
||
| 279 | |||
| 280 | /** |
||
| 281 | * Get error controller |
||
| 282 | * |
||
| 283 | * @return string |
||
| 284 | */ |
||
| 285 | 1 | public function getErrorController() |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Set error controller |
||
| 292 | * |
||
| 293 | * @param string $errorController |
||
| 294 | * @return void |
||
| 295 | */ |
||
| 296 | public function setErrorController($errorController) |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Build URL to controller |
||
| 303 | * |
||
| 304 | * @param string $module |
||
| 305 | * @param string $controller |
||
| 306 | * @param array $params |
||
| 307 | * @return string |
||
| 308 | */ |
||
| 309 | 30 | public function getUrl($module = self::DEFAULT_MODULE, $controller = self::DEFAULT_CONTROLLER, $params = array()) |
|
| 328 | |||
| 329 | /** |
||
| 330 | * Build full URL to controller |
||
| 331 | * |
||
| 332 | * @param string $module |
||
| 333 | * @param string $controller |
||
| 334 | * @param array $params |
||
| 335 | * @return string |
||
| 336 | */ |
||
| 337 | 1 | public function getFullUrl( |
|
| 347 | |||
| 348 | /** |
||
| 349 | * Build URL by custom route |
||
| 350 | * |
||
| 351 | * @param string $module |
||
| 352 | * @param string $controller |
||
| 353 | * @param array $params |
||
| 354 | * @return string |
||
| 355 | */ |
||
| 356 | 5 | protected function urlCustom($module, $controller, $params) |
|
| 385 | |||
| 386 | /** |
||
| 387 | * Build URL by default route |
||
| 388 | * |
||
| 389 | * @param string $module |
||
| 390 | * @param string $controller |
||
| 391 | * @param array $params |
||
| 392 | * @return string |
||
| 393 | */ |
||
| 394 | 25 | protected function urlRoute($module, $controller, $params) |
|
| 423 | |||
| 424 | /** |
||
| 425 | * Process routing |
||
| 426 | * |
||
| 427 | * @return \Bluz\Router\Router |
||
| 428 | */ |
||
| 429 | 2 | public function process() |
|
| 446 | |||
| 447 | /** |
||
| 448 | * Process default router |
||
| 449 | * |
||
| 450 | * @return bool |
||
| 451 | */ |
||
| 452 | 2 | protected function processDefault() |
|
| 457 | |||
| 458 | /** |
||
| 459 | * Process custom router |
||
| 460 | * |
||
| 461 | * @return bool |
||
| 462 | */ |
||
| 463 | 1 | protected function processCustom() |
|
| 481 | |||
| 482 | /** |
||
| 483 | * Process router by default rules |
||
| 484 | * |
||
| 485 | * Default routers examples |
||
| 486 | * / |
||
| 487 | * /:module/ |
||
| 488 | * /:module/:controller/ |
||
| 489 | * /:module/:controller/:key1/:value1/:key2/:value2... |
||
| 490 | * |
||
| 491 | * @return bool |
||
| 492 | */ |
||
| 493 | 1 | protected function processRoute() |
|
| 528 | |||
| 529 | /** |
||
| 530 | * Reset Request |
||
| 531 | * |
||
| 532 | * @return void |
||
| 533 | */ |
||
| 534 | 2 | protected function resetRequest() |
|
| 554 | |||
| 555 | /** |
||
| 556 | * Get the request URI without baseUrl |
||
| 557 | * |
||
| 558 | * @return string |
||
| 559 | */ |
||
| 560 | 2 | public function getCleanUri() |
|
| 571 | } |
||
| 572 |