Complex classes like Router often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Router, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 26 | class Router |
||
| 27 | { |
||
| 28 | use Options; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Or should be as properties? |
||
| 32 | */ |
||
| 33 | const DEFAULT_MODULE = 'index'; |
||
| 34 | const DEFAULT_CONTROLLER = 'index'; |
||
| 35 | const ERROR_MODULE = 'error'; |
||
| 36 | const ERROR_CONTROLLER = 'index'; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var string base URL |
||
| 40 | */ |
||
| 41 | protected $baseUrl; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var string REQUEST_URI minus Base URL |
||
| 45 | */ |
||
| 46 | protected $cleanUri; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var string default module |
||
| 50 | */ |
||
| 51 | protected $defaultModule = self::DEFAULT_MODULE; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @var string default Controller |
||
| 55 | */ |
||
| 56 | protected $defaultController = self::DEFAULT_CONTROLLER; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var string error module |
||
| 60 | */ |
||
| 61 | protected $errorModule = self::ERROR_MODULE; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @var string error Controller |
||
| 65 | */ |
||
| 66 | protected $errorController = self::ERROR_CONTROLLER; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @var array instance parameters |
||
| 70 | */ |
||
| 71 | protected $params = array(); |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @var array instance raw parameters |
||
| 75 | */ |
||
| 76 | protected $rawParams = array(); |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @var array routers map |
||
| 80 | */ |
||
| 81 | protected $routers = array(); |
||
| 82 | |||
| 83 | /** |
||
| 84 | * @var array reverse map |
||
| 85 | */ |
||
| 86 | protected $reverse = array(); |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Constructor of Router |
||
| 90 | */ |
||
| 91 | 669 | public function __construct() |
|
| 141 | |||
| 142 | /** |
||
| 143 | * Get the base URL. |
||
| 144 | * |
||
| 145 | * @return string |
||
| 146 | */ |
||
| 147 | 61 | public function getBaseUrl() |
|
| 151 | |||
| 152 | /** |
||
| 153 | * Set the base URL. |
||
| 154 | * |
||
| 155 | * @param string $baseUrl |
||
| 156 | * @return void |
||
| 157 | */ |
||
| 158 | 669 | public function setBaseUrl($baseUrl) |
|
| 162 | |||
| 163 | /** |
||
| 164 | * Get an action parameter |
||
| 165 | * |
||
| 166 | * @param string $key |
||
| 167 | * @param mixed $default Default value to use if key not found |
||
| 168 | * @return mixed |
||
| 169 | */ |
||
| 170 | public function getParam($key, $default = null) |
||
| 174 | |||
| 175 | /** |
||
| 176 | * Set an action parameter |
||
| 177 | * |
||
| 178 | * A $value of null will unset the $key if it exists |
||
| 179 | * |
||
| 180 | * @param string $key |
||
| 181 | * @param mixed $value |
||
| 182 | * @return void |
||
| 183 | */ |
||
| 184 | 1 | public function setParam($key, $value) |
|
| 194 | |||
| 195 | /** |
||
| 196 | * Get parameters |
||
| 197 | * |
||
| 198 | * @return array |
||
| 199 | */ |
||
| 200 | public function getParams() |
||
| 204 | |||
| 205 | /** |
||
| 206 | * Get raw params, w/out module and controller |
||
| 207 | * |
||
| 208 | * @return array |
||
| 209 | */ |
||
| 210 | public function getRawParams() |
||
| 214 | |||
| 215 | /** |
||
| 216 | * Get default module |
||
| 217 | * |
||
| 218 | * @return string |
||
| 219 | */ |
||
| 220 | 669 | public function getDefaultModule() |
|
| 224 | |||
| 225 | /** |
||
| 226 | * Set default module |
||
| 227 | * |
||
| 228 | * @param string $defaultModule |
||
| 229 | * @return void |
||
| 230 | */ |
||
| 231 | public function setDefaultModule($defaultModule) |
||
| 235 | |||
| 236 | /** |
||
| 237 | * Get default controller |
||
| 238 | * |
||
| 239 | * @return string |
||
| 240 | */ |
||
| 241 | 669 | public function getDefaultController() |
|
| 245 | |||
| 246 | /** |
||
| 247 | * Set default controller |
||
| 248 | * |
||
| 249 | * @param string $defaultController |
||
| 250 | * @return void |
||
| 251 | */ |
||
| 252 | public function setDefaultController($defaultController) |
||
| 256 | |||
| 257 | /** |
||
| 258 | * Get error module |
||
| 259 | * |
||
| 260 | * @return string |
||
| 261 | */ |
||
| 262 | 1 | public function getErrorModule() |
|
| 266 | |||
| 267 | /** |
||
| 268 | * Set error module |
||
| 269 | * |
||
| 270 | * @param string $errorModule |
||
| 271 | * @return void |
||
| 272 | */ |
||
| 273 | public function setErrorModule($errorModule) |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Get error controller |
||
| 280 | * |
||
| 281 | * @return string |
||
| 282 | */ |
||
| 283 | 1 | public function getErrorController() |
|
| 287 | |||
| 288 | /** |
||
| 289 | * Set error controller |
||
| 290 | * |
||
| 291 | * @param string $errorController |
||
| 292 | * @return void |
||
| 293 | */ |
||
| 294 | public function setErrorController($errorController) |
||
| 298 | |||
| 299 | /** |
||
| 300 | * Build URL to controller |
||
| 301 | * |
||
| 302 | * @param string $module |
||
| 303 | * @param string $controller |
||
| 304 | * @param array $params |
||
| 305 | * @return string |
||
| 306 | */ |
||
| 307 | 31 | public function getUrl($module = self::DEFAULT_MODULE, $controller = self::DEFAULT_CONTROLLER, $params = array()) |
|
| 326 | |||
| 327 | /** |
||
| 328 | * Build full URL to controller |
||
| 329 | * |
||
| 330 | * @param string $module |
||
| 331 | * @param string $controller |
||
| 332 | * @param array $params |
||
| 333 | * @return string |
||
| 334 | */ |
||
| 335 | 1 | public function getFullUrl( |
|
| 345 | |||
| 346 | /** |
||
| 347 | * Build URL by custom route |
||
| 348 | * |
||
| 349 | * @param string $module |
||
| 350 | * @param string $controller |
||
| 351 | * @param array $params |
||
| 352 | * @return string |
||
| 353 | */ |
||
| 354 | 5 | protected function urlCustom($module, $controller, $params) |
|
| 383 | |||
| 384 | /** |
||
| 385 | * Build URL by default route |
||
| 386 | * |
||
| 387 | * @param string $module |
||
| 388 | * @param string $controller |
||
| 389 | * @param array $params |
||
| 390 | * @return string |
||
| 391 | */ |
||
| 392 | 26 | protected function urlRoute($module, $controller, $params) |
|
| 421 | |||
| 422 | /** |
||
| 423 | * Process routing |
||
| 424 | * |
||
| 425 | * @return \Bluz\Router\Router |
||
| 426 | */ |
||
| 427 | 2 | public function process() |
|
| 444 | |||
| 445 | /** |
||
| 446 | * Process default router |
||
| 447 | * |
||
| 448 | * @return bool |
||
| 449 | */ |
||
| 450 | 2 | protected function processDefault() |
|
| 455 | |||
| 456 | /** |
||
| 457 | * Process custom router |
||
| 458 | * |
||
| 459 | * @return bool |
||
| 460 | */ |
||
| 461 | 1 | protected function processCustom() |
|
| 479 | |||
| 480 | /** |
||
| 481 | * Process router by default rules |
||
| 482 | * |
||
| 483 | * Default routers examples |
||
| 484 | * / |
||
| 485 | * /:module/ |
||
| 486 | * /:module/:controller/ |
||
| 487 | * /:module/:controller/:key1/:value1/:key2/:value2... |
||
| 488 | * |
||
| 489 | * @return bool |
||
| 490 | */ |
||
| 491 | 1 | protected function processRoute() |
|
| 492 | { |
||
| 493 | 1 | $uri = $this->getCleanUri(); |
|
| 494 | 1 | $uri = trim($uri, '/'); |
|
| 495 | 1 | $raw = explode('/', $uri); |
|
| 496 | |||
| 497 | // rewrite module from request |
||
| 498 | 1 | if (sizeof($raw)) { |
|
| 499 | 1 | $this->setParam('_module', array_shift($raw)); |
|
| 500 | 1 | } |
|
| 501 | // rewrite module from controller |
||
| 502 | 1 | if (sizeof($raw)) { |
|
| 503 | 1 | $this->setParam('_controller', array_shift($raw)); |
|
| 504 | 1 | } |
|
| 505 | 1 | if ($size = sizeof($raw)) { |
|
| 506 | // save raw |
||
| 507 | $this->rawParams = $raw; |
||
| 508 | |||
| 509 | // save as index params |
||
| 510 | foreach ($raw as $i => $value) { |
||
| 511 | $this->setParam($i, $value); |
||
| 512 | } |
||
| 513 | |||
| 514 | // remove tail |
||
| 515 | if ($size % 2 == 1) { |
||
| 516 | array_pop($raw); |
||
| 517 | $size = sizeof($raw); |
||
| 518 | } |
||
| 519 | // or use array_chunk and run another loop? |
||
| 520 | for ($i = 0; $i < $size; $i = $i + 2) { |
||
| 521 | $this->setParam($raw[$i], $raw[$i + 1]); |
||
| 522 | } |
||
| 523 | } |
||
| 524 | 1 | return true; |
|
| 525 | } |
||
| 526 | |||
| 527 | /** |
||
| 528 | * Reset Request |
||
| 529 | * |
||
| 530 | * @return void |
||
| 531 | */ |
||
| 532 | 2 | protected function resetRequest() |
|
| 552 | |||
| 553 | /** |
||
| 554 | * Get the request URI without baseUrl |
||
| 555 | * |
||
| 556 | * @return string |
||
| 557 | */ |
||
| 558 | 27 | public function getCleanUri() |
|
| 569 | } |
||
| 570 |