Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
26 | abstract class AbstractCommand extends Console\Command\Command |
||
27 | { |
||
28 | /** |
||
29 | * @var InputInterface |
||
30 | */ |
||
31 | protected $input; |
||
32 | |||
33 | /** |
||
34 | * @var OutputInterface |
||
35 | */ |
||
36 | protected $output; |
||
37 | |||
38 | /** |
||
39 | * @var Filesystem |
||
40 | */ |
||
41 | protected $fs; |
||
42 | |||
43 | /** |
||
44 | * @param InputInterface $input |
||
45 | */ |
||
46 | 10 | public function setInput(InputInterface $input) |
|
50 | |||
51 | /** |
||
52 | * @return InputInterface |
||
53 | */ |
||
54 | public function getInput() |
||
58 | |||
59 | /** |
||
60 | * @param OutputInterface $output |
||
61 | */ |
||
62 | 10 | public function setOutput(OutputInterface $output) |
|
66 | |||
67 | /** |
||
68 | * @return OutputInterface |
||
69 | */ |
||
70 | 10 | public function getOutput() |
|
74 | |||
75 | /** |
||
76 | * @param \Symfony\Component\Filesystem\Filesystem $fs |
||
77 | */ |
||
78 | public function setFs($fs) |
||
82 | |||
83 | /** |
||
84 | * @return \Symfony\Component\Filesystem\Filesystem |
||
85 | */ |
||
86 | 6 | public function getFs() |
|
93 | |||
94 | /** |
||
95 | * @param InputInterface $input |
||
96 | * @param OutputInterface $output |
||
97 | * @return void |
||
98 | */ |
||
99 | 10 | final public function initialize(InputInterface $input, OutputInterface $output) |
|
108 | |||
109 | /** |
||
110 | * @param $message |
||
111 | * @return void |
||
112 | */ |
||
113 | 10 | public function write($message) |
|
117 | |||
118 | /** |
||
119 | * @param $message |
||
120 | * @return void |
||
121 | */ |
||
122 | public function info($message) |
||
126 | |||
127 | /** |
||
128 | * @param $message |
||
129 | * @return void |
||
130 | */ |
||
131 | public function comment($message) |
||
135 | |||
136 | /** |
||
137 | * @param $message |
||
138 | * @return void |
||
139 | */ |
||
140 | public function question($message) |
||
144 | |||
145 | /** |
||
146 | * @param $message |
||
147 | * @return void |
||
148 | */ |
||
149 | 4 | public function error($message) |
|
153 | |||
154 | /** |
||
155 | * @internal param $output |
||
156 | */ |
||
157 | public function callForContribute() |
||
164 | |||
165 | /** |
||
166 | * addModuleArgument |
||
167 | * |
||
168 | * @param int $required |
||
169 | * @return AbstractCommand |
||
170 | */ |
||
171 | 14 | View Code Duplication | protected function addModuleArgument($required = InputArgument::REQUIRED) |
182 | |||
183 | /** |
||
184 | * addControllerArgument |
||
185 | * |
||
186 | * @param int $required |
||
187 | * @return AbstractCommand |
||
188 | */ |
||
189 | 14 | View Code Duplication | protected function addControllerArgument($required = InputArgument::REQUIRED) |
204 | } |
||
205 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.