Bluzman\Command\Generate\ControllerCommand

Complexity

Total Complexity

10

Size/Duplication

Total Lines	128
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	12

Test Coverage

Coverage

82.46%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	17	1
B	execute()	0	37	3
B	generate()	0	30	3
A	verify()	0	19	3

<?php
/**
 * @copyright Bluz PHP Team
 * @link https://github.com/bluzphp/bluzman
 */

namespace Bluzman\Command\Generate;

use Bluzman\Generator;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * ControllerCommand
 *
 * @package  Bluzman\Command\Generate
 */
class ControllerCommand extends AbstractGenerateCommand
{
    /**
     * Command configuration
     */
    protected function configure()
    {
        $this
            // the name of the command (the part after "bin/bluzman")
            ->setName('generate:controller')
            // the short description shown while running "php bin/bluzman list"
            ->setDescription('Generate a new controller')
            // the full command description shown when running the command with
            // the "--help" option
            ->setHelp('This command allows you to generate controller files')
        ;

        $this
            ->addModuleArgument()
            ->addControllerArgument()
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        try {
            $this->write("Running <info>generate:controller</info> command");

            $module = $input->getArgument('module');
            $this->getDefinition()->getArgument('module')->validate($module);

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Console\Input\InputArgument as the method validate() does only exist in the following sub-classes of Symfony\Component\Console\Input\InputArgument: Bluzman\Input\InputArgument. Maybe you want to instanceof check for one of these explicitly?

            if (!$this->getApplication()->isModuleExists($module)) {
                $command = $this->getApplication()->find('generate:module');

                $arguments = [
                    'command' => 'generate:module',
                    'module' => $module
                ];

                $greetInput = new ArrayInput($arguments);
                $command->run($greetInput, $output);
            }

            $controller = $input->getArgument('controller');
            $this->getDefinition()->getArgument('controller')->validate($controller);

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Console\Input\InputArgument as the method validate() does only exist in the following sub-classes of Symfony\Component\Console\Input\InputArgument: Bluzman\Input\InputArgument. Maybe you want to instanceof check for one of these explicitly?

            // generate directories and files
            $this->generate($input, $output);

            // verify it
            $this->verify($input, $output);

            $this->write(
                "Controller <info>{$controller}</info> has been successfully created " .
                "in the module <info>{$controller}</info>."
            );
        } catch (\Exception $e) {
            $this->error("ERROR: {$e->getMessage()}");
        }
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return $this
     */
    protected function generate(InputInterface $input, OutputInterface $output)

The parameter $output is not used and could be removed.

    {
        $module = $input->getArgument('module');
        $controller = $input->getArgument('controller');

        $controllerFile = $this->getControllerPath($module, $controller);
        if (file_exists($controllerFile)) {
            $this->comment("Controller file <info>$module/$controller</info> already exists");
        } else {
            $template = new Generator\Template\ControllerTemplate;
            $template->setFilePath($controllerFile);

            $generator = new Generator\Generator($template);
            $generator->make();
        }

        $viewFile = $this->getViewPath($module, $controller);
        if (file_exists($viewFile)) {
            $this->comment("View file <info>$module/$controller</info> already exists");
        } else {
            $template = new Generator\Template\ViewTemplate;
            $template->setFilePath($viewFile);
            $template->setTemplateData(['name' => $controller]);

            $generator = new Generator\Generator($template);
            $generator->make();
        }

        return $this;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return void
     * @throws \Bluzman\Generator\GeneratorException
     */
    public function verify(InputInterface $input, OutputInterface $output)
    {
        $modulePath = $this->getApplication()->getModulePath($input->getArgument('module'));

        $paths = [
            $modulePath,
            $modulePath . DS . 'controllers',
            $modulePath . DS . 'controllers' . DS . $input->getArgument('controller') . '.php',
            $modulePath . DS . 'views',
            $modulePath . DS . 'views' . DS . $input->getArgument('controller') . '.phtml',

        ];

        foreach ($paths as $path) {
            if (!$this->getFs()->exists($path)) {
                throw new Generator\GeneratorException("File or directory `$path` is not exists");
            }
        }
    }
}