UTXO::__construct() - Code Metrics - Inspection of "check key count is 2 in BlocktrailSDK::normalizeBI..." - blocktrail/blocktrail-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#88)

by thomas

created 2017-11-23 18:14 UTC

UTXO::__construct() A

↳ Parent: UTXO

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	19
nc	1
nop	9
dl	0
loc	21
ccs	11
cts	11
cp	1
crap	1
rs	9.3142
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace Blocktrail\SDK;

use BitWasp\Bitcoin\Address\AddressInterface;
use BitWasp\Bitcoin\Script\ScriptInterface;
use BitWasp\Bitcoin\Transaction\TransactionOutput;

class UTXO {

    public $hash;
    public $index;
    public $value;

    /**
     * @var AddressInterface
     */
    public $address;

    /**
     * @var ScriptInterface
     */
    public $scriptPubKey;
    public $path;

    /**
     * @var ScriptInterface
     */
    public $redeemScript;

    /**
     * @var ScriptInterface|null
     */
    public $witnessScript;

    /**
     * @var string
     */
    public $signMode;

    /**
     * UTXO constructor.
     * @param $hash
     * @param $index
     * @param null $value
     * @param AddressInterface|null $address
     * @param ScriptInterface|null $scriptPubKey
     * @param null $path
     * @param ScriptInterface|null $redeemScript
     * @param ScriptInterface|null $witnessScript
     * @param string $signMode
     */
    public function __construct(
        $hash,
        $index,
        $value = null,
        AddressInterface $address = null,
        ScriptInterface $scriptPubKey = null,
        $path = null,
        ScriptInterface $redeemScript = null,
        ScriptInterface $witnessScript = null,
        $signMode = SignInfo::MODE_SIGN
    ) {
        $this->hash = $hash;
        $this->index = $index;
        $this->value = $value;
        $this->address = $address;
        $this->scriptPubKey = $scriptPubKey;
        $this->path = $path;
        $this->redeemScript = $redeemScript;
        $this->witnessScript = $witnessScript;
        $this->signMode = $signMode;
    }

    /**
     * @return SignInfo
     */
    public function getSignInfo() {
        return new SignInfo(new TransactionOutput($this->value, $this->scriptPubKey), $this->signMode, $this->path, $this->redeemScript, $this->witnessScript);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1		<?php
2
3		namespace Blocktrail\SDK;
4
5		use BitWasp\Bitcoin\Address\AddressInterface;
6		use BitWasp\Bitcoin\Script\ScriptInterface;
7		use BitWasp\Bitcoin\Transaction\TransactionOutput;
8
9		class UTXO {
10
11		public $hash;
12		public $index;
13		public $value;
14
15		/**
16		* @var AddressInterface
17		*/
18		public $address;
19
20		/**
21		* @var ScriptInterface
22		*/
23		public $scriptPubKey;
24		public $path;
25
26		/**
27		* @var ScriptInterface
28		*/
29		public $redeemScript;
30
31		/**
32		* @var ScriptInterface\|null
33		*/
34		public $witnessScript;
35
36		/**
37		* @var string
38		*/
39		public $signMode;
40
41		/**
42		* UTXO constructor.
43		* @param $hash
44		* @param $index
45		* @param null $value
46		* @param AddressInterface\|null $address
47		* @param ScriptInterface\|null $scriptPubKey
48		* @param null $path
49		* @param ScriptInterface\|null $redeemScript
50		* @param ScriptInterface\|null $witnessScript
51		* @param string $signMode
52		*/
53	1	public function __construct(
54		$hash,
55		$index,
56		$value = null,
57		AddressInterface $address = null,
58		ScriptInterface $scriptPubKey = null,
59		$path = null,
60		ScriptInterface $redeemScript = null,
61		ScriptInterface $witnessScript = null,
62		$signMode = SignInfo::MODE_SIGN
63		) {
64	1	$this->hash = $hash;
65	1	$this->index = $index;
66	1	$this->value = $value;
67	1	$this->address = $address;
68	1	$this->scriptPubKey = $scriptPubKey;
69	1	$this->path = $path;
70	1	$this->redeemScript = $redeemScript;
71	1	$this->witnessScript = $witnessScript;
72	1	$this->signMode = $signMode;
73	1	}
74
75		/**
76		* @return SignInfo
77		*/
78		public function getSignInfo() {
79		return new SignInfo(new TransactionOutput($this->value, $this->scriptPubKey), $this->signMode, $this->path, $this->redeemScript, $this->witnessScript);
		0 ignored issues – show Bug introduced 2017-11-06 09:03 UTC by Report Bug Copy Issue Report It seems like `$this->path` can also be of type `array`; however, `Blocktrail\SDK\SignInfo::__construct()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
80		}
81		}
82

blocktrail / blocktrail-sdk-php

Pull Request — master (#88)

UTXO::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like