exports.workify - Code Metrics - Inspection of "build asmcrypto seperate" - blocktrail/blocktrail-sdk-nodejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#83)

by Ruben de

created 2017-12-01 12:50 UTC

exports.workify B

↳ Parent: lib/webworkifier.js

Complexity

Conditions	5
Paths	63

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
c	1
b	0
f	0
nc	63
dl	0
loc	69
rs	8.56
nop	4

6 Functions

Rating	Size	Complexity
A	3	1
A	4	1
A	4	1
A	1	1
A	4	1
A	13	3

How to fix Long Method

/* global URL */
var q = require('q');
var webworkify = require('webworkify');

/**
 * wrapper around creating / using webworker that reuses webworker instance
 *
 * @param self
 * @param workerModuleFactory
 * @param message
 * @returns {*}
 */
module.exports = exports = {
    workify: function(self, workerModuleFactory, onLoad, message) {
        if (typeof message === "undefined") {
            if (typeof onLoad !== "undefined") {
                message = onLoad;
                onLoad = function noop() {};
            }
        }

        // create promise for result
        var deferred = q.defer();

        try {
            // init worker if necessary
            if (typeof self.worker === "undefined") {
                self.worker = webworkify(workerModuleFactory());
                self.first = true;
                self.id = 0;
                onLoad(self.worker);

            }

            var worker = self.worker;

            // keep a unique id to distinguish between responses
            var id = self.id++;

            var onMessage = function(e) {
                if (self.first) {
                    self.first = false;
                    URL.revokeObjectURL(worker.objectURL);
                }

                // don't process messages that aren't for us
                if (e.data.id !== id) {
                    return;
                }

                deferred.resolve(e.data);
            };

            var onError = function(e) {
                deferred.reject(new Error(e.message.replace("Uncaught Error: ", '')));
            };

            var unsub = function() {
                worker.removeEventListener("message", onMessage);
                worker.removeEventListener("error", onError);
            };

            // register event listeners
            worker.addEventListener('message', onMessage, false);
            worker.addEventListener('error', onError, false);

            // submit message to worker to init work
            message.id = id;
            worker.postMessage(message);

            // return promise
            return deferred.promise.then(function(r) {
                unsub();
                return r;
            }, function(e) {
                unsub();
                throw e;
            });
        } catch (e) {
            deferred.reject(e);
            return deferred.promise;
        }
    }
};


1			/* global URL */
2			var q = require('q');
3			var webworkify = require('webworkify');
4
5			/**
6			* wrapper around creating / using webworker that reuses webworker instance
7			*
8			* @param self
9			* @param workerModuleFactory
10			* @param message
11			* @returns {*}
12			*/
13			module.exports = exports = {
14			workify: function(self, workerModuleFactory, onLoad, message) {
15			if (typeof message === "undefined") {
16			if (typeof onLoad !== "undefined") {
17			message = onLoad;
18			onLoad = function noop() {};
19			}
20			}
21
22			// create promise for result
23			var deferred = q.defer();
24
25			try {
26			// init worker if necessary
27			if (typeof self.worker === "undefined") {
28			self.worker = webworkify(workerModuleFactory());
29			self.first = true;
30			self.id = 0;
31			onLoad(self.worker);
			0 ignored issues – show Bug introduced 2017-11-30 16:14 UTC by Report Bug Copy Issue Report The call to `onLoad` seems to have too many arguments starting with `self.worker`. Loading history...
32			}
33
34			var worker = self.worker;
35
36			// keep a unique id to distinguish between responses
37			var id = self.id++;
38
39			var onMessage = function(e) {
40			if (self.first) {
41			self.first = false;
42			URL.revokeObjectURL(worker.objectURL);
43			}
44
45			// don't process messages that aren't for us
46			if (e.data.id !== id) {
47			return;
48			}
49
50			deferred.resolve(e.data);
51			};
52
53			var onError = function(e) {
54			deferred.reject(new Error(e.message.replace("Uncaught Error: ", '')));
55			};
56
57			var unsub = function() {
58			worker.removeEventListener("message", onMessage);
59			worker.removeEventListener("error", onError);
60			};
61
62			// register event listeners
63			worker.addEventListener('message', onMessage, false);
64			worker.addEventListener('error', onError, false);
65
66			// submit message to worker to init work
67			message.id = id;
68			worker.postMessage(message);
69
70			// return promise
71			return deferred.promise.then(function(r) {
72			unsub();
73			return r;
74			}, function(e) {
75			unsub();
76			throw e;
77			});
78			} catch (e) {
79			deferred.reject(e);
80			return deferred.promise;
81			}
82			}
83			};
84

blocktrail / blocktrail-sdk-nodejs

Pull Request — master (#83)

exports.workify B

Complexity

Size

Duplication

Importance

6 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like