blitze\content\services\views\driver\portal

Complexity

Total Complexity

10

Size/Duplication

Total Lines	116
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	get_name()	0	4	1
A	get_langname()	0	4	1
A	get_index_template()	0	4	1
B	render_filter()	0	28	3
A	display_filtered_topics()	0	23	3

<?php
/**
 *
 * @package sitemaker
 * @copyright (c) 2013 Daniel A. (blitze)
 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
 *
 */

namespace blitze\content\services\views\driver;

class portal extends base_view
{
	/** @var \phpbb\config\config */
	protected $config;

	/** @var \blitze\content\services\types */
	protected $content_types;

	/**
	 * Constructor
	 *
	 * @param \phpbb\event\dispatcher_interface			$phpbb_dispatcher	Event dispatcher object
	 * @param \phpbb\language\language					$language			Language Object
	 * @param \phpbb\pagination							$pagination			Pagination object
	 * @param \phpbb\template\template					$template			Template object
	 * @param \blitze\content\services\fields			$fields				Content fields object
	 * @param \blitze\sitemaker\services\forum\data		$forum				Forum Data object
	 * @param \blitze\content\services\helper			$helper				Content helper object
	 * @param \blitze\content\services\quickmod			$quickmod			Quick moderator tools
	 * @param string									$phpbb_root_path	Path to the phpbb includes directory.
	 * @param string									$php_ext			php file extension
	 * @param \phpbb\config\config						$config				Config object
	 * @param \blitze\content\services\types			$content_types		Content types object
	*/
	public function __construct(\phpbb\event\dispatcher_interface $phpbb_dispatcher, \phpbb\language\language $language, \phpbb\pagination $pagination, \phpbb\template\template $template, \blitze\content\services\fields $fields, \blitze\sitemaker\services\forum\data $forum, \blitze\content\services\helper $helper, \blitze\content\services\quickmod $quickmod, $phpbb_root_path, $php_ext, \phpbb\config\config $config, \blitze\content\services\types $content_types)
	{
		parent::__construct($phpbb_dispatcher, $language, $pagination, $template, $fields, $forum, $helper, $quickmod, $phpbb_root_path, $php_ext);

		$this->config = $config;
		$this->content_types = $content_types;
	}

	/**
	 * @inheritdoc
	 */
	public function get_name()
	{
		return 'portal';
	}

	/**
	 * @inheritdoc
	 */
	public function get_langname()
	{
		return 'CONTENT_DISPLAY_PORTAL';
	}

	/**
	 * @inheritdoc
	 */
	public function get_index_template()
	{
		return 'views/portal.html';
	}

	/**
	 * {@inheritdoc}
	 */
	public function render_filter($filter_type, $filter_value, $page)
	{
		$this->build_index_query($filter_type, $filter_value);

		$total_topics = $this->forum->get_topics_count();
		$items_per_page = $this->config['topics_per_page'];
		$start = ($page - 1) * $items_per_page;
		$topics_data = $this->forum->get_topic_data($items_per_page, $start);
		$this->generate_pagination('summary', $total_topics, $start, $items_per_page, array(
			'filter_type'	=> $filter_type,
			'filter_value'	=> $filter_value,
		));

		if (sizeof($topics_data))
		{
			$posts_data = $this->forum->get_post_data('first');
			$users_cache = $this->forum->get_posters_info();

			$forums_data = array();
			foreach ($posts_data as $topic_id => $row)
			{
				$post = current($row);
				$forums_data[$post['forum_id']][$topic_id] = $post;
			}

			$this->display_filtered_topics($forums_data, $topics_data, $users_cache);
		}
	}

	/**
	 * @param array $forums_data
	 * @return void
	 */
	protected function display_filtered_topics(array $forums_data, array $topics_data, array $users_cache)
	{
		$update_count = array();
		foreach ($forums_data as $forum_id => $posts_data)
		{
			$content_type = $this->content_types->get_forum_type($forum_id);
			$entity = $this->content_types->get_type($content_type);

It seems like $content_type defined by $this->content_types->get_forum_type($forum_id) on line 109 can also be of type boolean; however, blitze\content\services\types::get_type() does only seem to accept string, maybe add an additional type check?

			$this->template->assign_vars($entity->to_array());

			$this->fields->prepare_to_show($entity, array_keys($posts_data), $entity->get_summary_tags(), $entity->get_summary_tpl(), 'summary');

It seems like $entity defined by $this->content_types->get_type($content_type) on line 110 can also be of type false; however, blitze\content\services\fields::prepare_to_show() does only seem to accept object<blitze\content\model\entity\type>, did you maybe forget to handle an error condition?

			$topic_tracking_info = $this->forum->get_topic_tracking_info($forum_id);
			$attachments = $this->forum->get_attachments($forum_id);

			foreach ($posts_data as $topic_id => $post_data)
			{
				$topic_data	= $topics_data[$topic_id];
				$topic = $this->fields->show($content_type, $topic_data, $post_data, $users_cache, $attachments, $update_count, $topic_tracking_info);

It seems like $content_type defined by $this->content_types->get_forum_type($forum_id) on line 109 can also be of type boolean; however, blitze\content\services\fields::show() does only seem to accept string, maybe add an additional type check?

				$this->template->assign_block_vars('topicrow', $topic);
			}
		}
	}
}