Completed
Push — develop ( 6a0b8a...755a17 )
by Daniel
07:17
created
model/entity/type.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -306,11 +306,11 @@
 block discarded – undo
306 306
 		$summary_tags = $this->get_template_tags($summary_tags, $this->summary_tpl, $fields);
307 307
 		$detail_tags = $this->get_template_tags($detail_tags, $this->detail_tpl, $fields);
308 308
 
309
-		$this->summary_tags	= array_intersect_key($field_types, array_flip($summary_tags));
310
-		$this->detail_tags	= array_intersect_key($field_types, array_flip($detail_tags));
309
+		$this->summary_tags = array_intersect_key($field_types, array_flip($summary_tags));
310
+		$this->detail_tags = array_intersect_key($field_types, array_flip($detail_tags));
311 311
 
312
-		$this->content_fields	= $content_fields;
313
-		$this->field_types		= $field_types;
312
+		$this->content_fields = $content_fields;
313
+		$this->field_types = $field_types;
314 314
 	}
315 315
 
316 316
 	/**
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -232,8 +232,7 @@  discard block
 block discarded – undo
232 232
 		{
233 233
 			$data = generate_text_for_edit($this->content_desc, $this->content_desc_uid, $this->content_desc_options);
234 234
 			return $data['text'];
235
-		}
236
-		else
235
+		} else
237 236
 		{
238 237
 			$parse_flags = ($this->content_desc_bitfield ? OPTION_FLAG_BBCODE : 0) | OPTION_FLAG_SMILIES;
239 238
 			return generate_text_for_display($this->content_desc, $this->content_desc_uid, $this->content_desc_bitfield, $parse_flags);
@@ -251,8 +250,7 @@  discard block
 block discarded – undo
251 250
 		if (!is_array($settings))
252 251
 		{
253 252
 			$this->content_view_settings = $settings;
254
-		}
255
-		else if (sizeof($settings))
253
+		} else if (sizeof($settings))
256 254
 		{
257 255
 			$this->content_view_settings = json_encode($settings);
258 256
 		}
Please login to merge, or discard this patch.
blocks/archive.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 	 * @param \phpbb\controller\helper				$helper					Helper object
45 45
 	 * @param \phpbb\user							$user					User object
46 46
 	 * @param \blitze\content\services\types		$content_types			Content types object
47
-	*/
47
+	 */
48 48
 	public function __construct(\phpbb\auth\auth $auth, \phpbb\content_visibility $content_visibility, \phpbb\db\driver\driver_interface $db, \phpbb\controller\helper $helper, \phpbb\user $user, \blitze\content\services\types $content_types, $phpbb_root_path, $php_ext)
49 49
 	{
50 50
 		$this->auth = $auth;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,8 +94,8 @@
 block discarded – undo
94 94
 			'FROM'		=> array(
95 95
 				TOPICS_TABLE => 't',
96 96
 			),
97
-			'WHERE'		=> 't.forum_id = ' . (int) $settings['forum_id'] . '
98
-				AND t.topic_time <= ' . time() . '
97
+			'WHERE'		=> 't.forum_id = '.(int) $settings['forum_id'].'
98
+				AND t.topic_time <= ' . time().'
99 99
 				AND ' . $this->content_visibility->get_global_visibility_sql('topic', array_keys($this->auth->acl_getf('!f_read', true)), 't.'),
100 100
 			'GROUP_BY'	=> 'year, month',
101 101
 			'ORDER_BY'	=> 'year DESC',
Please login to merge, or discard this patch.
blocks/recent.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -166,14 +166,14 @@  discard block
 block discarded – undo
166 166
 			$attachments = $this->forum->get_attachments($forum_id);
167 167
 			$topic_tracking_info = $this->forum->get_topic_tracking_info($forum_id);
168 168
 
169
-			$this->fields->prepare_to_show($type, 'block', $this->get_block_fields($entity->get_field_types()), $entity->get_content_fields(), $this->settings['block_tpl'], $block_id . '_block', $this->settings['max_chars']);
169
+			$this->fields->prepare_to_show($type, 'block', $this->get_block_fields($entity->get_field_types()), $entity->get_content_fields(), $this->settings['block_tpl'], $block_id.'_block', $this->settings['max_chars']);
170 170
 
171 171
 			$update_count = array();
172 172
 			$topics_data = array_values($topics_data);
173 173
 			for ($i = 0, $size = sizeof($topics_data); $i < $size; $i++)
174 174
 			{
175 175
 				$topic_data	= $topics_data[$i];
176
-				$post_data	= array_shift($posts_data[$topic_data['topic_id']]);
176
+				$post_data = array_shift($posts_data[$topic_data['topic_id']]);
177 177
 
178 178
 				$tpl_data = $this->fields->show($type, $topic_data, $post_data, $users_cache, $attachments, $update_count, $topic_tracking_info);
179 179
 				$this->ptemplate->assign_block_vars('topic_row', $tpl_data);
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 			POST_STICKY		=> 'CONTENT_STICKY_POSTS',
202 202
 		);
203 203
 
204
-		return (isset($topic_types[$this->settings['topic_type']])) ? $topic_types[$this->settings['topic_types']] :  $this->language->lang('CONTENT_' . $this->sort_options[$this->settings['sort_key']], $content_langname);
204
+		return (isset($topic_types[$this->settings['topic_type']])) ? $topic_types[$this->settings['topic_types']] : $this->language->lang('CONTENT_'.$this->sort_options[$this->settings['sort_key']], $content_langname);
205 205
 	}
206 206
 
207 207
 	/**
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 		foreach ($content_types as $value => $title)
252 252
 		{
253 253
 			$selected = ($type == $value) ? ' selected="selected"' : '';
254
-			$html .= '<option value="' . $value . '"' . $selected . ' data-toggle-setting="#fields-col-' . $value . '">' . $title . '</option>';
254
+			$html .= '<option value="'.$value.'"'.$selected.' data-toggle-setting="#fields-col-'.$value.'">'.$title.'</option>';
255 255
 		}
256 256
 
257 257
 		return $html;
Please login to merge, or discard this patch.
controller/admin_controller.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	 *
23 23
 	 * @param \phpbb\language\language					$language			Language object
24 24
 	 * @param \blitze\content\services\action_handler	$action_handler		Handles actions
25
-	*/
25
+	 */
26 26
 	public function __construct(\phpbb\language\language $language, \blitze\content\services\action_handler $action_handler)
27 27
 	{
28 28
 		$this->language = $language;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 		catch (\blitze\sitemaker\exception\base $e)
48 48
 		{
49 49
 			$message = $e->get_message($this->language);
50
-			trigger_error($this->language->lang($message) . adm_back_link($base_url), E_USER_WARNING);
50
+			trigger_error($this->language->lang($message).adm_back_link($base_url), E_USER_WARNING);
51 51
 		}
52 52
 	}
53 53
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,7 @@
 block discarded – undo
43 43
 		{
44 44
 			$command = $this->action_handler->create('type', $action);
45 45
 			$command->execute($base_url, $type);
46
-		}
47
-		catch (\blitze\sitemaker\exception\base $e)
46
+		} catch (\blitze\sitemaker\exception\base $e)
48 47
 		{
49 48
 			$message = $e->get_message($this->language);
50 49
 			trigger_error($this->language->lang($message) . adm_back_link($base_url), E_USER_WARNING);
Please login to merge, or discard this patch.
model/mapper/fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,8 +25,8 @@  discard block
 block discarded – undo
25 25
 	 */
26 26
 	protected function _find_sql(array $sql_where)
27 27
 	{
28
-		return 'SELECT * FROM ' . $this->entity_table .
29
-			((sizeof($sql_where)) ? ' WHERE ' . join(' AND ', $sql_where) : '') . '
28
+		return 'SELECT * FROM '.$this->entity_table.
29
+			((sizeof($sql_where)) ? ' WHERE '.join(' AND ', $sql_where) : '').'
30 30
 			ORDER BY field_order ASC';
31 31
 	}
32 32
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	public function get_max_field_id()
37 37
 	{
38
-		$result = $this->db->sql_query('SELECT MAX(' . $this->entity_pkey . ') AS max_id FROM ' . $this->entity_table);
38
+		$result = $this->db->sql_query('SELECT MAX('.$this->entity_pkey.') AS max_id FROM '.$this->entity_table);
39 39
 		$max_id = $this->db->sql_fetchfield('max_id');
40 40
 		$this->db->sql_freeresult($result);
41 41
 
Please login to merge, or discard this patch.
model/mapper_factory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,8 @@
 block discarded – undo
36 36
 	 */
37 37
 	public function create($type)
38 38
 	{
39
-		$mapper_class = 'blitze\\content\\model\\mapper\\' . $type;
40
-		$collection = 'blitze\\content\\model\\collections\\' . $type;
39
+		$mapper_class = 'blitze\\content\\model\\mapper\\'.$type;
40
+		$collection = 'blitze\\content\\model\\collections\\'.$type;
41 41
 
42 42
 		return new $mapper_class($this->db, new $collection, $this, $this->mapper_tables[$type]);
43 43
 	}
Please login to merge, or discard this patch.
services/action_handler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	 */
35 35
 	public function create($mode, $action)
36 36
 	{
37
-		$service_name = 'blitze.content.actions.' . $mode . '.' . $action;
37
+		$service_name = 'blitze.content.actions.'.$mode.'.'.$action;
38 38
 		if (!$this->phpbb_container->has($service_name))
39 39
 		{
40 40
 			throw new \blitze\sitemaker\exception\out_of_bounds(array($action, 'INVALID_REQUEST'));
Please login to merge, or discard this patch.
services/actions/topic/view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,14 +65,14 @@
 block discarded – undo
65 65
 		$entity->set_allow_comments(false);
66 66
 
67 67
 		$overwrite = array(
68
-			'TOPIC_URL'	=> $u_action . '&amp;do=view&amp;type=' . $type . '&amp;t=' . $topic_id,
68
+			'TOPIC_URL'	=> $u_action.'&amp;do=view&amp;type='.$type.'&amp;t='.$topic_id,
69 69
 			'U_INFO'	=> '',
70 70
 		);
71 71
 
72 72
 		if ($mode === 'mcp')
73 73
 		{
74 74
 			$redirect_url = urlencode(str_replace('&amp;', '&', $u_action));
75
-			$overwrite['U_DELETE'] = append_sid("{$this->phpbb_root_path}mcp.$this->php_ext", 'quickmod=1&amp;action=delete_topic&amp;t=' . $topic_id . '&amp;redirect=' . $redirect_url);
75
+			$overwrite['U_DELETE'] = append_sid("{$this->phpbb_root_path}mcp.$this->php_ext", 'quickmod=1&amp;action=delete_topic&amp;t='.$topic_id.'&amp;redirect='.$redirect_url);
76 76
 		}
77 77
 
78 78
 		$update_count = array();
Please login to merge, or discard this patch.
services/actions/topic/filter.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	{
89 89
 		$copy_params = $this->params;
90 90
 		unset($copy_params['type']);
91
-		$view_url = $u_action . http_build_query($copy_params);
91
+		$view_url = $u_action.http_build_query($copy_params);
92 92
 
93 93
 		$this->template->assign_block_vars('content', array(
94 94
 			'TITLE'			=> $this->language->lang('TOPIC_ALL'),
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 				'TITLE'			=> $entity->get_content_langname(),
105 105
 				'COLOUR'		=> $entity->get_content_colour(),
106 106
 				'S_SELECTED'	=> ($type === $content_name) ? true : false,
107
-				'U_VIEW'		=> $view_url . '&amp;type=' . $content_name
107
+				'U_VIEW'		=> $view_url.'&amp;type='.$content_name
108 108
 			));
109 109
 		}
110 110
 	}
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	{
135 135
 		$copy_params = $this->params;
136 136
 		unset($copy_params['status']);
137
-		$view_url = $u_action . http_build_query($copy_params);
137
+		$view_url = $u_action.http_build_query($copy_params);
138 138
 
139 139
 		$this->template->assign_block_vars('status', array(
140 140
 			'TITLE'			=> $this->language->lang('TOPIC_ALL'),
@@ -146,9 +146,9 @@  discard block
 block discarded – undo
146 146
 		foreach ($topic_status_ary as $status)
147 147
 		{
148 148
 			$this->template->assign_block_vars('status', array(
149
-				'TITLE'			=> $this->language->lang('TOPIC_' . strtoupper($status)),
149
+				'TITLE'			=> $this->language->lang('TOPIC_'.strtoupper($status)),
150 150
 				'S_SELECTED'	=> ($status === $topic_status) ? true : false,
151
-				'U_VIEW'		=> $view_url . '&amp;status=' . $status
151
+				'U_VIEW'		=> $view_url.'&amp;status='.$status
152 152
 			));
153 153
 		}
154 154
 	}
@@ -163,18 +163,18 @@  discard block
 block discarded – undo
163 163
 		switch ($topic_status)
164 164
 		{
165 165
 			case 'scheduled':
166
-				$sql_where_array[] = 't.topic_time > ' . time();
166
+				$sql_where_array[] = 't.topic_time > '.time();
167 167
 			break;
168 168
 			case 'unapproved':
169 169
 			case 'published':
170 170
 			case 'deleted':
171
-				$sql_where_array[] = 't.topic_visibility = ' . array_search($topic_status, $this->filter_topic_status_ary);
171
+				$sql_where_array[] = 't.topic_visibility = '.array_search($topic_status, $this->filter_topic_status_ary);
172 172
 			break;
173 173
 			case 'recommended':
174 174
 			case 'featured':
175 175
 			case 'must_read':
176
-				$sql_where_array[] = 't.topic_type = ' . array_search($topic_status, $this->filter_topic_types_ary);
177
-				$sql_where_array[] = 't.topic_visibility = ' . ITEM_APPROVED;
176
+				$sql_where_array[] = 't.topic_type = '.array_search($topic_status, $this->filter_topic_types_ary);
177
+				$sql_where_array[] = 't.topic_visibility = '.ITEM_APPROVED;
178 178
 			break;
179 179
 		}
180 180
 	}
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 		if ($keyword = $this->request->variable('keyword', '', true))
189 189
 		{
190 190
 			$this->params['keyword'] = $keyword;
191
-			$sql_where_array[] = 't.topic_title ' . $this->db->sql_like_expression($this->db->get_any_char() . $keyword . $this->db->get_any_char());
191
+			$sql_where_array[] = 't.topic_title '.$this->db->sql_like_expression($this->db->get_any_char().$keyword.$this->db->get_any_char());
192 192
 		}
193 193
 	}
194 194
 }
Please login to merge, or discard this patch.