members::set_range_sql() - Code Metrics - Inspection of "A few js/scss quality issues" - blitze/phpBB-ext-sitemaker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a0ceb6...422577 )

by Daniel

created 2016-03-26 18:14 UTC

members::set_range_sql() A

↳ Parent: members

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4.125

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	10
ccs	4
cts	8
cp	0.5
rs	9.4285
cc	3
eloc	5
nc	2
nop	1
crap	4.125

<?php
/**
 *
 * @package sitemaker
 * @copyright (c) 2013 Daniel A. (blitze)
 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
 *
 */

namespace blitze\sitemaker\services;

class members
{
	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\user */
	protected $user;

	/** @var \blitze\sitemaker\services\date_range */
	protected $date_range;

	/** @var \blitze\sitemaker\services\template driver_interface */
	protected $ptemplate;

	/** @var string */
	protected $phpbb_root_path;

	/** @var string */
	protected $php_ext;

	protected $explain_range = '';
	protected $sql_date_field = '';
	protected $view_mode = 'member_date';
	protected $user_header = 'USERNAME';
	protected $info_header = 'MEMBERS_DATE';
	protected $settings = array();

	/**
	 * Constructor
	 *
	 * @param \phpbb\db\driver\driver_interface		$db     			Database connection
	 * @param \phpbb\user							$user				User object
	 * @param \blitze\sitemaker\services\date_range	$date_range			Date range object
	 * @param \blitze\sitemaker\services\template	$ptemplate			Sitemaker template object
	 * @param string								$phpbb_root_path	Path to the phpbb includes directory.
	 * @param string								$php_ext			php file extension
	 */
	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\user $user, \blitze\sitemaker\services\date_range $date_range, \blitze\sitemaker\services\template $ptemplate, $phpbb_root_path, $php_ext)
	{
		$this->db = $db;
		$this->user = $user;
		$this->date_range = $date_range;
		$this->ptemplate = $ptemplate;
		$this->phpbb_root_path = $phpbb_root_path;
		$this->php_ext = $php_ext;

		if (!function_exists('phpbb_get_user_avatar'))
		{
			include($phpbb_root_path . 'includes/functions_display.' . $php_ext);
		}
	}

	/**
	 * get members
	 * @param array $get
	 * @return string
	 */
	public function get_list(array $get = array())
	{
		$this->settings = $get + array(
			'query_type'	=> 'recent',
			'date_range'	=> '',
			'max_members'	=> 5,
		);

		$sql = $this->get_sql_statement();
		$result = $this->db->sql_query_limit($sql, $this->settings['max_members']);

		$has_results = false;
		while ($row = $this->db->sql_fetchrow($result))
		{
			$has_results = true;
			$this->ptemplate->assign_block_vars('member', call_user_func_array(array($this, $this->view_mode), array($row)));
		}
		$this->db->sql_freeresult($result);

		return $this->show_results($has_results);
	}

	/**
	 * @param array $row
	 * @return array
	 */
	protected function member_posts(array $row)
	{
		$u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&amp;sr=posts" . $this->explain_range);
		$user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>';

		return array(
			'USERNAME'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
			'USER_AVATAR'	=> phpbb_get_user_avatar($row),
			'USER_INFO'		=> $user_posts
		);
	}

	/**
	 * @param array $row
	 * @return array
	 */
	protected function member_date(array $row)
	{
		return array(
			'USERNAME'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
			'USER_AVATAR'	=> phpbb_get_user_avatar($row),
			'USER_INFO'		=> $this->user->format_date($row['member_date'], $this->user->lang['DATE_FORMAT'], true)
		);
	}

	/**
	 * @param array $row
	 * @return array
	 */
	protected function member_bots(array $row)
	{
		return array(
			'USERNAME'	=> get_username_string('username', $row['user_id'], $row['username'], $row['user_colour']),
			'USER_INFO'	=> $this->user->format_date($row['member_date'])
		);
	}

	/**
	 * @param bool $has_results
	 * @return string
	 */
	protected function show_results($has_results)
	{
		$html = '';
		if ($has_results)
		{
			$this->ptemplate->assign_vars(array(
				'S_LIST'	=> $this->settings['query_type'],
				'L_USER'	=> $this->user->lang($this->user_header),
				'L_INFO'	=> $this->user->lang($this->info_header),
			));

			$html = $this->ptemplate->render_view('blitze/sitemaker', 'blocks/members.html', 'members_block');
		}

		return $html;
	}

	/**
	 * @return string
	 */
	protected function get_sql_statement()
	{
		$sql_ary = array(
			'SELECT'		=> 'u.user_id, u.username, u.user_colour, u.user_avatar, u.user_avatar_type, u.user_avatar_width, u.user_avatar_height',
			'FROM'			=> array(
					USERS_TABLE => 'u'
			),
			'WHERE'			=> $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)),
		);

		$sql_method = 'set_' . $this->settings['query_type'] . '_sql';
		call_user_func_array(array($this, $sql_method), array(&$sql_ary));

		$this->set_range_sql($sql_ary);

		return $this->db->sql_build_query('SELECT', $sql_ary);
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_visits_sql(array &$sql_ary)
	{
		$sql_ary['SELECT'] .= ', u.user_lastvisit as member_date';
		$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0';
		$sql_ary['ORDER_BY'] = 'u.user_lastvisit DESC';

		$this->sql_date_field = 'user_lastvisit';
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_bots_sql(array &$sql_ary)
	{
		$this->set_visits_sql($sql_ary);
		$this->user_header = '';
		$this->info_header = '';
		$this->view_mode = 'member_bots';

		$sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE;
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_tenured_sql(array &$sql_ary)
	{
		$sql_ary['SELECT'] .= ', u.user_regdate as member_date';
		$sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');

		$this->sql_date_field = 'u.user_regdate';
		$this->settings['date_range'] = '';
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_recent_sql(array &$sql_ary)
	{
		$this->set_tenured_sql($sql_ary);
		$this->info_header = 'JOIN_DATE';
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_posts_sql(array &$sql_ary)
	{
		$sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts';
		$sql_ary['FROM'] += array(TOPICS_TABLE => 't');
		$sql_ary['FROM'] += array(POSTS_TABLE => 'p');
		$sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id';
		$sql_ary['GROUP_BY'] = 'u.user_id';
		$sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC';

		$this->info_header = 'POSTS';
		$this->view_mode = 'member_posts';
		$this->sql_date_field = 'p.post_time';
	}

	/**
	 * @param array $sql_ary
	 */
	protected function set_range_sql(array &$sql_ary)
	{
		if ($this->settings['date_range'] && $this->sql_date_field)
		{
			$range = $this->date_range->get($this->settings['date_range']);
			$this->explain_range = '&amp;date=' . $range['date'];

			$sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}";
		}
	}
}


1		<?php
2		/**
3		*
4		* @package sitemaker
5		* @copyright (c) 2013 Daniel A. (blitze)
6		* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7		*
8		*/
9
10		namespace blitze\sitemaker\services;
11
12		class members
13		{
14		/** @var \phpbb\db\driver\driver_interface */
15		protected $db;
16
17		/** @var \phpbb\user */
18		protected $user;
19
20		/** @var \blitze\sitemaker\services\date_range */
21		protected $date_range;
22
23		/** @var \blitze\sitemaker\services\template driver_interface */
24		protected $ptemplate;
25
26		/** @var string */
27		protected $phpbb_root_path;
28
29		/** @var string */
30		protected $php_ext;
31
32		protected $explain_range = '';
33		protected $sql_date_field = '';
34		protected $view_mode = 'member_date';
35		protected $user_header = 'USERNAME';
36		protected $info_header = 'MEMBERS_DATE';
37		protected $settings = array();
38
39		/**
40		* Constructor
41		*
42		* @param \phpbb\db\driver\driver_interface $db Database connection
43		* @param \phpbb\user $user User object
44		* @param \blitze\sitemaker\services\date_range $date_range Date range object
45		* @param \blitze\sitemaker\services\template $ptemplate Sitemaker template object
46		* @param string $phpbb_root_path Path to the phpbb includes directory.
47		* @param string $php_ext php file extension
48		*/
49	6	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\user $user, \blitze\sitemaker\services\date_range $date_range, \blitze\sitemaker\services\template $ptemplate, $phpbb_root_path, $php_ext)
50		{
51	6	$this->db = $db;
52	6	$this->user = $user;
53	6	$this->date_range = $date_range;
54	6	$this->ptemplate = $ptemplate;
55	6	$this->phpbb_root_path = $phpbb_root_path;
56	6	$this->php_ext = $php_ext;
57
58	6	if (!function_exists('phpbb_get_user_avatar'))
59	6	{
60		include($phpbb_root_path . 'includes/functions_display.' . $php_ext);
61		}
62	6	}
63
64		/**
65		* get members
66		* @param array $get
67		* @return string
68		*/
69	6	public function get_list(array $get = array())
70		{
71	6	$this->settings = $get + array(
72	6	'query_type' => 'recent',
73	6	'date_range' => '',
74	6	'max_members' => 5,
75	6	);
76
77	6	$sql = $this->get_sql_statement();
78	6	$result = $this->db->sql_query_limit($sql, $this->settings['max_members']);
79
80	6	$has_results = false;
81	6	while ($row = $this->db->sql_fetchrow($result))
82		{
83	6	$has_results = true;
84	6	$this->ptemplate->assign_block_vars('member', call_user_func_array(array($this, $this->view_mode), array($row)));
85	6	}
86	6	$this->db->sql_freeresult($result);
87
88	6	return $this->show_results($has_results);
89		}
90
91		/**
92		* @param array $row
93		* @return array
94		*/
95	1	protected function member_posts(array $row)
96		{
97	1	$u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&sr=posts" . $this->explain_range);
98	1	$user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>';
99
100		return array(
101	1	'USERNAME' => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
102	1	'USER_AVATAR' => phpbb_get_user_avatar($row),
103		'USER_INFO' => $user_posts
104	1	);
105		}
106
107		/**
108		* @param array $row
109		* @return array
110		*/
111	4	protected function member_date(array $row)
112		{
113		return array(
114	4	'USERNAME' => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
115	4	'USER_AVATAR' => phpbb_get_user_avatar($row),
116	4	'USER_INFO' => $this->user->format_date($row['member_date'], $this->user->lang['DATE_FORMAT'], true)
117	4	);
118		}
119
120		/**
121		* @param array $row
122		* @return array
123		*/
124	1	protected function member_bots(array $row)
125		{
126		return array(
127	1	'USERNAME' => get_username_string('username', $row['user_id'], $row['username'], $row['user_colour']),
128	1	'USER_INFO' => $this->user->format_date($row['member_date'])
129	1	);
130		}
131
132		/**
133		* @param bool $has_results
134		* @return string
135		*/
136	6	protected function show_results($has_results)
137		{
138	6	$html = '';
139		if ($has_results)
140	6	{
141	6	$this->ptemplate->assign_vars(array(
142	6	'S_LIST' => $this->settings['query_type'],
143	6	'L_USER' => $this->user->lang($this->user_header),
144	6	'L_INFO' => $this->user->lang($this->info_header),
145	6	));
146
147	6	$html = $this->ptemplate->render_view('blitze/sitemaker', 'blocks/members.html', 'members_block');
148	6	}
149
150	6	return $html;
151		}
152
153		/**
154		* @return string
155		*/
156	6	protected function get_sql_statement()
157		{
158		$sql_ary = array(
159	6	'SELECT' => 'u.user_id, u.username, u.user_colour, u.user_avatar, u.user_avatar_type, u.user_avatar_width, u.user_avatar_height',
160		'FROM' => array(
161	6	USERS_TABLE => 'u'
162	6	),
163	6	'WHERE' => $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)),
164	6	);
165
166	6	$sql_method = 'set_' . $this->settings['query_type'] . '_sql';
167	6	call_user_func_array(array($this, $sql_method), array(&$sql_ary));
168
169	6	$this->set_range_sql($sql_ary);
170
171	6	return $this->db->sql_build_query('SELECT', $sql_ary);
172		}
173
174		/**
175		* @param array $sql_ary
176		*/
177	2	protected function set_visits_sql(array &$sql_ary)
178		{
179	2	$sql_ary['SELECT'] .= ', u.user_lastvisit as member_date';
180	2	$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0';
181	2	$sql_ary['ORDER_BY'] = 'u.user_lastvisit DESC';
182
183	2	$this->sql_date_field = 'user_lastvisit';
184	2	}
185
186		/**
187		* @param array $sql_ary
188		*/
189	1	protected function set_bots_sql(array &$sql_ary)
190		{
191	1	$this->set_visits_sql($sql_ary);
192	1	$this->user_header = '';
193	1	$this->info_header = '';
194	1	$this->view_mode = 'member_bots';
195
196	1	$sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE;
197	1	}
198
199		/**
200		* @param array $sql_ary
201		*/
202	3	protected function set_tenured_sql(array &$sql_ary)
203		{
204	3	$sql_ary['SELECT'] .= ', u.user_regdate as member_date';
205	3	$sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
206
207	3	$this->sql_date_field = 'u.user_regdate';
208	3	$this->settings['date_range'] = '';
209	3	}
210
211		/**
212		* @param array $sql_ary
213		*/
214	1	protected function set_recent_sql(array &$sql_ary)
215		{
216	1	$this->set_tenured_sql($sql_ary);
217	1	$this->info_header = 'JOIN_DATE';
218	1	}
219
220		/**
221		* @param array $sql_ary
222		*/
223	1	protected function set_posts_sql(array &$sql_ary)
224		{
225	1	$sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts';
226	1	$sql_ary['FROM'] += array(TOPICS_TABLE => 't');
227	1	$sql_ary['FROM'] += array(POSTS_TABLE => 'p');
228	1	$sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id';
229	1	$sql_ary['GROUP_BY'] = 'u.user_id';
230	1	$sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC';
231
232	1	$this->info_header = 'POSTS';
233	1	$this->view_mode = 'member_posts';
234	1	$this->sql_date_field = 'p.post_time';
235	1	}
236
237		/**
238		* @param array $sql_ary
239		*/
240	6	protected function set_range_sql(array &$sql_ary)
241		{
242	6	if ($this->settings['date_range'] && $this->sql_date_field)
243	6	{
244		$range = $this->date_range->get($this->settings['date_range']);
245		$this->explain_range = '&date=' . $range['date'];
246
247		$sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}";
248		}
249	6	}
250		}
251

blitze / phpBB-ext-sitemaker

Push — master ( a0ceb6...422577 )

members::set_range_sql() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like